DevHeads.net

Reply to comment

Re: Review Request 122227: KRecursiveFilterProxyModel: many many

By Milian Wolff at 01/25/2015 - 18:11

Ship it!

Looking at the code, I can't see anything obvious, but its highly complicate code base anyway. So given that you add all these tests, I'm all for landing this. Many thanks!

other than that: the code style is neither kf5 nor qt5, is it? something we might want to change in the future.

kdeui/tests/krecursivefilterproxymodeltest.cpp
<https://git.reviewboard.kde.org/r/122227/#comment51801>

is this still required in qt5? this should really be added upstream, imo...

kdeui/tests/krecursivefilterproxymodeltest.cpp
<https://git.reviewboard.kde.org/r/122227/#comment51803>

style: { on newline?

- Milian Wolff

On Jan. 23, 2015, 6:11 p.m., David Faure wrote:

Reply