DevHeads.net

AW: KDE Review: Moving Smb4K to extragear/network

[...]

What's your target "virtual module"? extragear/utils?

I'm not completely sure what you mean by "virtual module". Do you mean the repository where eventually Smb4K should be placed in after review?

I don't think your plasmoid is getting properly i18n'ed since i don't see how
it would load the smb4k catalog. Have you tried it works?

On my desktop it is fully translated. However, I'd be happy about hints how to improve the plugin.

Also you're using kde4_add_kdeinit_executable, can you explain why?

Frankly, I don't remember. I think it had to do with some strange debug messages from kdelibs that I tried to get rid of. I can revert this.

Also, as commented in the i18n list, i think it makes sense you move the
docbook to this repo.

Done.

Not sure about this one, so asking others, what does the manifesto say about
webpages? Should it be on *.kde.org too? Or sf.net is fine?

[...]

Best regards
Alexander

Comments

Re: AW: KDE Review: Moving Smb4K to extragear/network

By Albert Astals Cid at 01/16/2014 - 18:23

El Dijous, 16 de gener de 2014, a les 09:13:46, alexander.reinholdt@t-
online.de va escriure:
Where in
<a href="https://projects.kde.org/projects/extragear" title="https://projects.kde.org/projects/extragear">https://projects.kde.org/projects/extragear</a>
do you want it to live?

I'd like to know which warnings you were getting without it, because it seems
a bit of a weird thing to do (use kde4_add_kdeinit_executable in a regular
app)

Cheers,
Albert

Re: AW: KDE Review: Moving Smb4K to extragear/network

By Alexander Reinholdt at 01/18/2014 - 10:31

Am Freitag, 17. Januar 2014, 00:23:27 schrieb Albert Astals Cid:

[...]

I would like to place it in extragear/network, if that's possible.

As far as I can remember it was the following message, that triggered this:

QDBusConnection: session D-Bus connection created before QCoreApplication.
Application may misbehave.

However, the change to kde4_add_kdeinit_executable did not change this, but I
did not revert the change.

As I said, I can revert this and will acually do it with the next commit.

[...]

Best regards
Alexander

Re: AW: KDE Review: Moving Smb4K to extragear/network

By Alexander Reinholdt at 01/17/2014 - 15:01

Am Freitag, 17. Januar 2014, 00:23:27 schrieb Albert Astals Cid:
I would like to place it in extragear/network, if that's possible.

As far as I can remember it was the following message, that triggered this:

QDBusConnection: session D-Bus connection created before QCoreApplication.
Application may misbehave.

However, the change to kde4_add_kdeinit_executable did not change this, but I
did not revert the change.

As I said, I can revert this and will acually do it with the next commit.

Re: KDE Review: Moving Smb4K to extragear/network

By =?utf-8?q?Burkh... at 01/16/2014 - 16:38

Am Mittwoch, 15. Januar 2014, 20:17:52 schrieb Albert Astals Cid:
Hmm, running smb4k in locale x-test with recent smb4k compiled from sources in
master only the settings dialog for the smb4k plasmoid is translated, but not
the dialog opened with a left mouse button click on the smb4k plasmoid icon.
This dialog shows no "xx" around the gui strings.

And like Albert I fail to see any code to load the translation catalog smb4k
in the plasmoid.

Re: KDE Review: Moving Smb4K to extragear/network

By Alexander Reinholdt at 01/19/2014 - 04:34

[...]

I checked the the code and compared it with the tutorials on techbase. And I
seem to have done everything necessary: All strings in the QML code are
translatable and the strings are correctly extracted from the QML files as
well. Could you please give me a hint, what's missing?

Best regards
Alexander

Re: KDE Review: Moving Smb4K to extragear/network

By =?utf-8?q?Burkh... at 01/20/2014 - 06:55

Am Sonntag, 19. Januar 2014, 10:34:35 schrieb Alexander Reinholdt:
But your plasmoid tries to load the translation catalog "plasma_applet_smb4k-
qml", but this catalog does not exist, therefore the plasmoid gui is
untranslated.

The catalog name for the plasmoid is generated in kde-runtime/plasma/:

scriptengines/javascript/plasmoid/declarativeappletscript.cpp#90
KGlobal::locale()->insertCatalog("plasma_applet_" %
description().pluginName());

With plasmoid/package/metadata.desktop:32:X-KDE-PluginInfo-Name=smb4k-qml the
catalogname is "plasma_applet_smb4k-qml"

Adding a Messages.sh in smb4k/plasmoid/ with

#!/bin/bash
$XGETTEXT `find . -name \*.qml` -L Java -o $podir/plasma_applet_smb4k-qml.pot

makes the plasmoid gui translated, but e.g. the dialogs "Edit Bookmarks" +
"Mount Share" opened from the plasmoid are still untranslated, because the
messages for them are in smb4k.

@Albert: How to solve this dilemma?

Re: KDE Review: Moving Smb4K to extragear/network

By Albert Astals Cid at 01/20/2014 - 17:33

El Dilluns, 20 de gener de 2014, a les 12:55:52, Burkhard Lück va escriure:
The proper solution would probably be splitting the thing into 3 .pot files,
one for core/ that gets loaded with a KCatalogLoader, one for smb4k that gets
loaded by the regular KAboutData/KComponentData way and another for the
plasmoid that gets loaded the plasmoid way.

The easy solution is just adding a KCatalogLoader of smb4k catalog somewhere
in core/

Cheers,
Albert

AW: KDE Review: Moving Smb4K to extragear/network

By Alexander Reinholdt at 01/23/2014 - 03:08

[...]

The proper solution would probably be splitting the thing into 3 .pot files,
one for core/ that gets loaded with a KCatalogLoader, one for smb4k that gets
loaded by the regular KAboutData/KComponentData way and another for the
plasmoid that gets loaded the plasmoid way.

The easy solution is just adding a KCatalogLoader of smb4k catalog somewhere
in core/

Thanks for the directions, Burkhard and Albert. I will split the current catalogue into three *.pot files as suggested by Albert.

Cheers,
Alexander

Re: AW: KDE Review: Moving Smb4K to extragear/network

By =?utf-8?q?Burkh... at 01/23/2014 - 16:25

Am Donnerstag, 23. Januar 2014, 09:08:03 schrieb alexander.reinholdt@t-
online.de: