DevHeads.net

Bringing back rsibreak from unmaintained

Hi guys, i just merged the frameworks port of rsibreak to master.

rsibreak is in the unmaintained silo, i'd like to bring it back to extragear-
utils (i guess kdeutils is too much for this niche app?).

Anyone wants to review it?

Other comments?

Cheers,
Albert

Comments

Re: Bringing back rsibreak from unmaintained

By Christoph Feck at 08/18/2015 - 19:00

On Monday 17 August 2015 20:04:04 Albert Astals Cid wrote:
-- Build files have been written to: /local/build/kf5/rsibreak
/local/git/extragear/utils/rsibreak/src/rsitimer.cpp:26:20: fatal
error: kdebug.h: No such file or directory
#include <kdebug.h>
^
compilation terminated.
make[2]: *** [src/CMakeFiles/rsibreak.dir/rsitimer.cpp.o] Error 1
/local/git/extragear/utils/rsibreak/src/rsiglobals.cpp:24:29: fatal
error: kglobalsettings.h: No such file or directory
#include <kglobalsettings.h>
^
compilation terminated.
make[2]: *** [src/CMakeFiles/rsibreak.dir/rsiglobals.cpp.o] Error 1
make[2]: Target `src/CMakeFiles/rsibreak.dir/build' not remade because
of errors.
make[1]: *** [src/CMakeFiles/rsibreak.dir/all] Error 2
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default_target' not remade because of errors.
-- Failed: rsibreak

Re: Bringing back rsibreak from unmaintained

By Albert Astals Cid at 08/18/2015 - 19:10

El Dimecres, 19 d'agost de 2015, a les 01:00:13, Christoph Feck va escriure:
Fixed! thanks :)

Salut,
Albert

Re: Bringing back rsibreak from unmaintained

By =?iso-8859-1?Q?... at 08/18/2015 - 19:09

On Wednesday, 19 August 2015 01:00:13 CEST, Christoph Feck wrote:
A missing dep on kde4libssupport, <a href="https://git.reviewboard.kde.org/r/124809/" title="https://git.reviewboard.kde.org/r/124809/">https://git.reviewboard.kde.org/r/124809/</a>
.

Jan

Re: Bringing back rsibreak from unmaintained

By =?iso-8859-1?Q?... at 08/18/2015 - 13:06

On Monday, 17 August 2015 20:04:04 CEST, Albert Astals Cid wrote:
Nice, happy to see it -- it builds here, with a bunch of warnings:

[2/29] Generating index.cache.bz2
index.docbook:2: element para: validity error : ID gnu-fdl already defined
element div: validity error : ID header already defined
element div: validity error : ID header_content already defined
element div: validity error : ID header_left already defined
element div: validity error : ID header_right already defined
element div: validity error : ID header already defined
element div: validity error : ID header_content already defined
element div: validity error : ID header_left already defined
element div: validity error : ID header_right already defined
element div: validity error : ID footer already defined
element div: validity error : ID footer_text already defined
element div: validity error : ID header already defined
element div: validity error : ID header_content already defined
element div: validity error : ID header_left already defined
element div: validity error : ID header_right already defined
element div: validity error : ID footer already defined
element div: validity error : ID footer_text already defined
element div: validity error : ID header already defined
element div: validity error : ID header_content already defined
element div: validity error : ID header_left already defined
element div: validity error : ID header_right already defined
element div: validity error : ID footer already defined
element div: validity error : ID footer_text already defined
element div: validity error : ID header already defined
element div: validity error : ID header_content already defined
element div: validity error : ID header_left already defined
element div: validity error : ID header_right already defined
element div: validity error : ID footer already defined
element div: validity error : ID footer_text already defined
element div: validity error : ID footer already defined
element div: validity error : ID footer_text already defined

The stderr is full of output which probably just wastes space. I don't
think that these are good default settings:

********** resetAfterTinyBreak !!
********** resetAfterBigBreak !!
********** resetAfterTinyBreak !!
********** resetAfterTinyBreak !!

However, the worst thing is that the passive popup for tiny breaks doesn't
appear to notice that I'm still moving my mouse. This is with KF5 and
Plasma5 from git from very late July, on X11.

Cheers,
Jan

Re: Bringing back rsibreak from unmaintained

By Albert Astals Cid at 08/18/2015 - 18:30

El Dimarts, 18 d'agost de 2015, a les 19:06:22, Jan Kundrát va escriure:
Same warning every single KDE app gives you when building the docbook.

These messages are not new, IMHO does not apply to this request of bringing
back from unmaintiained ;)

Besides this is supposed to be auto-run so it's not like you'll see that.
Are you sure about that? You mean the countdown goes down even if you move the
mouse?

Cheers,
Albert

Re: Bringing back rsibreak from unmaintained

By =?iso-8859-1?Q?... at 08/18/2015 - 19:01

On Wednesday, 19 August 2015 00:30:01 CEST, Albert Astals Cid wrote:
I agree that it's not a blocker of course, but you asked for feedback :).

Yes, that's what I'm seeing. It's interesting that the idle tracking
appears to work when nothing is displayed, i.e., during the normal mode,
the app detects that I'm actively using my computer and starts tracking my
activity and the taskbar icon (the violet pie) goes from 100% to 75% when I
start typing something, and back to 100% violet after a short while of
inactivity. It's just the attention grabber "hey, stop working now" which
ignores my activity and continues the countdown as if I were idle.

The countdown "please relax for %1 second(s)" just doesn't notice my mouse
or keyboard activity. In addition, it's always shown as a passive pop-up
even when I pick "Simple Gray Effect" as a notification effect during
breaks.

Cheers,
Jan

Re: Bringing back rsibreak from unmaintained

By Albert Astals Cid at 08/30/2015 - 18:10

El Dimecres, 19 d'agost de 2015, a les 01:01:35, Jan Kundrát va escriure:
The configuration dialog itself was a bit weirdly worded, i've pushed some
text changed and also removed some settings that where "too much flexibility",
that hopefully would make it easier to understand.

Can you check again?

Cheers,
Albert

Re: Bringing back rsibreak from unmaintained

By Jeremy Paul Whiting at 08/30/2015 - 20:50

Just rebuilt it. It seems to run ok. The config dialog does look a lot
cleaner. nice work. I'll report back if I hit any issues as it runs
and such.

On Sun, Aug 30, 2015 at 4:10 PM, Albert Astals Cid < ... at kde dot org> wrote:

Re: Bringing back rsibreak from unmaintained

By Albert Astals Cid at 09/07/2015 - 13:58

El Diumenge, 30 d'agost de 2015, a les 18:50:12, Jeremy Whiting va escriure:
Since there's been no complains i'll ask for it to be moved to extragear-
utils.

Cheers,
Albert

Re: Bringing back rsibreak from unmaintained

By Jeremy Paul Whiting at 08/18/2015 - 18:41

That surprises me. It worked fine here as I've been testing it with
everything else built on master.

On Tue, Aug 18, 2015 at 4:30 PM, Albert Astals Cid < ... at kde dot org> wrote:

Re: Bringing back rsibreak from unmaintained

By Luigi Toscano at 08/18/2015 - 16:49

Jan Kundrát ha scritto:
Please revert your libxml2 to a previous version:
<a href="https://bugzilla.gnome.org/show_bug.cgi?id=737840" title="https://bugzilla.gnome.org/show_bug.cgi?id=737840">https://bugzilla.gnome.org/show_bug.cgi?id=737840</a>

Ciao

Re: Bringing back rsibreak from unmaintained

By Jeremy Paul Whiting at 08/17/2015 - 15:37

Builds and runs fine here. I say +1

On Mon, Aug 17, 2015 at 12:04 PM, Albert Astals Cid < ... at kde dot org> wrote: