DevHeads.net

Broken build of KDE Base Apps and unauthorized increase in dependency

Hi Dawit,

It has come to my attention that since commit
603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the
build for it has been broken.
This is due to it depending on new features, present only in the KDE/4.9 branch.

This is problematic because:
- kde-baseapps depends upon a minimum of 4.7.97 (ie. KDE 4.8) which
obviously is no longer the case. It depends upon unreleased code.
- This feature will not be in KDE 4.10 at the moment, because the
feature was added to KDE/4.9 instead of KDE/4.10 as it should have
been.

Please see <a href="http://build.kde.org/view/FAILED/job/kde-baseapps_master/8/console" title="http://build.kde.org/view/FAILED/job/kde-baseapps_master/8/console">http://build.kde.org/view/FAILED/job/kde-baseapps_master/8/console</a>
for further information.

Regards,
Ben Cooksley

Comments

Re: Broken build of KDE Base Apps and unauthorized increase in d

By Dawit A at 09/11/2012 - 09:05

That is only a temporary situation. All the changes in the 4.9 branch are
periodically merged into
the 4.10 branch by David, but I guess that does not resolve this issue.

Ahh... I was not aware of this was a requirement though I still do not
understand why we have started insisting on forward compatibility.
Regardless, I will fix this since it is only a matter of wrapping the code
with #ifdef.

It is not a new feature. It is a bug fix. It is needed to fix the directory
filter plugin for Konqueror.

Re: Broken build of KDE Base Apps and unauthorized increase in d

By Dawit A at 09/12/2012 - 14:04

First, sorry I confused kdelibs with kde-baseapps in this response. So
forget what I said about changes being merged back into 4.10 branch by
David. Anyhow, I have now attempted to fix this issue as reported here. See

<a href="http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b" title="http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b">http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1...</a>
.

However this fix does not really work. That is compile will fail if KDE
version is changed to 4.9.2 as well because Qt's moc processor does not
seem to correctly handle #if macros. So my question is whether it would be
acceptable for me to revert this change from the git 4.9 branch and simply
leave it as it was in the git master branch ? IOW, kde-baseapps 4.10
release will have a minimum requirement of kdelibs 4.9.2 ?

Re: Broken build of KDE Base Apps and unauthorized increase in d

By Ralf Jung at 09/13/2012 - 11:39

Hi,

Kind regards,
Ralf

Re: Broken build of KDE Base Apps and unauthorized increase in d

By =?utf-8?Q?Thoma... at 09/12/2012 - 14:12

Am 12.09.2012, 20:04 Uhr, schrieb Dawit A < ... at kde dot org>:

*sigh* "not at all" is more like it. **GREATSIGH***

You'll have to move the class into an extra header and make it's inclusion
and moc invocation (latter in cmake) optional.

**** DOUBLEGREATSIGH *****

Cheers,
Thomas

Re: Broken build of KDE Base Apps and unauthorized increase in d

By Allen Winter at 09/12/2012 - 14:50

On Wednesday 12 September 2012 08:12:58 PM Thomas Lübking wrote:
Dawit,

I agree with Thomas. Can you try to put the new class into a separate file?
and then only compile the new file if kde version >= 4.9.2

Re: Broken build of KDE Base Apps and unauthorized increase in d

By Dawit A at 09/12/2012 - 15:29

Yes, I can and that is already what I have done locally to workaround the
shortcomings of the moc preprocessor. However, I though I would ask to see
if it would have been acceptable to avoid the addition of new files and use
of conditional macros by changing the minimum kdelibs version requirement
for the kde-baseapps git master repo instead. I guess the consensus is NO
and that is fine by me. I will commit what I have already done.

Regards,
Dawit A.