DevHeads.net

Failing testcase in kpasswdservertest [kde-runtime]

Hi Dawit, can you please have a look at kpasswdservertest?

It's asserting in

QFATAL : KPasswdServerTest::testRetryDialog() ASSERT: "request" in file
/srv/jenkins/workspace/kde-runtime_stable/kpasswdserver/kpasswdserver.cpp,
line 1041

Looking at the code there's an "if (request)" just after the
"Q_ASSERT(request)" so it works in release mode, but i'd like to know if

a) we should fix something
b) we should just remove the assert

To get the test passing again.

Cheers,
Albert

Comments

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Albert Astals Cid at 12/09/2013 - 19:35

Dawit? Are you there? Or anyone?

This is still asserting and the tagging of 4.12 is in two days, I'd prefer not
to have to delay it because of the failing test.

Cheers,
Albert

El Diumenge, 24 de novembre de 2013, a les 23:26:38, Albert Astals Cid va
escriure:

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Dawit A at 12/10/2013 - 09:57

Sorry for the late response. I did not see this email for some reason. None
of the test cases in testRetryDialog hit that assert on my machine. If this
unit test fails on your system, can you please enable the debug area for
KPasswdServer, run the unit test only for testRetryDialog only and provide
the output from it? I am curious to know why it would start failing all of
the sudden since nothing was changed in that code base in a very long time.

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Albert Astals Cid at 12/10/2013 - 14:45

El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure:
Is your Qt compiled in debug or release? Because as my original e-mail says if
it's in release the assert won't trigger.

Attached, is that enough?

Because we switched to a debug Qt that now has asserts enabled.

Cheers,
Albert

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Dawit A at 12/10/2013 - 21:52

Ahh... I assumed you were talking about kde-runtime not Qt.

That is fine. The test is indeed doing the wrong thing. It conflated two
cases that should be tested separately into one.

Right.

Can you please check if the attached pass works fine for you? It fixes the
broken test case for me here.

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Ben Cooksley at 12/11/2013 - 04:30

I have now tested that patch on the CI system. It fixes the issue Albert
mentions.

Test project /srv/jenkins/workspace/kde-runtime_master/build
Start 1: kpasswdservertest
1/9 Test #1: kpasswdservertest ................ Passed 0.28 sec
Start 2: testkioarchive
2/9 Test #2: testkioarchive ................... Passed 0.29 sec
Start 3: testtrash
3/9 Test #3: testtrash ........................ Passed 1.72 sec
Start 4: testdesktop
4/9 Test #4: testdesktop ...................... Passed 0.31 sec
Start 5: kurifiltertest
5/9 Test #5: kurifiltertest ................... Passed 10.07 sec
Start 6: backtraceparsertest
6/9 Test #6: backtraceparsertest .............. Passed 5.67 sec
Start 7: filetypestest
7/9 Test #7: filetypestest .................... Passed 1.18 sec
Start 8: sortfiltermodeltest
8/9 Test #8: sortfiltermodeltest .............. Passed 0.04 sec
Start 9: fullmodelaccesstest
9/9 Test #9: fullmodelaccesstest .............. Passed 0.01 sec

100% tests passed, 0 tests failed out of 9

Regards,
Ben

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Dawit A at 12/11/2013 - 14:59

Great. I will commit the patch once I get a chance then. Unless of course
either you or Albert has already done so.

Re: Failing testcase in kpasswdservertest [kde-runtime]

By Albert Astals Cid at 12/11/2013 - 15:05

El Dimecres, 11 de desembre de 2013, a les 13:59:57, Dawit A va escriure:
I just did it.

Cheers,
Albert