DevHeads.net

Fix kopete/kdenetwork build against Qt 4.8

Hello,

Qt 4.8 has a change to moc which makes virtual inheritance from QObject no
longer possible. This caused a problem in Jovie that was fixed by not
virtually inheriting from QObject anymore. There is a similar compile
problem in kdenetwork/kopete/libkopete at the moment and the attached patch
fixes the problem. I can commit to 4.7 and trunk if it looks good to
others.

thanks,
Jeremy

P.S. I would have used reviewboard, but there's no kdenetwork or kopete
repository set up in there :)

Comments

Re: Fix kopete/kdenetwork build against Qt 4.8

By David Faure at 08/11/2011 - 04:47

On Thursday 04 August 2011 07:46:57 Jeremy Whiting wrote:
Looks definitely good. Virtual inheritance has only given us trouble, with
things like qobjects. +1 for getting rid of 'virtual' there.

Re: Fix kopete/kdenetwork build against Qt 4.8

By Christoph Feck at 08/04/2011 - 09:39

On Thursday 04 August 2011 15:46:57 Jeremy Whiting wrote:
<a href="https://svn.reviewboard.kde.org/groups/" title="https://svn.reviewboard.kde.org/groups/">https://svn.reviewboard.kde.org/groups/</a>