DevHeads.net

imagewriter in kdereview

Please review imagewriter which I've just had moved to kdereview.

It's a simple tool to write ISO images to a USB key. It should be
cross platform and work on Linux, mac, windows.

It's based on ROSA Image Writer and the ROSA maintainer has agreed to
maintain it in KDE. Compared to ROSA I've switched to i18n and used
kauth and made the ROSA branding optional.

Scarlett has started making an AppImage for it although I don't know
if it'll work with KAuth
<a href="https://github.com/appimage-packages/imagewriter/issues/1" title="https://github.com/appimage-packages/imagewriter/issues/1">https://github.com/appimage-packages/imagewriter/issues/1</a>

Jonathan

Comments

Re: imagewriter in kdereview

By Albert Astals Cid at 04/08/2017 - 12:22

El divendres, 7 d’abril de 2017, a les 15:21:20 CEST, Jonathan Riddell va
escriure:
It doesn't build <a href="https://paste.kde.org/p4mj6bgms" title="https://paste.kde.org/p4mj6bgms">https://paste.kde.org/p4mj6bgms</a>

Also i find that imagewriter is a bit "too generic", maybe iso-imagewriter?

Otherwise the first thing i thought is something that creates png/jpeg/etc.

Cheers,
Albert

Re: imagewriter in kdereview

By Jonathan Riddell at 04/10/2017 - 12:41

On 8 April 2017 at 17:22, Albert Astals Cid < ... at kde dot org> wrote:
Spooky. Fixed.

I've renamed it now to isoimagewriter. But now KAuth doesn't like it, sigh.

Jonathan

Re: imagewriter in kdereview

By Albert Astals Cid at 04/10/2017 - 15:51

El dilluns, 10 d’abril de 2017, a les 17:41:17 CEST, Jonathan Riddell va escriure:
Because of this?

./imagewriter/maindialog.cpp:330: KAuth::Action action(QLatin1String("org.kde.imagewriter.writefile"));
./imagewriter/maindialog.cpp:331: action.setHelperId("org.kde.imagewriter");
./imagewriter/CMakeLists.txt:18: imagewriter.cpp
./imagewriter/testy.cpp:53: KAuth::Action action(QLatin1String("org.kde.imagewriter.writeimage"));
./imagewriter/testy.cpp:54: action.setHelperId("org.kde.imagewriter");
./imagewriter/testy.cpp:78: KAuth::Action action(QLatin1String("org.kde.imagewriter.writeimage"));
./imagewriter/testy.cpp:79: action.setHelperId("org.kde.imagewriter");
./imagewriter/testy.cpp:171: KAuth::Action action(QLatin1String("org.kde.imagewriter.writefile"));

Also ./Messages.sh seems to not have been updated

And also there's a ts/ folder, why?

Cheers,
Albert

Re: imagewriter in kdereview

By Luigi Toscano at 04/07/2017 - 15:14

Jonathan Riddell ha scritto:
Does it mean that the make-it-cool branch will be merged to master soon?
The current master has no support for KI18n (and not even for
ecm_install_po_files_as_qm). I think that it's better to wait until it's
merged before enabling the translations.

Re: imagewriter in kdereview

By Jonathan Riddell at 04/08/2017 - 04:52

On 7 April 2017 at 20:14, Luigi Toscano <luigi. ... at tiscali dot it> wrote:
Oh yes sorry I should have done that before. Merged into master now.

Jonathan