DevHeads.net

KDE Workspace broken due to upstream CMake changes

Hi all,

It seems that a recent upstream change in CMake has now broken the
build of KDE Workspace. Can someone please fix or prod CMake upstream
into revising their policies?

The lack of warning here concerning the change is a little irritating.

-- Looking for XkbLockModifiers in X11
CMake Error at CMakeLists.txt:10 (ADD_EXECUTABLE):
Target "cmTryCompileExec744440252" links to item "/usr/lib64/libXpm.so "
which has leading or trailing whitespace. This is now an error according
to policy CMP0004.

CMake Error: Internal CMake error, TryCompile generation of cmake failed
-- Looking for XkbLockModifiers in X11 - not found

Regards,
Ben Cooksley

Comments

Re: KDE Workspace broken due to upstream CMake changes

By Rolf Eike Beer at 05/27/2013 - 08:51

Am 27.05.2013 09:13, schrieb Ben Cooksley:
That's what the policies are for at all ;)

cmake --help-policy CMP0004

So, fix whatever is causing this, and in the meantime use:

cmake_policy(SET CMP0004 OLD)

Eike

Re: KDE Workspace broken due to upstream CMake changes

By Ben Cooksley at 05/27/2013 - 15:53

On Tue, May 28, 2013 at 12:51 AM, Rolf Eike Beer
< ... at opensource dot sf-tec.de> wrote:
I'm not sure that we are responsible for FindX11 - which is what I
guess is triggering this (based on preceding and following messages
from CMake)

Regards,
Ben

Re: KDE Workspace broken due to upstream CMake changes

By Alexander Neundorf at 05/27/2013 - 15:37

On Monday 27 May 2013, Rolf Eike Beer wrote:
hmm, not really.
CMP0004 is not new. It was working with cmake 2.8.10, so it should, well must,
work also with 2.8.11.

Alex

Re: KDE Workspace broken due to upstream CMake changes

By Ben Cooksley at 05/27/2013 - 15:52

On Tue, May 28, 2013 at 7:37 AM, Alexander Neundorf < ... at kde dot org> wrote:
Does this mean we have found a regression in CMake?
Or is the policy being enforced more strictly now?

(ie. should CMake be fixed, or do we need to be fixed)

Regards,
Ben

Re: KDE Workspace broken due to upstream CMake changes

By Alexander Neundorf at 05/27/2013 - 16:00

On Monday 27 May 2013, Ben Cooksley wrote:
I think the rule is quite simple: a new cmake release must not break existing
builds.

Alex

Re: KDE Workspace broken due to upstream CMake changes

By Ben Cooksley at 05/28/2013 - 06:29

Hi Alex,

Can someone more familiar with the CMake community please inform them
of this regression?
It is breaking the KDE Continuous Integration system - i'd appreciate
being informed once the fix has landed in their Git repository, so we
can deploy it.

Regards,
Ben

Re: KDE Workspace broken due to upstream CMake changes

By Stephen Kelly at 05/28/2013 - 07:44

<a href="http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/46742/focus=46776" title="http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/46742/focus=46776">http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/46742/fo...</a>

Re: KDE Workspace broken due to upstream CMake changes

By Stephen Kelly at 05/30/2013 - 08:24

I have pushed a fix to next. Please update and try again.

Thanks,

Steve.

Re: KDE Workspace broken due to upstream CMake changes

By Ben Cooksley at 05/31/2013 - 04:40

On Fri, May 31, 2013 at 12:24 AM, Stephen Kelly < ... at gmail dot com> wrote:
Hi Stephen,

Much appreciated. The build of kde-workspace is now successful again.
Thanks for taking care of that.

Regards,
Ben