DevHeads.net

Kdiff3 in kdereview

Kdiff3 has moved to review in preparation for possible release testing. I
am currently working towards having auto testing but the code needs major
refactoring to make this possible. Specifically it is not well modularized.
The purpose of this review is to get feedback on issues that need to be
addressed before moving out of playground.

Comments

Re: Kdiff3 in kdereview

By Albert Astals Cid at 08/23/2018 - 18:07

El dimarts, 7 d’agost de 2018, a les 14:59:50 CEST, Michael Reeves va escriure:
Have you seen there's 4 wrong connect signals on startup?
<a href="https://paste.kde.org/pcvcje3u1" title="https://paste.kde.org/pcvcje3u1">https://paste.kde.org/pcvcje3u1</a>

When trying to compare any two files i hit this assert

if(m_lmppData.m_vSize < m_normalData.m_vSize)
{
//This a bug that needs fixed elsewhere not hacked around
Q_ASSERT(m_lmppData.m_vSize == m_normalData.m_vSize);

Which i do not understand what it is trying to do, i mean you just checked that they are different and the on the next line assert they are not different?

Cheers,
Albert