DevHeads.net

KF5 kwallet, kwalletd and wallet manager questions

Hello,

Now that frameworks splitting is almost done ;-) with some people even
running KF5-based sessions on their systems, I'd like to plan kwallet
porting and integration. BTW, I'd like also to announce that I agreed
with Michael Leupold to take over the maintainership of KWallet and I'm
now committed to do that. I also plan to add new features to kwallet, as
some of you may remember from our Randa discussions. But I'll make
another announcement(s) regarding these new features and ksecretsservice.

Here are my questions about kwallet in KF5:
* what tier will kwallet end-in? Note that kwallet.h is included only by
khtml, whose tier is not yet defined

* AFAIK, frameworks should be independent and self-contained. kwallet
depends on kde-runtime/kwalletd. This component should be detached from
kde-runtime sources and attached inside kwallet/src/kwalletd, preserving
history if possible. I can handle this task if that's OK for you (Aron,
David, Kevin?)

* Another piece of software related to kwallet is KWalletManager from
kdeutils. I think that component should also be detached from kdeutils
and attached under kwallet/src/manager. I can also handle this task if
that's OK (Aron, David, Kevin but also Raphael?)

* kwallet is now in staging ; should I wait for it to go to it's final
tier? I can do this tier adjusting changing task and I'd also like to
start these tasks as quick as possible.

Thanks for reading and I'd be grateful for a quick reply on these topics.

Regards,

Comments

Re: KF5 kwallet, kwalletd and wallet manager questions

By Christoph Feck at 08/28/2013 - 12:05

On Saturday 24 August 2013 12:31:20 Valentin Rusu wrote:
Nice to see you stepping up to the plate :) Could you please inform
bugzilla maintainers to change the default assignee address for
kwalletmanager and kdelibs/kwallet?

Merci

Christoph Feck (kdepepo)
KDE Quality Team

Re: KF5 kwallet, kwalletd and wallet manager questions

By Valentin Rusu at 09/01/2013 - 16:11

On 08/28/2013 07:05 PM, Christoph Feck wrote:
OK, I filed a sysadmin request for this.

Regards,
Valentin

Re: KF5 kwallet, kwalletd and wallet manager questions

By Albert Astals Cid at 08/24/2013 - 06:43

El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure:
This makes sense and AFAIK is what is intended with frameworks, i.e. if a lib
needs a binary, that binary and the lib should be shipped together

Not sure this bundling makes sense. KWalletManager is a tool that if i am a
developer for Windows that wants to use the kwallet framework I don't need.
Actually it's a utility a regular user should probably never need unless you
use it to manually store stuff (I do) or you want to inspect what apps store
(I do).

Of course I don't have much of a decision power on this but wanted to express
my concerns ;-)

Cheers and congratulations for your new maintainership,
Albert

Re: KF5 kwallet, kwalletd and wallet manager questions

By Valentin Rusu at 08/25/2013 - 05:05

On 08/24/2013 01:43 PM, Albert Astals Cid wrote:
I also use the KWalletManager on windows as a secret storing tool, at my
workplace. The other KDE components I use at work do not seem to use the
kwalletd. Chrome for Windows do not detect kwallet as it does under
Linux. So, AFAICT, Windows users are interested by using KWalletManager,
and this requires kwalletd, which is packaged separately. I think that
even for this case we should bundle these components together. That
would also help other contributors better understand kwallet's structure
and allow them contribute more easily.

Thanks

Re: KF5 kwallet, kwalletd and wallet manager questions

By Albert Astals Cid at 08/28/2013 - 13:26

El Diumenge, 25 d'agost de 2013, a les 12:05:11, Valentin Rusu va escriure:
If you bundle lots of stuff in the tarball you may end up "wrongly" increasing
your dependencies and people won't use the framework because "it depends on
QtNetwork" or some other stuff that it's only used in kwalletmanager.

Please let's not bundle stuff just because it's easier when there's a lot of
people unbundleing stuff because it's better.

Cheers,
Albert

Re: KF5 kwallet, kwalletd and wallet manager questions

By Kevin Krammer at 08/24/2013 - 07:32

On Saturday, 2013-08-24, Albert Astals Cid wrote:
One thing that could be put into consideration is whether the library/API
would work with any SecretService implementation or require kwalletd
specifically.

Cheers,
Kevin

Re: KF5 kwallet, kwalletd and wallet manager questions

By Valentin Rusu at 08/25/2013 - 04:55

On 08/24/2013 02:32 PM, Kevin Krammer wrote:
The kwallet API is only implemented by kwalletd AFAIK. So for this API's
cas, we should provide kwalletd along with it.

The new secret service API, on the other hand, is likely to have several
implementation. In that cas, the daemon should not be systematically
tied-in.

I think that future versions of the kwallet framework will have
configure options, to let packagers/users choose what to install.

Re: KF5 kwallet, kwalletd and wallet manager questions

By Kevin Krammer at 08/25/2013 - 05:35

On Sunday, 2013-08-25, Valentin Rusu wrote:
Ah, I see. I thought that the KDE client API for secret service would
currently be part of that framework, but of course if it is separate than that
is even better.
The LXDE folks are looking into secure storage and currently seem to consider
gnome-keyring as the daemon, so having a ready Qt API without runtime
dependencies would certainly be of interest to them.

Right, makes sense. I was mostly concerned about the Secret Service part which
I mistakingly thought was part of the kwallet framework dicussed here.

Cheers,
Kevin