DevHeads.net

Notes from the Phabricator BoF

Hi all,
thanks to Victor Blazquez, here are the notes from the Phabricator BoF. Feel
free to add your comments and corrections.

Feedback on Phabricator gathered outside the BoF from people who could not
attend:
krita
used for everything (reviews, tasks, mockups, even bugs);
overwelmingly positive feedback from community
- annoyance: big unified list of projects; confusing

akonadinext
used reviews, tasks; prefer tasks separate from bugs
used internally in company too; also used sprint module
- problem: in case of tasks coming from company phabricator and KDE
phabricator, the line which reference the commit message will clash
(same Txxxxx), a different prefix is needed
-> (ervin said it's not a problem), as you could use the full URL of the
task instead of just the task ID in the commit message.
- annoyance: few rendering/usability bugs in the kanboard view
with many tasks

tanglu
phabricator developers responsive
thousands of projects handled in tanglu (no repositories yet)
- problem: fast development can be a problem for updates (no real
stable branch)

Positive feedback from Ivan (kactivities)
Positive feedback from Eike (konversation)

BoF
Remove login form which is not LDAP
- Change message and write something like "Authenticate through
identity.kde.org"
Uses of maniphest vs bugzilla
- No migration for now (not the foreseeable future)
Projects hierarchy (<a href="https://secure.phabricator.com/T3670" title="https://secure.phabricator.com/T3670">https://secure.phabricator.com/T3670</a>)
Custom view and notifications for groups
- Dashboards
- Share queries inside a group (check later)
Can we push a patch through the webpage? (keep an eye on upstream)
Do we want to reuse our CI system? <a href="https://wiki.jenkins-ci.org/display/JENKINS/Phabricator+Plugin" title="https://wiki.jenkins-ci.org/display/JENKINS/Phabricator+Plugin">https://wiki.jenkins-ci.org/display/JENKINS/Phabricator+Plugin</a>
When a new review is posted, trigger the CI, it needs some changes to the CI
Lack of integration with CI is not a blocker
Suggestion: It would be nice not need to test every patch (CI), to be
discussed

Support for arcanist is available for other plaftorms (Windows, MacOSx)

Good feedback in general from the people who assisted

Ciao

Comments

Re: Notes from the Phabricator BoF

By Ben Cooksley at 08/05/2015 - 05:24

Hi all,

Just clarifying a few things that have happened post discussion
regarding how we would use Phabricator, in particular Projects.
At this time Phabricator lacks sub-project functionality - which for
certain projects is problematic (whether it will be or not will depend
on your particular use cases and method of using project management
tools).

To workaround this, we'll create Projects with the "<Overall Project
Name>:" prefix for now, as a way of making all projects associated
with an overall group easy to find.
Once upstream has implemented sub-projects fully we'll transition to
using that instead of course.

Note that at this time we don't intend to migrate from Bugzilla -
Maniphest is principally intended as a integrated replacement to
todo.kde.org.

Thanks,
Ben Cooksley
KDE Sysadmin

Re: Notes from the Phabricator BoF

By Ben Cooksley at 08/01/2015 - 07:39

On Fri, Jul 31, 2015 at 1:50 AM, Luigi Toscano <luigi. ... at tiscali dot it> wrote:
Hi Luigi,

Thanks for sending these along, and to Victor for recording them :)
Just a few comments to clarify things and provide extra detail for
those who weren't there.

Yeah, this is something we'd definitely be looking into for a final
implementation should the decision be that we implement Phabricator.

I'm not sure if queries can be shared at this time - but Dashboards
certainly can be, and Dashboards imply shared queries to a certain
extent (and are arguably more powerful as well)

Please see the following upstream issues:

<a href="https://secure.phabricator.com/T182" title="https://secure.phabricator.com/T182">https://secure.phabricator.com/T182</a>
<a href="https://secure.phabricator.com/T5000" title="https://secure.phabricator.com/T5000">https://secure.phabricator.com/T5000</a>
<a href="https://secure.phabricator.com/T8238" title="https://secure.phabricator.com/T8238">https://secure.phabricator.com/T8238</a>
<a href="https://secure.phabricator.com/T8092" title="https://secure.phabricator.com/T8092">https://secure.phabricator.com/T8092</a>

We'll be reusing Jenkins, and integrating it with Phabricator.

For more information on how this will end up working in the long run please see:

<a href="https://secure.phabricator.com/T8090" title="https://secure.phabricator.com/T8090">https://secure.phabricator.com/T8090</a>
<a href="https://secure.phabricator.com/T8089" title="https://secure.phabricator.com/T8089">https://secure.phabricator.com/T8089</a>

In the interim we'll likely end up with a simple link being posted by
Jenkins to build results once this is implemented.

Upstream issue <a href="https://secure.phabricator.com/T4245" title="https://secure.phabricator.com/T4245">https://secure.phabricator.com/T4245</a> is also relevant
to our implementation.

The above is just to give you all an idea of where upstream is heading
and what we can expect to see in the long term from Phabricator.
Aside from the above issue (T4245) I don't see any of these as
blocking our implementation in the short term.

Thanks,
Ben

Re: Notes from the Phabricator BoF

By Martin Klapetek at 07/31/2015 - 05:48

One thing that bothers me a bit is the commits shas having format like
rKONVERSATIONc64d1cd32445f6921109fdbdb17ae44378d404c5

Can something be done about the rPROJECTNAME prefix? I find it
quite confusing and hard to read; if you're looking at commits in
a specific repo, I think it's clear to which project/repo it belongs.

Cheers

Re: Notes from the Phabricator BoF

By Ben Cooksley at 07/31/2015 - 06:07

On Fri, Jul 31, 2015 at 9:48 PM, Martin Klapetek
<martin. ... at gmail dot com> wrote:
Please see <a href="https://secure.phabricator.com/T4245" title="https://secure.phabricator.com/T4245">https://secure.phabricator.com/T4245</a> for more information
on commit urls.
We may be able to fix the display of them, but the urls themselves
will probably always contain something along those lines.

Thanks,
Ben

Re: Notes from the Phabricator BoF

By Kevin Kofler at 07/30/2015 - 16:42

Luigi Toscano wrote:
Were there no complaints about the fact that you can still not view anything
at all without logging in?

Kevin Kofler

Re: Notes from the Phabricator BoF

By Ben Cooksley at 07/31/2015 - 05:41

On Fri, Jul 31, 2015 at 8:42 AM, Kevin Kofler <kevin. ... at chello dot at> wrote:
This has now been corrected. Unfortunately the old default policy for
issues, etc. was set to "All Users" rather than "Public" so we'll have
to migrate the existing tasks and reviews over to that at some point.
New ones should be properly set to public though, unless people
explicitly override (please don't....).

Cheers,
Ben

Re: Notes from the Phabricator BoF

By Matthias Klumpp at 08/01/2015 - 07:48

2015-07-31 11:41 GMT+02:00 Ben Cooksley < ... at kde dot org>:
You can use the conduit API to automatically set stuff to public, or
batch-process the tasks to change their visibility.

You could remove permission to override this setting, or only give it
to a specific group of people ;-)

Cheers,
Matthias

Re: Notes from the Phabricator BoF

By Ben Cooksley at 08/01/2015 - 07:54

On Sat, Aug 1, 2015 at 11:48 PM, Matthias Klumpp < ... at tenstral dot net> wrote:
Already checked the batch change functionality - it lacks the power to
change visibility / permissions on tasks (unless I missed something).
In terms of the Conduit API - I expected that to be the case, just
don't have a script to hand to do it just yet :)

Hmm, where is this permission found? I haven't yet found one that
allows you to restrict the ability to override default permissions,
and it's one i'd rather like to find (I know Spaces does have some
capability in this department though).

Thanks,
Ben

Re: Notes from the Phabricator BoF

By Matthias Klumpp at 08/01/2015 - 08:04

2015-08-01 13:54 GMT+02:00 Ben Cooksley < ... at kde dot org>:
See the attached script for how to do it ;-) You will need to create a
bot user, generate an API token and install the certificate using
Arcanist before using it.
(and you will also need to adjust it to fit the KDE Phabricator needs,
of course)

Maniphest Settings --> Edit Policies --> Set "Can Edit Task Policies"
to team which should be able to do it, our just to Administrators to
forbid others to change the default.

Hope that helps :-)

Cheers,
Matthias

Re: Notes from the Phabricator BoF

By Ben Cooksley at 08/01/2015 - 08:08

On Sun, Aug 2, 2015 at 12:04 AM, Matthias Klumpp < ... at tenstral dot net> wrote:
Ah perfect, thanks for that. I've now implemented that change, so it
shouldn't be possible to make tasks private now.

Thanks,
Ben

Re: Notes from the Phabricator BoF

By Luigi Toscano at 07/30/2015 - 19:53

Il 30 luglio 2015 22:42:44 CEST, Kevin Kofler <kevin. ... at chello dot at> ha scritto:
No. I did not ask sysadmins, but I guess it's just an implementation details in the experimental phase. Other Phabricator instances are widely open; there is a good ACL system.

Ciao