DevHeads.net

Plasma-Mycroft is in kdereview

Hi all,

This is a request email for the review process of the mycroft plasmoid, the plasma-mycroft project has been moved to kdereview

The repository url: <a href="https://cgit.kde.org/plasma-mycroft.git/" title="https://cgit.kde.org/plasma-mycroft.git/">https://cgit.kde.org/plasma-mycroft.git/</a>

Mycroft plasmoid is a desktop frontend that interacts with the Mycroft Core. It is an open source community committed technology that ties natural language processing, text-to-speech, speech-to-text, and powerful APIs together to create a powerful experience allowing users to manipulate their devices through voice control. Mycroft AI is the digital implementation of a modern day open source virtual assistant on the Linux platform that can help a user conduct a multitude of task via voice / text. The plasmoid aims at making the virtual assistant a central hub of information and desktop control assistance on the plasma desktop providing the user a new innovative layer of voice control and desktop interactive technology.

Expected destination initially for the plasmoid would be extragears, for self management of releases, bug fixes.

Looking forward to the review process

Regards,
Aditya Mehra

Comments

Re: Plasma-Mycroft is in kdereview

By Christophe Gibo... at 12/14/2017 - 15:10

Hi,

On mardi 5 décembre 2017 08:52:18 CET Aditya Mehra wrote:
Just commenting on the build system part.
In the top CMakeLists.txt :
- AUTHOR, EMAIL, BUG_ADDRESS are set but not used anywhere, just remove them.
- install( DIRECTORY mycroft DESTINATION /etc ) → use ${SYSCONF_INSTALL_DIR}
instead of /etc
- Instead of using install( DIRECTORY ...), please use ecm_install_icons from
ECM.
- in plugin/CMakeLists.txt, you include pkgconfig but don't use it for
anything

other notes :
- COPYING contains the GPL-2.0 license but nothing needs it
- msm.sh is GPL-3.0+ but there's no license file in the repository
- There's a wikipedia icon in the repo, don't forget the terms (the
attribution part) : <a href="https://creativecommons.org/licenses/by-sa/3.0/" title="https://creativecommons.org/licenses/by-sa/3.0/">https://creativecommons.org/licenses/by-sa/3.0/</a>
- some files in plasmoid/content/ui don't have a license header
- there's a .directory file in plasmoid/contents/images, this should probably
not be in the repo :)

That's all.

Re: Plasma-Mycroft is in kdereview

By Aditya Mehra at 12/18/2017 - 06:26

Hi,

I have fixed the following:
- removed Author, Email, Bug_Address from top CMakeLists.txt
- set destination to use ${SYSCONF_INSTALL_DIR}
- use ecm_install_icons from ecm to install the icons
- in plugin/CMakeLists.txt removed unused pkgconfig
- added a ATTRIBUTION file to top directory to mark usage of images (wikipedia icon)
- added a Copying.apache2 license file as MSM.sh, Mycroft are now Apache 2.0 licensed
- added license headers to all files in plasmoid/content/ui missing the header
- removed .directory file in plasmoid/contents/images

I am not sure about the COPYING file as I think this should be under GPL-2.1 as most other plasmoid/applets also seemed to be released under this license does this file need to be updated to reflect 2.1 specifically ?

Regards,
Aditya Mehra

Hi,

On mardi 5 décembre 2017 08:52:18 CET Aditya Mehra wrote:
Just commenting on the build system part.
In the top CMakeLists.txt :
- AUTHOR, EMAIL, BUG_ADDRESS are set but not used anywhere, just remove them.
- install( DIRECTORY mycroft DESTINATION /etc ) → use ${SYSCONF_INSTALL_DIR}
instead of /etc
- Instead of using install( DIRECTORY ...), please use ecm_install_icons from
ECM.
- in plugin/CMakeLists.txt, you include pkgconfig but don't use it for
anything

other notes :
- COPYING contains the GPL-2.0 license but nothing needs it
- msm.sh is GPL-3.0+ but there's no license file in the repository
- There's a wikipedia icon in the repo, don't forget the terms (the
attribution part) : <a href="https://creativecommons.org/licenses/by-sa/3.0/" title="https://creativecommons.org/licenses/by-sa/3.0/">https://creativecommons.org/licenses/by-sa/3.0/</a>

- some files in plasmoid/content/ui don't have a license header
- there's a .directory file in plasmoid/contents/images, this should probably
not be in the repo :)

That's all.

Re: Plasma-Mycroft is in kdereview

By Aditya Mehra at 01/17/2018 - 00:46

Hi all,

Plasma-Mycroft has been in KDE review over a month, there have been a few additions and bug fixes to the plasmoid but nothing major, all fixes have also been made to the build system which were mentioned by Christophe Giboudeaux, I am hoping plasma-mycroft can complete its review soon as I am looking forward to making a stable release. As there haven't also been any other objections currently can this review process move ahead / moved to extra gears.

Regards,
Aditya Mehra

Hi,

I have fixed the following:
- removed Author, Email, Bug_Address from top CMakeLists.txt
- set destination to use ${SYSCONF_INSTALL_DIR}
- use ecm_install_icons from ecm to install the icons
- in plugin/CMakeLists.txt removed unused pkgconfig
- added a ATTRIBUTION file to top directory to mark usage of images (wikipedia icon)
- added a Copying.apache2 license file as MSM.sh, Mycroft are now Apache 2.0 licensed
- added license headers to all files in plasmoid/content/ui missing the header
- removed .directory file in plasmoid/contents/images

I am not sure about the COPYING file as I think this should be under GPL-2.1 as most other plasmoid/applets also seemed to be released under this license does this file need to be updated to reflect 2.1 specifically ?

Regards,
Aditya Mehra

Hi,

On mardi 5 décembre 2017 08:52:18 CET Aditya Mehra wrote:
Just commenting on the build system part.
In the top CMakeLists.txt :
- AUTHOR, EMAIL, BUG_ADDRESS are set but not used anywhere, just remove them.
- install( DIRECTORY mycroft DESTINATION /etc ) → use ${SYSCONF_INSTALL_DIR}
instead of /etc
- Instead of using install( DIRECTORY ...), please use ecm_install_icons from
ECM.
- in plugin/CMakeLists.txt, you include pkgconfig but don't use it for
anything

other notes :
- COPYING contains the GPL-2.0 license but nothing needs it
- msm.sh is GPL-3.0+ but there's no license file in the repository
- There's a wikipedia icon in the repo, don't forget the terms (the
attribution part) : <a href="https://creativecommons.org/licenses/by-sa/3.0/" title="https://creativecommons.org/licenses/by-sa/3.0/">https://creativecommons.org/licenses/by-sa/3.0/</a>

- some files in plasmoid/content/ui don't have a license header
- there's a .directory file in plasmoid/contents/images, this should probably
not be in the repo :)

That's all.

Re: Plasma-Mycroft is in kdereview

By Marco Martin at 01/17/2018 - 04:26

On mercoledì 17 gennaio 2018 06:46:16 CET Aditya Mehra wrote:
+1

Re: Plasma-Mycroft is in kdereview

By Ben Cooksley at 01/19/2018 - 18:39

On Wed, Jan 17, 2018 at 10:26 PM, Marco Martin < ... at gmail dot com> wrote:
Given people have a had few days to object to this I think we can go
ahead and proceed with moving plasma-mycroft to it's final home.
Please file a Sysadmin ticket documenting where it should be moved,
along with anything else that is required now that it has passed
review such as CI coverage, Bugzilla products, etc.

Regards,
Ben Cooksley
KDE Sysadmin

Re: Plasma-Mycroft is in kdereview

By Marco Martin at 12/14/2017 - 12:25

On martedì 5 dicembre 2017 08:52:18 CET Aditya Mehra wrote:
I have no objections about this moving forward