DevHeads.net

playground/games/picmi moved to KDE Review

Hi all,

I'd like to announce the move of Picmi to KDE Review [1] with the
intended destination being kdegames.

Picmi is a nonogram logic game [2] I've been working on for around two
years. It includes both a random mode (with low completion times as the
goal) and 51 preset puzzles which turn into a pictogram when solved.

Please have a look at both the game itself and the code. Let me know
about any issues and I will do my best to resolve them. Picmi can be
built with 'git clone git://anongit.kde.org/picmi && cd picmi && make &&
build/src/picmi'.
Building with KDE trunk will require the patch from
<a href="http://lists.kde.org/?l=kde-games-devel&amp;m=134201653803914&amp;w=2" title="http://lists.kde.org/?l=kde-games-devel&amp;m=134201653803914&amp;w=2">http://lists.kde.org/?l=kde-games-devel&amp;m=134201653803914&amp;w=2</a>.

I've already sent my intentions about moving Picmi to kdegames to the
kde-games-devel list [3] and the module coordinator Matt Williams.

Going through the requirements of the application lifecycle:

* You should have checked for basic problems with a profiler.
* There should be user documentation in docbook format.
* Your application should be completely translatable.

Check.

* There should be no krazy code checker issues reported.

There were a couple of reported issues (I can't check at the moment
because the old playground is gone and kdereview is not up yet). The
check should pop up at [4] in a bit.

A couple of them were related to the HAVE_KGDIFFICULTY macro which
provides compatibility between the old KGameDifficulty and KgDifficulty.
These can be removed when Picmi is based on trunk.

Many of the others also seemed like false positives (i.e. complaining
about "c" "string concatenation"). Please have a look at let me know if
any of them need to be fixed.

* If possible, there should have been a basic usability review of your
application.

There has been no review so far.

Thanks for your time!
Greetings,
Jakob

[1] <a href="https://projects.kde.org/projects/kdereview/picmi" title="https://projects.kde.org/projects/kdereview/picmi">https://projects.kde.org/projects/kdereview/picmi</a>
[2] <a href="http://en.wikipedia.org/wiki/Nonogram" title="http://en.wikipedia.org/wiki/Nonogram">http://en.wikipedia.org/wiki/Nonogram</a>
[3] <a href="http://lists.kde.org/?l=kde-games-devel&amp;m=134199856928901&amp;w=2" title="http://lists.kde.org/?l=kde-games-devel&amp;m=134199856928901&amp;w=2">http://lists.kde.org/?l=kde-games-devel&amp;m=134199856928901&amp;w=2</a>
[4]
<a href="http://www.englishbreakfastnetwork.org/krazy/index.php?component=kdereview" title="http://www.englishbreakfastnetwork.org/krazy/index.php?component=kdereview">http://www.englishbreakfastnetwork.org/krazy/index.php?component=kdereview</a>

Comments

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 08/03/2012 - 18:15

On 07/20/2012 11:53 AM, Jakob Gruber wrote:
Picmi has been in KDE Review for 2 weeks, and according to the
application lifecycle the initial review period is now over.

I have not yet settled on an icon replacement, partly because my first
choice turned out to be for private desktop use only; and also because
it has been mentioned on IRC that I should ask the oxygen team about this(?)

All other issues raised in this thread have been solved.

Are there any objections or requested changes before Picmi can proceed
to kdegames?
Could somebody please point out the next steps to take?

CC'ing kde-games-devel and the kdegames release coordinator Matt Williams.

Greetings,
Jakob

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 08/04/2012 - 03:49

As for information about the procedure, you can find all the necessary
information here:
<a href="http://techbase.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable" title="http://techbase.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable">http://techbase.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable</a>

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 08/04/2012 - 03:24

Yes, you have ignored my comments for more than a week with a
cross-platform issue, and not just on Windows.

Here is what I wrote earlier:

1) The current double check is in wrong order unless you have fixed
this after my mentioning. I think the fallback should be the old, and
the first citizen should be changed "cmake API".

2) I would suggest meaningful warning messages, if the old version is
found for some reasons. That might be unintentional from the person
trying to build.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 08/04/2012 - 03:52

On 08/04/2012 09:24 AM, Laszlo Papp wrote:
Support for the old libkdegames will be removed soon, making both of the
points below nonissues. I already stated as much in both my original
mail and on 07/25.

Cheers,
Jakob

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 08/04/2012 - 03:58

It *should* work logically and correctly until a new refactor, thus I
cannot buy this argument, I am afraid. This is a few-liner change to
make this operation right...

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 08/04/2012 - 04:02

Just to clarify, this statement means that you either support the old
kde games library properly, or you do not support at all.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 08/04/2012 - 04:08

On 08/04/2012 10:02 AM, Laszlo Papp wrote:
Yes, obviously. All support for the pre-4.9 libkdegames has now been
removed on master.

Re: playground/games/picmi moved to KDE Review

By Albert Astals Cid at 07/22/2012 - 13:10

El Divendres, 20 de juliol de 2012, a les 11:53:28, Jakob Gruber va escriure:
My comments:
* You think you could give it a somehow bigger initial size? It starts very
small the first time
* Do you have a bigger res icon? Otherwise looks quite bad in my alt+tab
switcher
* Can you disable the "..." in the settings dialog and only enable it when
set to custom backgroud image?
* Maybe it makes sense that undo and load position are disabled if there is
nothing to undo or no position to load?
* Changing the solved streak color does nothing until i restart the game

Cheers,
Albert

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/23/2012 - 06:29

On 07/22/2012 07:10 PM, Albert Astals Cid wrote:
With the latest push to master, all of these points should be addressed
(except the icon, I'm still looking).

Jakob

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/24/2012 - 15:45

Does the game work on Windows?

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/24/2012 - 17:35

I have just put some effort into testing this, but it is quite broken.
I would like to see improvements in this front since Windows is an
important platform for Qt and KDE. I am here for helping with that, if
needed.

The issues so far (until I found enough to not bother with finding
more as of now) in kdegames (dependency):

1) FindSndFile.cmake is broken. It does not find the installed sndfile
on my system which it should. I would suggest using the one we used in
alure, gluon, QtOpenAL back then and so forth.

2) <a href="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/CMakeLists.txt?view=markup" title="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/CMakeLists.txt?view=markup">http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/CMakeLists.txt?view...</a>
-> file(RELATIVE_PATH CONF_REL_INCLUDE_DIR
"${DATA_INSTALL_DIR}/cmake/modules"
"${INCLUDE_INSTALL_DIR}")

This is not going to work since you need to use absolute paths, if I
am not mistaken. ${CMAKE_INSTALL_PREFIX} will help you out about that.

3) <a href="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp?view=markup:" title="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp?view=markup:">http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound-opena...</a>
#include <sndfile.hh> //TODO: use Phonon instead of libsndfile for
decoding -> You should use "sndfile.h"

4) You use "class Private" here:
<a href="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound.h?view=markup" title="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound.h?view=markup">http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound.h?vie...</a>
and then "struct Foobar::Private" here:
<a href="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp?view=markup" title="http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound-openal.cpp?view=markup">http://websvn.kde.org/trunk/KDE/kdegames/libkdegames/audio/kgsound-opena...</a>

... after this point I gave up for now. Please fix the issues in
kdegames along with the responsible person(s), and I will make check
further checks. The game, and libkdegames has not clearly been tested
properly with openal and sndfile. That may also be due to the fact,
the FindSndFile.cmake is broken.

Unfortunately, phonon master also had issues, so we just recommend
using the last phonon stable release in certain cases.

Let me know, if you need help with all these. I can also commit the
fixes myself, if it is accepted by whoever the maintainer is.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/24/2012 - 17:54

On 07/24/2012 11:35 PM, Laszlo Papp wrote:
Thanks for testing, I appreciate the time spent.

I'd like to clarify that all of the points mentioned in this mail
concern libkdegames (and compilation thereof on Windows) and not picmi
in particular, therefore I'm forwarding this to kde-games-devel.

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 01:10

Just to clarify this: the kdegames stack is broken on Windows, and I
have not continued the investigation about picmi until that is fixed.
I would not like to see something integrated where the whole stack is
broken on Windows from the ground up (sorry for sounding blunt but
Windows should not really be considered as something unimportnat for
KDE in my opinion). It is not just a runtime issue, but does not even
compile ...

I have pushed the fixes to trunk as I mentioned on the kde-games-devel
mailing list. Feel free to back port the build fixes to 4.9 for
instance. I do not have time for going through the policies for that
to do myself.

About picmi:

1) The makefile is a non-crossplatform specific file in the project
root. I do not see much value in that file to be honest since it is
practically a file to avoid a simple alias? I would like to get that
either removed (my preference) or make cross-platform. NMake or
preferrably Jom is used on Windows, but you would need to sort out the
Mac compiler there and the like. I do not think it is worth it in
comparison with the additional maintainance.

2) find_package(LibKDEGames REQUIRED) -> Broken on Windows. I have
made a local alering to KDEGames, but I am unsure if that is the real
fix. My arch box seems to install LibKDEGames.cmake, so probably not.
Please unbreak this.

3) Do not use gcc specific compilation options, like /extra please. I
do not see the real need for that, but if you desperately need that,
use conditions...

4) C:\Projects\picmi\src/settings.h(30) : fatal error C1083: Cannot
open include file: 'kgamedifficulty.h': No such file or directory ->
Something is wrong around the private libkdegames topic.

This is the point where I have given up the further investigation for
now. I will continue the help once you fix these essential build
issues. :-)

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/25/2012 - 06:57

I spent this morning setting up KDE Windows (thanks SaroEngels for all
the help). The good news is that picmi
compiles and runs without any changes to the source code (mingw and KDE
4.8).

I have not set up a build with MSVC or KDE trunk, so I can't say
anything about these yet.

On to specific issues below...

On 07/25/2012 07:10 AM, Laszlo Papp wrote:
This is basically a convenience makefile and is not part of the actual
cmake build system (= it can be ignored). Following SaroEngels'
suggestion, it has been renamed to GNUmakefile - this way it should only
be executed by GNU make.

I mentioned this in my initial mail. find_package(LibKDEGames) does not
work for trunk (find_package(KDEGames) does).

Does everyone here use trunk? If yes, I will change this in the
repository - let me know.

Thanks, these are now conditionally added (if (CMAKE_COMPILER_IS_GNUCXX)).

kgamedifficulty.h is only included if HAVE_KGDIFFICULTY is not set. In
turn, if you are running a recent version of libkdegames,
HAVE_KGDIFFICULTY should be set by

check_include_file_cxx(kgdifficulty.h HAVE_KGDIFFICULTY)

(<a href="https://github.com/schuay/picmi/blob/master/src/CMakeLists.txt#L19" title="https://github.com/schuay/picmi/blob/master/src/CMakeLists.txt#L19">https://github.com/schuay/picmi/blob/master/src/CMakeLists.txt#L19</a>)

So it seems like cmake is unable to find kgdifficulty.h in your
installation? As discussed in #kde-windows, I will be around later
tonight to follow up on this.

However, I don't see 2) and 4) as much of an issue - if picmi is
accepted into the kdegames module, all support for the old libkdegames
classes will be removed anyway.

As always,
thanks for your time and effort,
Jakob

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 16:59

Some of the content may be familiar from irc, but just for the record.

Yes. It is a bit inconsistent with the rest, but I do not mind, if you
need this to aid your work. You are the maintainer after all, so it
must be convenient for you. :)

1) The current double check is in wrong order unless you have fixed
this after my mentioning. I think the fallback should be the old, and
the first citizen should be changed "cmake API".

2) I would suggest meaningful warning messages, if the old version is
found for some reasons. That might be unintentional from the person
trying to build.

It is fine as well as the fix for the first point. Even if the
majority in KDE does not use this too much, you are the maintainer,
you decide about such details. :-)

Unsure, why this issue disappeared right now when I have tried to run,
but I cannot reproduce this issue anymore after the fresh git clone
and pull operations for kdegames and picmi.

I have just tried to run the binary from the command line, but a crash
happened for some reasons. Perhaps, the resource is not found.

KERNELBASE.dll!RaiseException() [[unknown] @ -1] at 0x75f7b727
MSVCR100.dll!CxxThrowException() [[unknown] @ -1] at 0x64617819
picmi.exe!Renderer::loadResources()
[c:\projects\picmi\src\gui\renderer.cpp @ 73] at 0xec028f
picmi.exe!GetCommandLineW() [[unknown] @ -1] at 0xed233d
picmi.exe!Renderer::Renderer() [c:\projects\picmi\src\gui\renderer.cpp
@ 46] at 0xec0566
picmi.exe!Renderer::instance() [c:\projects\picmi\src\gui\renderer.cpp
@ 161] at 0xec0865
picmi.exe!Scene::init() [c:\projects\picmi\src\gui\scene.cpp @ 130] at 0xebb7fe
picmi.exe!Scene::Scene() [c:\projects\picmi\src\gui\scene.cpp @ 27] at 0xebbbd6
picmi.exe!View::createScene() [c:\projects\picmi\src\gui\view.cpp @
47] at 0xeb6bca
picmi.exe!MainWindow::startGame()
[c:\projects\picmi\src\gui\mainwindow.cpp @ 228] at 0xeb564d
picmi.exe!MainWindow::startRandomGame()
[c:\projects\picmi\src\gui\mainwindow.cpp @ 199] at 0xeb59f8
picmi.exe!MainWindow::MainWindow()
[c:\projects\picmi\src\gui\mainwindow.cpp @ 58] at 0xeb64da
picmi.exe!main() [c:\projects\picmi\src\main.cpp @ 43] at 0xeb1a65
picmi.exe!WinMain()
[c:\kderoot\git\qt-4.8.2\src\winmain\qtmain_win.cpp @ 135] at 0xeb1125
picmi.exe!__tmainCRTStartup()
[f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c @ 547] at 0xecfc90
kernel32.dll!BaseThreadInitThunk() [[unknown] @ -1] at 0x75fd3677
ntdll.dll!RtlInitializeExceptionChain() [[unknown] @ -1] at 0x77649d72
ntdll.dll!RtlInitializeExceptionChain() [[unknown] @ -1] at 0x77649d45

Thank you for your collaboration, again!

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 17:44

OK, this can be fixed by a proper cmake run, like "cmake
-DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_
PREFIX=%KDEROOT% -DCMAKE_PREFIX_PATH=%KDEROOT% ../".

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/25/2012 - 17:54

On 07/25/2012 11:44 PM, Laszlo Papp wrote:
Yes, to find the resource file, picmi either needs to be installed or
your working dir must be the project root.

Thanks for testing!

Re: playground/games/picmi moved to KDE Review

By Andrius da Cost... at 07/25/2012 - 23:30

Hello,

In src/systemexception.h:
return m_msg.toStdString().c_str();
^ my Qt copy was built with no support to toStdString, please consider
changing it to:
return m_msg.toLatin1();

Re: playground/games/picmi moved to KDE Review

By Patrick Spendrin at 07/26/2012 - 03:33

Am 26.07.2012 05:30, schrieb Andrius da Costa Ribas:
Nope, your Qt copy was build with stl support, there was a wrong
add_definitions() in there. I should have pushed the fix now.

regards,
Patrick

Re: playground/games/picmi moved to KDE Review

By Andrius da Cost... at 07/25/2012 - 23:43

add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with RC.exe
when I try to add a kde4_add_app_icon.
fatal error RC1106: invalid option: -EHsc

any hint with that?

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/26/2012 - 04:01

On 07/26/2012 05:43 AM, Andrius da Costa Ribas wrote:
Googling turns up <a href="http://www.cmake.org/pipermail/cmake/2008-June/022381.html" title="www.cmake.org/pipermail/cmake/2008-June/022381.html">www.cmake.org/pipermail/cmake/2008-June/022381.html</a>
Which leads back to commit 823196 in ksirk, and finally 47f7099d3 in my
working branch (I will push it in a couple of minutes).

Of course, done. Patrick has also fixed usage of QT_NO_STL :)

Greetings,
Jakob

Re: playground/games/picmi moved to KDE Review

By Patrick Spendrin at 07/26/2012 - 03:35

Am 26.07.2012 05:43, schrieb Andrius da Costa Ribas:
probably this has to be set in a different way then, something like
set_property(... COMPILE_FLAGS ...) or something like that.
I'll try to think about a nice solution for that.

regards,
Patrick

Re: playground/games/picmi moved to KDE Review

By Patrick Spendrin at 07/25/2012 - 07:43

Am 25.07.2012 12:57, schrieb Jakob Gruber:
Well, it should be easy to fall back to find_package(KDEGames) if
find_package(LibKDEGames) fails (and fail completely if none is found).
This way you can also integrate the check for kgdifficulty.h.

Except my personal broken setup, picmi seems to build & work nicely now.
So Ship It! ;-)
regards,
Patrick

Re: playground/games/picmi moved to KDE Review

By Andras Mantia at 07/25/2012 - 03:08

On Wednesday, July 25, 2012 06:10:21 AM Laszlo Papp wrote:
There was never a requirement for software that wants to be part of KDE to
work on Windows, and I'd like to keep this as it is.

Andras

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 03:57

Perhaps, but I can still raise my personal opinion, just as you can.
Although, it is a bit more here than "does not work". It does even
compile. :-)

I do think a minimal effort could be taken, especially when people are
keen on helping with testing and even fixing like in this case.
Perhaps, if some people do not have Windows access (due to the fact,
it costs money, etc), they could have an option for remote usage, and
run at least a build check. Other option is a build server perhaps
with Jenkins?

It just makes the KDE Windows' team life hard to get all the
application running. Unfortunately, there is a decent manpower lack
over there, and if each developer can help a little bit, even just
about their applications, the situation looks much better.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Andras Mantia at 07/25/2012 - 04:13

On Wednesday, July 25, 2012 08:57:13 AM Laszlo Papp wrote:
Sure. :)

The usual reason is that the developer doesn't even have a MS compiler or
Windows. And nobody can be forced to have one. ;)

It is not a problem you bring up the issues, but that shouldn't block the app
being moved from kdereview to another module (if it is accepted by the module
maintainer, there are not other problems with it).

Yes, that would help, but somebody has to do the work, do the setup, buy the
MS tools, etc. Sincerely, I don't see th

I keep telling to Patrick to just use Linux, but he is hard headed, so he has
to leave with the pain and fix our mess. ;)

Andras

Re: playground/games/picmi moved to KDE Review

By Patrick Spendrin at 07/25/2012 - 04:50

Am 25.07.2012 10:13, schrieb Andras Mantia:
Yes, I think this is the right direction.
If people on Windows do review the apps as well I think we can try to
fix them first (even with support from the maintainer) but I don't think
we are that far yet to block the move.

:-D
If I ever stop working on KDE on Windows I will switch.

regards,
Patrick

Re: playground/games/picmi moved to KDE Review

By Rolf Eike Beer at 07/25/2012 - 05:28

Am 25.07.2012 10:50, schrieb Patrick Spendrin:
Looks like we will always win ;)

Eike

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 04:49

You could theoritically say the same for Linux (or certain softwares,
versions etc). I have just read my mail again, and I have written "I
would not like to ..." and "I am here for helping with the issues".
Sure, it can be integrated, but if it is integrated now without the
fixes, it is likely there will not be much attention later, and now I
am here for help. Unsure about later. :)

Sure. I am suggesting as of now. :) Jakob can take my suggestions to
make this up and running on Windows with not so much effort.

I believe, the last part of the sentence is missing, but there are
already windows servers. Unsure what you mean by ms tools, but in an
ideal world, even mingw should work. In fact, even when you
cross-compile from Linux. :-)

A build server, like Jenkins, with Windows target could be a lot of
help. I am sure some of us could also provide remote access for build
checks. I do not see this a big problem, but yes the flow needs to
proceed.

However, as for this special case, I am here for helping and patching,
if I can create one with my skills.

I said small team, but it is not that small. There are others you need
to "brainwash". ;)

I can just speak up about the Download numbers Patrick and Patrick
mentioned during the aKademy talk, and it is not an insignificant
number. Meaning, many people use KDE on Windows, already.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Andras Mantia at 07/25/2012 - 05:05

On Wednesday, July 25, 2012 09:49:46 AM Laszlo Papp wrote:
Sure, but you have to admit, that there is a subtle difference between Linux
different versions and Linux vs. Windows.

The best you can do here is that if you have access to Windows and a compiler
and can build KDE there, just do it, and fix the issues yourself and
commit/push.
The problem is that if the developer doesn't have access to the tools, all
fixes will be done blindly. Doable, but not that easy and more error-prone.

...that happening soon.

Mingw doesn't catch compiler msvc errors, the two compilers are different
enough that having access to one doesn't guarntee the second will work.

Re. tools I was thinking about the server itself (MS license), compiler tools
(if you want anything more then the free compiler) and the rest. Don't ask me,
I'm not a Windows person who knows what exactly needs to be bought for such a
setup.

Andras

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 05:17

I am just saying that, it can happen someone is unable to have an
access to Linux for some reasons. This is for instance the situation
at my company without finding workarounds. :-)

Like I said, I can help with this special case, so it is not going to
be blind. :-)

Sure. I would personally be happy, if a person investigate about one
of them, already, according to the person's liking or not liking, but
I can understand the unwillingness as well at times.

I believe, most of us using msvc, use the free express edition. I have
not needed more so far while working on Qt or/and KDE Windows.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Laszlo Papp at 07/25/2012 - 04:02

Err... silly typo: it does /not/ even compile.

Best Regards,
Laszlo Papp

Re: playground/games/picmi moved to KDE Review

By Ben Cooksley at 07/25/2012 - 02:18

On Wed, Jul 25, 2012 at 5:10 PM, Laszlo Papp < ... at kde dot org> wrote:
As stated in the kde-cvs-announce email, All 4.9 branches are
currently hard frozen to permit tagging and final release of KDE
4.9.0.
Do not make any backports until after KDE 4.9.0 is released, or unless
you get the permission of the release-team to do so.

Regards,
Ben Cooksley
KDE Sysadmin

Re: playground/games/picmi moved to KDE Review

By Albert Astals Cid at 07/25/2012 - 03:05

--- El mié, 25/7/12, Ben Cooksley escribió:
Sorry to contradict you Ben, but we are still not frozen, the freeze starts in around 17 hours (Wednesday 25 at 23:59 UTC).

Cheers,
Albert

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/22/2012 - 18:22

On 07/22/2012 07:10 PM, Albert Astals Cid wrote:
A default size of 700x560 is now set (I had it at at first 800x650 but
tsdgeos reminded me about netbooks).

I'm afraid not. I should be able to dig up something suitable in the
next couple of days, but this is an area where I would be very grateful
for any help.

Done.

Will do, I'll hopefully get to it tomorrow.

Done. The background settings also apply immediately, and I fixed a copy
and paste bug which prevented changing unsolved font colors.

I've pushed the changes above to my working branch at
git://github.com/schuay/picmi.git (kdereview will follow tomorrow morning).

Regards,
Jakob

Re: playground/games/picmi moved to KDE Review

By Raphael Kubo da... at 07/20/2012 - 18:02

Jakob Gruber <jakob. ... at gmail dot com> writes:

BTW, the "config.h" part of the patch should go in regardless of the
rest, as config.h should be the first header included by the source
files anyway.

I've committed a few CMake fixes, and the remaining remark I have is
about the -std=c++11 flag you pass to the compiler due to your usage of
std::shared_ptr (I didn't see if there are other C++11 features you are
making use of). Have you considered using Qt's pointer types instead? If
you decide to stick to shared_ptr, please make sure you describe which
compilers and versions are supposed to work correctly -- for example,
the base compiler on FreeBSD (and I think on OS X too) is gcc 4.2.1,
whose libstdc++ does not have std::shared_ptr.

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/21/2012 - 04:48

On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote:
Done. I don't understand why krazy tells me to put config.h in angle
brackets though - I've left it in quotes for now.

Thanks!

I've replaced all std::shared_pointers with QSharedPointers this morning
and removed the -std=c++11 flag.

One other question: three of the included levels are small pictograms of
Disney characters up to 31x32 px in size. I'm not sure if that could be
a legal issue?

Greetings,
Jakob

Re: playground/games/picmi moved to KDE Review

By Raphael Kubo da... at 07/21/2012 - 15:38

Jakob Gruber <jakob. ... at gmail dot com> writes:

I'm now getting a few errors and warnings when trying to build picmi
with g++ 4.2.1, 4.6.3 and clang 3.1: some of them are related to
-pedantic being used + Qt and kdelibs using long long in a few headers,
and some due to QSharedPointer being used with forward-declared
classes. I've attached clang's output since it's more informative than
gcc's.

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/22/2012 - 07:54

On 07/21/2012 09:38 PM, Raphael Kubo da Costa wrote:
:|
For some reason, there were no errors/warnings when building on
Archlinux with gcc 4.7.1 and clang 3.1. I could reproduce them on an
Ubuntu VM though.

I've added -Wno-long-long to the build flags to silence these.

I spent some time researching this warning. Apparently it's
fixed in Qt 5, but forward declarations (as they are in Picmi) will not
work with QSharedPointers in Qt 4. I've decided to remove these forward
declarations for now.

The "'reverse' is not a member of 'std'" error has been fixed as well.

Building now completes without any errors or warnings on both the VM and
my main machine with clang and gcc. Compiling with kdegames trunk works
(once find_package(LibKDEGames) has been replaced with
find_package(KDEGames)). Please let me know if you still run into any
further
issues!

Cheers,
Jakob

Re: playground/games/picmi moved to KDE Review

By Adriaan de Groot at 07/21/2012 - 05:16

On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote:
I'd suggest being on the safe side and dropping those: the characters
(likenesses) are trademarks and their images copyrightable; depending on how
you get the small pix the copyright might not apply, but trademark still
would.

[ade]

Re: playground/games/picmi moved to KDE Review

By Jakob Gruber at 07/21/2012 - 12:38

On 07/21/2012 11:16 AM, Adriaan de Groot wrote:
Makes sense, I've removed them.

Re: playground/games/picmi moved to KDE Review

By Rolf Eike Beer at 07/21/2012 - 04:52

Am Samstag 21 Juli 2012, 10:48:47 schrieb Jakob Gruber:
Because quotes means "take it from the current directory first". The config.h
you write is in the binary directory, so it should be included with <> which
does not search the current directory first. At least not if you are not using
MSVC :/

Eike