DevHeads.net

Review Request 108732: khtml/canvas: Ignore invalid values for setting the lineWidth instead of throwing an exception.

Review request for kdelibs.

Description
khtml/canvas: Ignore invalid values for setting the lineWidth instead of throwing an exception.

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.lineWidth.invalid" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.lineWidth.invalid">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.l...</a>
and the test
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.line.width.invalid.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.line.width.invalid.html">http://philip.html5.org/tests/canvas/suite/tests/2d.line.width.invalid.html</a>

Also introduce and use new functions for this check.

Diffs
khtml/ecma/kjs_context2d.cpp de9870d

Diff: <a href="http://git.reviewboard.kde.org/r/108732/diff/" title="http://git.reviewboard.kde.org/r/108732/diff/">http://git.reviewboard.kde.org/r/108732/diff/</a>

Testing

Thanks,

Bernd Buschinski

Comments

Re: Review Request 108732: khtml/canvas: Ignore invalid values f

By Commit Hook at 03/30/2013 - 11:14

(Updated March 30, 2013, 3:14 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Description
khtml/canvas: Ignore invalid values for setting the lineWidth instead of throwing an exception.

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.lineWidth.invalid" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.lineWidth.invalid">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.l...</a>
and the test
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.line.width.invalid.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.line.width.invalid.html">http://philip.html5.org/tests/canvas/suite/tests/2d.line.width.invalid.html</a>

Also introduce and use new functions for this check.

Diffs
khtml/ecma/kjs_context2d.cpp de9870d

Diff: <a href="http://git.reviewboard.kde.org/r/108732/diff/" title="http://git.reviewboard.kde.org/r/108732/diff/">http://git.reviewboard.kde.org/r/108732/diff/</a>

Testing

Thanks,

Bernd Buschinski

Re: Review Request 108732: khtml/canvas: Ignore invalid values f

By Commit Hook at 03/30/2013 - 11:12

This review has been submitted with commit 1ec2488fdee909a14c7487090ff6159dec367402 by Bernd Buschinski to branch master.

- Commit Hook

On Feb. 3, 2013, 4:41 p.m., Bernd Buschinski wrote: