DevHeads.net

Review Request 108743: khtml/canvas: Ignore invalid values for QuadraticCurveTo instead of throwing an exception

Review request for kdelibs.

Description
khtml/canvas: Ignore invalid values for QuadraticCurveTo instead of throwing an exception

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.nonfinite" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.nonfinite">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.n...</a>
and test:
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.path.quadraticCurveTo.nonfinite.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.path.quadraticCurveTo.nonfinite.html">http://philip.html5.org/tests/canvas/suite/tests/2d.path.quadraticCurveT...</a>

Diffs
khtml/ecma/kjs_context2d.cpp de9870d

Diff: <a href="http://git.reviewboard.kde.org/r/108743/diff/" title="http://git.reviewboard.kde.org/r/108743/diff/">http://git.reviewboard.kde.org/r/108743/diff/</a>

Testing

Thanks,

Bernd Buschinski

Comments

Re: Review Request 108743: khtml/canvas: Ignore invalid values f

By Commit Hook at 03/30/2013 - 11:15

(Updated March 30, 2013, 3:15 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Description
khtml/canvas: Ignore invalid values for QuadraticCurveTo instead of throwing an exception

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.nonfinite" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.nonfinite">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.n...</a>
and test:
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.path.quadraticCurveTo.nonfinite.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.path.quadraticCurveTo.nonfinite.html">http://philip.html5.org/tests/canvas/suite/tests/2d.path.quadraticCurveT...</a>

Diffs
khtml/ecma/kjs_context2d.cpp de9870d

Diff: <a href="http://git.reviewboard.kde.org/r/108743/diff/" title="http://git.reviewboard.kde.org/r/108743/diff/">http://git.reviewboard.kde.org/r/108743/diff/</a>

Testing

Thanks,

Bernd Buschinski

Re: Review Request 108743: khtml/canvas: Ignore invalid values f

By Commit Hook at 03/30/2013 - 11:13

This review has been submitted with commit c3e4428128b75d4c6e539d5cbdd8787a141d2fbf by Bernd Buschinski to branch master.

- Commit Hook

On Feb. 3, 2013, 4:42 p.m., Bernd Buschinski wrote: