DevHeads.net

Review Request 108748: khtml/canvas: Return false if one argument is Inf or NaN for IsPointInPath, instead of throwing an exception

Review request for kdelibs.

Description
khtml/canvas: Return false if one argument is Inf or NaN for IsPointInPath, instead of throwing an exception

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.isPointInPath.nonfinite" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.isPointInPath.nonfinite">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.p...</a>
and test:
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.nonfinite.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.nonfinite.html">http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.n...</a>

Diffs
khtml/ecma/kjs_context2d.cpp de9870d

Diff: <a href="http://git.reviewboard.kde.org/r/108748/diff/" title="http://git.reviewboard.kde.org/r/108748/diff/">http://git.reviewboard.kde.org/r/108748/diff/</a>

Testing

Thanks,

Bernd Buschinski

Comments

Re: Review Request 108748: khtml/canvas: Return false if one arg

By Commit Hook at 03/30/2013 - 11:13

This review has been submitted with commit 72f77885fe35e30414694610a131fa84191e899e by Bernd Buschinski to branch master.

- Commit Hook

On Feb. 3, 2013, 4:43 p.m., Bernd Buschinski wrote:

Re: Review Request 108748: khtml/canvas: Return false if one arg

By Commit Hook at 03/30/2013 - 11:15

(Updated March 30, 2013, 3:15 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Description
khtml/canvas: Return false if one argument is Inf or NaN for IsPointInPath, instead of throwing an exception

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.isPointInPath.nonfinite" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.isPointInPath.nonfinite">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.p...</a>
and test:
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.nonfinite.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.nonfinite.html">http://philip.html5.org/tests/canvas/suite/tests/2d.path.isPointInPath.n...</a>

Diffs
khtml/ecma/kjs_context2d.cpp de9870d

Diff: <a href="http://git.reviewboard.kde.org/r/108748/diff/" title="http://git.reviewboard.kde.org/r/108748/diff/">http://git.reviewboard.kde.org/r/108748/diff/</a>

Testing

Thanks,

Bernd Buschinski