DevHeads.net

Review Request 108753: khtml/canvas: Do not throw an exception for Rect if width/height are negative

Review request for kdelibs.

Description
khtml/canvas: Do not throw an exception for Rect if width/height are negative, they are allowed and work.

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.rect.subpath" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.rect.subpath">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.p...</a>
and test:
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html">http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html</a>

Diffs
khtml/html/html_canvasimpl.cpp 93d5db7

Diff: <a href="http://git.reviewboard.kde.org/r/108753/diff/" title="http://git.reviewboard.kde.org/r/108753/diff/">http://git.reviewboard.kde.org/r/108753/diff/</a>

Testing

Thanks,

Bernd Buschinski

Comments

Re: Review Request 108753: khtml/canvas: Do not throw an excepti

By Commit Hook at 03/30/2013 - 10:15

(Updated March 30, 2013, 3:15 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Description
khtml/canvas: Do not throw an exception for Rect if width/height are negative, they are allowed and work.

According to:
<a href="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.rect.subpath" title="http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.rect.subpath">http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.p...</a>
and test:
<a href="http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html" title="http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html">http://philip.html5.org/tests/canvas/suite/tests/2d.path.rect.negative.html</a>

Diffs
khtml/html/html_canvasimpl.cpp 93d5db7

Diff: <a href="http://git.reviewboard.kde.org/r/108753/diff/" title="http://git.reviewboard.kde.org/r/108753/diff/">http://git.reviewboard.kde.org/r/108753/diff/</a>

Testing

Thanks,

Bernd Buschinski

Re: Review Request 108753: khtml/canvas: Do not throw an excepti

By Commit Hook at 03/30/2013 - 10:14

This review has been submitted with commit ccde0d07389cd435119172d6d8973bc45adb4877 by Bernd Buschinski to branch master.

- Commit Hook

On Feb. 3, 2013, 4:43 p.m., Bernd Buschinski wrote: