DevHeads.net

Review Request 109967: Export KLocale flags to QML locale bindings correctly

Review request for KDE Runtime.

Description
KLocale::TimeFormatOptions, KLocale::TimeProcessingOptions , KLocale::DateTimeComponents, KLocale::DateTimeFormatOptions are now exported to QML correctly.
Just added Q_FLAGS after Q_DECLARE_FLAGS

Refer to this email : <a href="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html" title="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html">http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html</a>

Diffs
plasma/declarativeimports/locale/locale_p.h 5b4668f

Diff: <a href="http://git.reviewboard.kde.org/r/109967/diff/" title="http://git.reviewboard.kde.org/r/109967/diff/">http://git.reviewboard.kde.org/r/109967/diff/</a>

Testing
Tested a plasmoid that used these flags.

Thanks,

Anant Kamath

Comments

Re: Review Request 109967: Export KLocale flags to QML locale bi

By Anant Kamath at 04/11/2013 - 16:25

(Updated April 11, 2013, 8:25 p.m.)

Review request for KDE Runtime.

Description
KLocale::TimeFormatOptions, KLocale::TimeProcessingOptions , KLocale::DateTimeComponents, KLocale::DateTimeFormatOptions are now exported to QML correctly.
Just added Q_FLAGS after Q_DECLARE_FLAGS

Refer to this email : <a href="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html" title="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html">http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html</a>

Diffs
plasma/declarativeimports/locale/locale_p.h 5b4668f

Diff: <a href="http://git.reviewboard.kde.org/r/109967/diff/" title="http://git.reviewboard.kde.org/r/109967/diff/">http://git.reviewboard.kde.org/r/109967/diff/</a>

Testing
Tested a plasmoid that used these flags.

Thanks,

Anant Kamath

Re: Review Request 109967: Export KLocale flags to QML locale bi

By Anant Kamath at 04/11/2013 - 16:30

(Updated April 11, 2013, 8:30 p.m.)

Review request for KDE Runtime and Plasma.

Description
KLocale::TimeFormatOptions, KLocale::TimeProcessingOptions , KLocale::DateTimeComponents, KLocale::DateTimeFormatOptions are now exported to QML correctly.
Just added Q_FLAGS after Q_DECLARE_FLAGS

Refer to this email : <a href="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html" title="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html">http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html</a>

Diffs
plasma/declarativeimports/locale/locale_p.h 5b4668f

Diff: <a href="http://git.reviewboard.kde.org/r/109967/diff/" title="http://git.reviewboard.kde.org/r/109967/diff/">http://git.reviewboard.kde.org/r/109967/diff/</a>

Testing
Tested a plasmoid that used these flags.

Thanks,

Anant Kamath

Re: Review Request 109967: Export KLocale flags to QML locale bi

By Anant Kamath at 04/11/2013 - 18:48

(Updated April 11, 2013, 10:48 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Runtime and Plasma.

Description
KLocale::TimeFormatOptions, KLocale::TimeProcessingOptions , KLocale::DateTimeComponents, KLocale::DateTimeFormatOptions are now exported to QML correctly.
Just added Q_FLAGS after Q_DECLARE_FLAGS

Refer to this email : <a href="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html" title="http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html">http://mail.kde.org/pipermail/plasma-devel/2013-April/024753.html</a>

Diffs
plasma/declarativeimports/locale/locale_p.h 5b4668f

Diff: <a href="http://git.reviewboard.kde.org/r/109967/diff/" title="http://git.reviewboard.kde.org/r/109967/diff/">http://git.reviewboard.kde.org/r/109967/diff/</a>

Testing
Tested a plasmoid that used these flags.

Thanks,

Anant Kamath

Re: Review Request 109967: Export KLocale flags to QML locale bi

By Sebastian =?utf... at 04/11/2013 - 16:39

Ship it!

Ship It!

- Sebastian K├╝gler

On April 11, 2013, 8:30 p.m., Anant Kamath wrote:

Re: Review Request 109967: Export KLocale flags to QML locale bi

By Sebastian =?utf... at 04/11/2013 - 16:40

This patch needs forward porting to (the Frameworks5) plasma-framework repo. Can you do this, or would you rather have me do it?

- Sebastian

On April 11, 2013, 8:30 p.m., Anant Kamath wrote: