DevHeads.net

Review Request 110285: Fixed warning message when user trying to set more than 8 keyboard layouts

Review request for kde-workspace.

Description
If user trying to set more than 8 keyboard layouts in System Settings/Input devices/Keyboard layouts he sees a warning that he can't set more than 4 keyboard layouts but there should be "8".

My patch fixes typo in the warning message.

This addresses bug 285562.
<a href="http://bugs.kde.org/show_bug.cgi?id=285562" title="http://bugs.kde.org/show_bug.cgi?id=285562">http://bugs.kde.org/show_bug.cgi?id=285562</a>

Diffs
kcontrol/keyboard/kcm_keyboard_widget.cpp e513a41
kcontrol/keyboard/x11_helper.h 31f76f9
kcontrol/keyboard/x11_helper.cpp ebd09f3

Diff: <a href="http://git.reviewboard.kde.org/r/110285/diff/" title="http://git.reviewboard.kde.org/r/110285/diff/">http://git.reviewboard.kde.org/r/110285/diff/</a>

Testing
Yes, it works for me.

Thanks,

Victor Polevoy

Comments

Re: Review Request 110285: Fixed warning message when user tryin

By Commit Hook at 07/02/2013 - 15:42

This review has been submitted with commit 7c599bae516c61365c4eda2be998c97594e3b1af by Victor Polevoy to branch master.

- Commit Hook

On May 3, 2013, 11 a.m., Victor Polevoy wrote:

Re: Review Request 110285: Fixed warning message when user tryin

By Commit Hook at 07/02/2013 - 15:42

(Updated July 2, 2013, 8:42 p.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace.

Description
If user trying to set more than 8 keyboard layouts in System Settings/Input devices/Keyboard layouts he sees a warning that he can't set more than 4 keyboard layouts but there should be "8".

My patch fixes typo in the warning message.

This addresses bug 285562.
<a href="http://bugs.kde.org/show_bug.cgi?id=285562" title="http://bugs.kde.org/show_bug.cgi?id=285562">http://bugs.kde.org/show_bug.cgi?id=285562</a>

Diffs
kcontrol/keyboard/kcm_keyboard_widget.cpp e513a41
kcontrol/keyboard/x11_helper.h 31f76f9
kcontrol/keyboard/x11_helper.cpp ebd09f3

Diff: <a href="http://git.reviewboard.kde.org/r/110285/diff/" title="http://git.reviewboard.kde.org/r/110285/diff/">http://git.reviewboard.kde.org/r/110285/diff/</a>

Testing
Yes, it works for me.

Thanks,

Victor Polevoy

Re: Review Request 110285: Fixed warning message when user tryin

By Andriy Rysin at 06/19/2013 - 21:33

Ship it!

Ship It!

- Andriy Rysin

On May 3, 2013, 11 a.m., Victor Polevoy wrote: