DevHeads.net

Review Request 110331: Sync kwalletmanager settings UI to kwalletd changes proposed in review 110330

Review request for KDE Runtime and Harald Sitter.

Description
This adapts the checkbox label to the kwalletd behavior change proposed in: <a href="https://git.reviewboard.kde.org/r/110330/" title="https://git.reviewboard.kde.org/r/110330/">https://git.reviewboard.kde.org/r/110330/</a>

Diffs
konfigurator/walletconfigwidget.ui bbb006d

Diff: <a href="http://git.reviewboard.kde.org/r/110331/diff/" title="http://git.reviewboard.kde.org/r/110331/diff/">http://git.reviewboard.kde.org/r/110331/diff/</a>

Testing
Test package for Kubuntu by Harald Sitter, operation verified at runtime.

Thanks,

Eike Hein

Comments

Re: Review Request 110331: Sync kwalletmanager settings UI to kw

By Eike Hein at 05/08/2013 - 19:16

(Updated May 8, 2013, 11:16 p.m.)

Review request for KDE Runtime and Harald Sitter.

Changes
This updated diff syncs the default value of the setting to the changed default in the parent review.

Note: I most likely won't be available for further updates until Monday.

Description
This adapts the checkbox label to the kwalletd behavior change proposed in: <a href="https://git.reviewboard.kde.org/r/110330/" title="https://git.reviewboard.kde.org/r/110330/">https://git.reviewboard.kde.org/r/110330/</a>

Diffs (updated)
konfigurator/konfigurator.cpp 3cc1b3f
konfigurator/walletconfigwidget.ui bbb006d

Diff: <a href="http://git.reviewboard.kde.org/r/110331/diff/" title="http://git.reviewboard.kde.org/r/110331/diff/">http://git.reviewboard.kde.org/r/110331/diff/</a>

Testing
Test package for Kubuntu by Harald Sitter, operation verified at runtime.

Thanks,

Eike Hein

Re: Review Request 110331: Sync kwalletmanager settings UI to kw

By Commit Hook at 06/29/2013 - 11:29

(Updated June 29, 2013, 3:29 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Runtime and Harald Sitter.

Description
This adapts the checkbox label to the kwalletd behavior change proposed in: <a href="https://git.reviewboard.kde.org/r/110330/" title="https://git.reviewboard.kde.org/r/110330/">https://git.reviewboard.kde.org/r/110330/</a>

Diffs
konfigurator/konfigurator.cpp 3cc1b3f
konfigurator/walletconfigwidget.ui bbb006d

Diff: <a href="http://git.reviewboard.kde.org/r/110331/diff/" title="http://git.reviewboard.kde.org/r/110331/diff/">http://git.reviewboard.kde.org/r/110331/diff/</a>

Testing
Test package for Kubuntu by Harald Sitter, operation verified at runtime.

Thanks,

Eike Hein

Re: Review Request 110331: Sync kwalletmanager settings UI to kw

By Commit Hook at 06/29/2013 - 11:29

This review has been submitted with commit e7955906acd25f5a2668e96c3b5dd2bacf9e1cea by Eike Hein to branch master.

- Commit Hook

On May 8, 2013, 11:16 p.m., Eike Hein wrote:

Re: Review Request 110331: Sync kwalletmanager settings UI to kw

By Alex Fiestas at 06/28/2013 - 08:46

Ship it!

Once <a href="https://git.reviewboard.kde.org/r/110330/" title="https://git.reviewboard.kde.org/r/110330/">https://git.reviewboard.kde.org/r/110330/</a> is submited, this one should follow.

- Àlex Fiestas

On May 8, 2013, 11:16 p.m., Eike Hein wrote:

Re: Review Request 110331: Sync kwalletmanager settings UI to kw

By Eike Hein at 05/17/2013 - 19:06

If there are no objections I intend to commit this patch early next week.

- Eike Hein

On May 8, 2013, 11:16 p.m., Eike Hein wrote: