DevHeads.net

Review Request 110529: more error handling in KIdleTime

Review request for kdelibs.

Description
more error handling in KIdleTime

Segfaults could result in some rare circumstances

Diffs
tier1/kidletime/src/xsyncbasedpoller.cpp e5f5328ae66d44e9224582ad759207bc42333d80
tier1/kidletime/src/kidletime.cpp fe18ee5d5c4525086a56d99e76e8ea0a4a92ce08

Diff: <a href="http://git.reviewboard.kde.org/r/110529/diff/" title="http://git.reviewboard.kde.org/r/110529/diff/">http://git.reviewboard.kde.org/r/110529/diff/</a>

Testing

Thanks,

Ian Monroe

Comments

Re: Review Request 110529: more error handling in KIdleTime

By Ian Monroe at 05/19/2013 - 22:25

(Updated May 20, 2013, 3:25 a.m.)

Review request for KDE Frameworks and kdelibs.

Description
more error handling in KIdleTime

Segfaults could result in some rare circumstances

Diffs
tier1/kidletime/src/xsyncbasedpoller.cpp e5f5328ae66d44e9224582ad759207bc42333d80
tier1/kidletime/src/kidletime.cpp fe18ee5d5c4525086a56d99e76e8ea0a4a92ce08

Diff: <a href="http://git.reviewboard.kde.org/r/110529/diff/" title="http://git.reviewboard.kde.org/r/110529/diff/">http://git.reviewboard.kde.org/r/110529/diff/</a>

Testing

Thanks,

Ian Monroe

Re: Review Request 110529: more error handling in KIdleTime

By Commit Hook at 05/20/2013 - 10:58

(Updated May 20, 2013, 3:58 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Frameworks and kdelibs.

Description
more error handling in KIdleTime

Segfaults could result in some rare circumstances

Diffs
tier1/kidletime/src/xsyncbasedpoller.cpp e5f5328ae66d44e9224582ad759207bc42333d80
tier1/kidletime/src/kidletime.cpp fe18ee5d5c4525086a56d99e76e8ea0a4a92ce08

Diff: <a href="http://git.reviewboard.kde.org/r/110529/diff/" title="http://git.reviewboard.kde.org/r/110529/diff/">http://git.reviewboard.kde.org/r/110529/diff/</a>

Testing

Thanks,

Ian Monroe

Re: Review Request 110529: more error handling in KIdleTime

By Commit Hook at 05/20/2013 - 10:58

This review has been submitted with commit acb74d44783814fb4f9a41bd4bc6eec2c4faf871 by Ian Monroe to branch frameworks.

- Commit Hook

On May 20, 2013, 3:25 a.m., Ian Monroe wrote:

Re: Review Request 110529: more error handling in KIdleTime

By David Faure at 05/20/2013 - 01:23

Ship it!

Looks good, just whitespace issues to fix before committing.

tier1/kidletime/src/kidletime.cpp
<http://git.reviewboard.kde.org/r/110529/#comment24353>

wrong indentation change?

tier1/kidletime/src/kidletime.cpp
<http://git.reviewboard.kde.org/r/110529/#comment24354>

space after if

tier1/kidletime/src/kidletime.cpp
<http://git.reviewboard.kde.org/r/110529/#comment24355>

space after if (and there's more below)

- David Faure

On May 20, 2013, 3:25 a.m., Ian Monroe wrote: