DevHeads.net

Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

Review request for KDE Runtime and David Faure.

Description
Create directories without trailing spaces, like every other kio slave does.

This addresses bug 320335.
<a href="http://bugs.kde.org/show_bug.cgi?id=320335" title="http://bugs.kde.org/show_bug.cgi?id=320335">http://bugs.kde.org/show_bug.cgi?id=320335</a>

Diffs
kioslave/applications/kio_applications.cpp 5fc5112

Diff: <a href="http://git.reviewboard.kde.org/r/110924/diff/" title="http://git.reviewboard.kde.org/r/110924/diff/">http://git.reviewboard.kde.org/r/110924/diff/</a>

Testing
Works for me

Thanks,

Emmanuel Pescosta

Comments

Re: Review Request 110924: Fix Bug 320335 - Problem with tree vi

By Commit Hook at 06/10/2013 - 04:33

(Updated June 10, 2013, 8:33 a.m.)

Status
This change has been marked as submitted.

Review request for KDE Runtime and David Faure.

Description
Create directories without trailing spaces, like every other kio slave does.

This addresses bug 320335.
<a href="http://bugs.kde.org/show_bug.cgi?id=320335" title="http://bugs.kde.org/show_bug.cgi?id=320335">http://bugs.kde.org/show_bug.cgi?id=320335</a>

Diffs
kioslave/applications/kio_applications.cpp 5fc5112

Diff: <a href="http://git.reviewboard.kde.org/r/110924/diff/" title="http://git.reviewboard.kde.org/r/110924/diff/">http://git.reviewboard.kde.org/r/110924/diff/</a>

Testing
Works for me

Thanks,

Emmanuel Pescosta

Re: Review Request 110924: Fix Bug 320335 - Problem with tree vi

By Commit Hook at 06/10/2013 - 04:33

This review has been submitted with commit 3dafdf356b549c9f9cbedcebb996486be8b56ce9 by Emmanuel Pescosta to branch master.

- Commit Hook

On June 9, 2013, 10:46 p.m., Emmanuel Pescosta wrote:

Re: Review Request 110924: Fix Bug 320335 - Problem with tree vi

By David Faure at 06/10/2013 - 04:18

Ship it!

Patch looks good, but commit log is wrong, it says "trailing spaces" instead of "trailing slash".

- David Faure

On June 9, 2013, 10:46 p.m., Emmanuel Pescosta wrote: