DevHeads.net

Review Request 111341: Oxygenify KNetattach

Review request for KDE Runtime.

Description
Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?

Diffs
knetattach/knetattach.cpp 3d348c1
knetattach/knetattach.desktop 2684602

Diff: <a href="http://git.reviewboard.kde.org/r/111341/diff/" title="http://git.reviewboard.kde.org/r/111341/diff/">http://git.reviewboard.kde.org/r/111341/diff/</a>

Testing
Works fine for quite some time on Kubuntu.

Thanks,

Rohan Garg

Comments

Re: Review Request 111341: Oxygenify KNetattach

By =?utf-8?Q?Thoma... at 07/01/2013 - 09:01

knetattach/knetattach.cpp
<http://git.reviewboard.kde.org/r/111341/#comment25903>

Seems wrong. Have you had contact to the oxygen artists (ie. esp. Nuno)?

- Thomas Lübking

On July 1, 2013, 11:20 a.m., Rohan Garg wrote:

Re: Review Request 111341: Oxygenify KNetattach

By Rohan Garg at 07/01/2013 - 11:12

(Updated July 1, 2013, 8:42 p.m.)

Review request for KDE Runtime.

Changes
Asked Nuno to have a look at this request, on his suggestion, I've changed the icon to network-workgroup.

Description
Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?

Diffs (updated)
knetattach/knetattach.cpp 3d348c1
knetattach/knetattach.desktop 2684602

Diff: <a href="http://git.reviewboard.kde.org/r/111341/diff/" title="http://git.reviewboard.kde.org/r/111341/diff/">http://git.reviewboard.kde.org/r/111341/diff/</a>

Testing
Works fine for quite some time on Kubuntu.

Thanks,

Rohan Garg

Re: Review Request 111341: Oxygenify KNetattach

By Rohan Garg at 08/05/2013 - 06:07

(Updated Aug. 5, 2013, 3:37 p.m.)

Status
This change has been discarded.

Review request for KDE Runtime.

Description
Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?

Diffs
knetattach/knetattach.cpp 3d348c1
knetattach/knetattach.desktop 2684602

Diff: <a href="http://git.reviewboard.kde.org/r/111341/diff/" title="http://git.reviewboard.kde.org/r/111341/diff/">http://git.reviewboard.kde.org/r/111341/diff/</a>

Testing
Works fine for quite some time on Kubuntu.

Thanks,

Rohan Garg

Re: Review Request 111341: Oxygenify KNetattach

By Pino Toscano at 07/08/2013 - 14:47

The patch is wrong.

It is correct for knetattach to have an own icon and to use it its own code. If you want an Oxygen version of this icon, then create one (named "knetattach") and add it to the Oxygen icon theme, which will be used automatically when the icon theme in use is Oxygen (or a derived from it which not carries an own version of the knetattach icon).

- Pino Toscano

On July 1, 2013, 3:12 p.m., Rohan Garg wrote:

Re: Review Request 111341: Oxygenify KNetattach

By Rohan Garg at 08/05/2013 - 06:07

yep, sounds like a better solution. Discarding this review for now.

- Rohan

On July 1, 2013, 8:42 p.m., Rohan Garg wrote:

Re: Review Request 111341: Oxygenify KNetattach

By =?utf-8?Q?Thoma... at 07/01/2013 - 16:02

Looks like the proper source, but i guess the icon should be rather replaced so that any user of knetattach (eg. a local .desktop file) gets the updated variant.

Please attach Nuno to the review as the icons are his domain ;-)

- Thomas Lübking

On July 1, 2013, 3:12 p.m., Rohan Garg wrote:

Re: Review Request 111341: Oxygenify KNetattach

By Rohan Garg at 07/08/2013 - 14:33

Bump? I agree with the fact that we should replace the icons so that any local desktop files get the change.

- Rohan

On July 1, 2013, 8:42 p.m., Rohan Garg wrote:

Re: Review Request 111341: Oxygenify KNetattach

By Rohan Garg at 07/03/2013 - 08:23

RB can't seem to find Nuno. Though I've pinged him with the RB link on IRC, I have yet to get a reply.

- Rohan

On July 1, 2013, 8:42 p.m., Rohan Garg wrote: