DevHeads.net

Review Request 111419: Use case-insensitive URL scheme comparisons in KUrl::isLocalFile

Review request for kdelibs and David Faure.

Description
This patch fixes KUrl::isLocalFile to properly deal with upper case URL scheme.

This addresses bug 295371.
<a href="http://bugs.kde.org/show_bug.cgi?id=295371" title="http://bugs.kde.org/show_bug.cgi?id=295371">http://bugs.kde.org/show_bug.cgi?id=295371</a>

Diffs
kdecore/services/kservice.h 3843bad
kdecore/services/kservice.cpp e2cc86f
kio/kfile/kopenwithdialog.cpp 84465cd

Diff: <a href="http://git.reviewboard.kde.org/r/111419/diff/" title="http://git.reviewboard.kde.org/r/111419/diff/">http://git.reviewboard.kde.org/r/111419/diff/</a>

Testing
kioclient exec "FILE:///"

Thanks,

Dawit Alemayehu

Comments

Re: Review Request 111419: Use case-insensitive URL scheme compa

By Dawit A at 07/06/2013 - 12:55

(Updated July 6, 2013, 4:55 p.m.)

Review request for kdelibs and David Faure.

Changes
Uploaded the correct patch.

Description
This patch fixes KUrl::isLocalFile to properly deal with upper case URL scheme.

This addresses bug 295371.
<a href="http://bugs.kde.org/show_bug.cgi?id=295371" title="http://bugs.kde.org/show_bug.cgi?id=295371">http://bugs.kde.org/show_bug.cgi?id=295371</a>

Diffs (updated)
kdecore/io/kurl.cpp 5ea3e01
kdecore/tests/kurltest.cpp 71770ee

Diff: <a href="http://git.reviewboard.kde.org/r/111419/diff/" title="http://git.reviewboard.kde.org/r/111419/diff/">http://git.reviewboard.kde.org/r/111419/diff/</a>

Testing
kioclient exec "FILE:///"

Thanks,

Dawit Alemayehu

Re: Review Request 111419: Use case-insensitive URL scheme compa

By Commit Hook at 07/07/2013 - 05:23

(Updated July 7, 2013, 9:23 a.m.)

Status
This change has been marked as submitted.

Review request for kdelibs and David Faure.

Description
This patch fixes KUrl::isLocalFile to properly deal with upper case URL scheme.

This addresses bug 295371.
<a href="http://bugs.kde.org/show_bug.cgi?id=295371" title="http://bugs.kde.org/show_bug.cgi?id=295371">http://bugs.kde.org/show_bug.cgi?id=295371</a>

Diffs
kdecore/io/kurl.cpp 5ea3e01
kdecore/tests/kurltest.cpp 71770ee

Diff: <a href="http://git.reviewboard.kde.org/r/111419/diff/" title="http://git.reviewboard.kde.org/r/111419/diff/">http://git.reviewboard.kde.org/r/111419/diff/</a>

Testing
kioclient exec "FILE:///"

Thanks,

Dawit Alemayehu

Re: Review Request 111419: Use case-insensitive URL scheme compa

By Commit Hook at 07/07/2013 - 05:23

This review has been submitted with commit 0b5bfb9444b4f9a55d9178adcb9d84f19c0a0487 by Dawit Alemayehu to branch master.

- Commit Hook

On July 6, 2013, 4:55 p.m., Dawit Alemayehu wrote:

Re: Review Request 111419: Use case-insensitive URL scheme compa

By David Faure at 07/07/2013 - 02:55

Ship it!

OK. scheme() returns lowercase in Qt5 (which fixes this too), so I'll revert this after merging to frameworks.

- David Faure

On July 6, 2013, 4:55 p.m., Dawit Alemayehu wrote: