DevHeads.net

Review Request 112236: krunner: Add the full name of completion matches to history

Review request for kde-workspace and Plasma.

Description
Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.

This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
Exact matches are added as-is.

example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.

Diffs
krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343

Diff: <a href="http://git.reviewboard.kde.org/r/112236/diff/" title="http://git.reviewboard.kde.org/r/112236/diff/">http://git.reviewboard.kde.org/r/112236/diff/</a>

Testing

Thanks,

Harald Hvaal

Comments

Re: Review Request 112236: krunner: Add the full name of complet

By Harald Hvaal at 08/31/2013 - 05:34

(Updated Aug. 31, 2013, 11:34 a.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace and Plasma.

Description
Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.

This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
Exact matches are added as-is.

example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.

Diffs
krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104
kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343

Diff: <a href="http://git.reviewboard.kde.org/r/112236/diff/" title="http://git.reviewboard.kde.org/r/112236/diff/">http://git.reviewboard.kde.org/r/112236/diff/</a>

Testing

Thanks,

Harald Hvaal

Re: Review Request 112236: krunner: Add the full name of complet

By Aaron J. Seigo at 08/30/2013 - 13:18

Ship it!

minus the unrelated change that got pulled it accidentally, this looks good :)

- Aaron J. Seigo

On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:

Re: Review Request 112236: krunner: Add the full name of complet

By =?utf-8?Q?Thoma... at 08/24/2013 - 06:08

kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/112236/#comment28473>

... ;-)

- Thomas L├╝bking

On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:

Re: Review Request 112236: krunner: Add the full name of complet

By Martin =?ISO-88... at 08/24/2013 - 07:14

post-review happily includes any changes you have in a tree. Always do git stash before using it ;-)

- Martin

On Aug. 24, 2013, 11:52 a.m., Harald Hvaal wrote:

Re: Review Request 112236: krunner: Add the full name of complet

By Harald Hvaal at 08/24/2013 - 06:17

yeah, not sure what happened with post-review here, but it's definitely not part of the actual commit :)

- Harald

On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote: