DevHeads.net

Review Request 113056: Port ksgrd library to KF5

Review request for kde-workspace and Sebastian Kügler.

Repository: kde-workspace

Description
Port ksgrd library to KF5,

I already pushed kDebug > qDebug changes with commit 03681a90

Diffs
libs/ksysguard/CMakeLists.txt b00d9ff
libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d
libs/ksysguard/ksgrd/SensorAgent.cpp f067d31
libs/ksysguard/ksgrd/SensorManager.cpp f1657ee
libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f
libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62

Diff: <a href="http://git.reviewboard.kde.org/r/113056/diff/" title="http://git.reviewboard.kde.org/r/113056/diff/">http://git.reviewboard.kde.org/r/113056/diff/</a>

Testing
No tests, we can test this by porting systemmonitor dataengine later.

Thanks,

Bhushan Shah

Comments

Re: Review Request 113056: Port ksgrd library to KF5

By Bhushan Shah at 10/03/2013 - 01:50

(Updated Oct. 3, 2013, 5:50 a.m.)

Review request for kde-workspace and Sebastian Kügler.

Repository: kde-workspace

Description
Port ksgrd library to KF5,

I already pushed kDebug > qDebug changes with commit 03681a90

Diffs
libs/ksysguard/CMakeLists.txt b00d9ff
libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d
libs/ksysguard/ksgrd/SensorAgent.cpp f067d31
libs/ksysguard/ksgrd/SensorManager.cpp f1657ee
libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f
libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62

Diff: <a href="http://git.reviewboard.kde.org/r/113056/diff/" title="http://git.reviewboard.kde.org/r/113056/diff/">http://git.reviewboard.kde.org/r/113056/diff/</a>

Testing (updated)
No tests, we can test this by porting systemmonitor dataengine later.

Tested, works as expected. <a href="https://git.reviewboard.kde.org/r/113072/" title="https://git.reviewboard.kde.org/r/113072/">https://git.reviewboard.kde.org/r/113072/</a>

Thanks,

Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

By Bhushan Shah at 10/03/2013 - 07:00

(Updated Oct. 3, 2013, 11 a.m.)

Review request for kde-workspace and Sebastian Kügler.

Repository: kde-workspace

Description
Port ksgrd library to KF5,

I already pushed kDebug > qDebug changes with commit 03681a90

Diffs (updated)
libs/ksysguard/CMakeLists.txt b00d9ff
libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d
libs/ksysguard/ksgrd/SensorAgent.cpp f067d31
libs/ksysguard/ksgrd/SensorManager.cpp f1657ee
libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f
libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62

Diff: <a href="http://git.reviewboard.kde.org/r/113056/diff/" title="http://git.reviewboard.kde.org/r/113056/diff/">http://git.reviewboard.kde.org/r/113056/diff/</a>

Testing
No tests, we can test this by porting systemmonitor dataengine later.

Tested, works as expected. <a href="https://git.reviewboard.kde.org/r/113072/" title="https://git.reviewboard.kde.org/r/113072/">https://git.reviewboard.kde.org/r/113072/</a>

Thanks,

Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

By Bhushan Shah at 10/03/2013 - 07:42

(Updated Oct. 3, 2013, 11:42 a.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace and Sebastian Kügler.

Repository: kde-workspace

Description
Port ksgrd library to KF5,

I already pushed kDebug > qDebug changes with commit 03681a90

Diffs
libs/ksysguard/CMakeLists.txt b00d9ff
libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d
libs/ksysguard/ksgrd/SensorAgent.cpp f067d31
libs/ksysguard/ksgrd/SensorManager.cpp f1657ee
libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f
libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62

Diff: <a href="http://git.reviewboard.kde.org/r/113056/diff/" title="http://git.reviewboard.kde.org/r/113056/diff/">http://git.reviewboard.kde.org/r/113056/diff/</a>

Testing
No tests, we can test this by porting systemmonitor dataengine later.

Tested, works as expected. <a href="https://git.reviewboard.kde.org/r/113072/" title="https://git.reviewboard.kde.org/r/113072/">https://git.reviewboard.kde.org/r/113072/</a>

Thanks,

Bhushan Shah

Re: Review Request 113056: Port ksgrd library to KF5

By Commit Hook at 10/03/2013 - 07:42

This review has been submitted with commit 0cfbe6ba886fff62857ac1d548eb352d3664fa0d by Bhushan Shah to branch master.

- Commit Hook

On Oct. 3, 2013, 11 a.m., Bhushan Shah wrote:

Re: Review Request 113056: Port ksgrd library to KF5

By Sebastian =?utf... at 10/03/2013 - 07:39

Ship it!

Ship It!

- Sebastian Kügler

On Oct. 3, 2013, 11 a.m., Bhushan Shah wrote:

Re: Review Request 113056: Port ksgrd library to KF5

By david at 10/03/2013 - 05:39

libs/ksysguard/ksgrd/SensorAgent.cpp
<http://git.reviewboard.kde.org/r/113056/#comment30200>

#include <KLocalizedString>

should work.

libs/ksysguard/ksgrd/SensorAgent.cpp
<http://git.reviewboard.kde.org/r/113056/#comment30201>

This line is rather important as it makes translations work.

You are correct that it is now obsolete, but there is a new replacement that it should be ported to.

see <a href="http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide.html#link_cat" title="http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide.html#link_cat">http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide...</a>

i.e

#define TRANSLATION_DOMAIN "ksgrd"
#include <KLocalizedString>

- David Edmundson

On Oct. 3, 2013, 5:50 a.m., Bhushan Shah wrote: