DevHeads.net

Review Request 113194: port away from KIcon in libs/taskmanager

Review request for kde-workspace.

Repository: kde-workspace

Description
port away from KIcon in libs/taskmanager

Diffs
libs/taskmanager/abstractgroupingstrategy.cpp 601fcd1d2b186f22d58c9def55fe9ae5b208d7c4
libs/taskmanager/launcherconfig.cpp 8656dad5713eda3d472084d20bc42e372c066389
libs/taskmanager/launcheritem.h 604f046bc4f3a72da9b1f60553ab1802bd251196
libs/taskmanager/launcheritem.cpp 7d8e7af8ad90fc2289d8f897b2177d6f1fb4d5a0
libs/taskmanager/launcherproperties.cpp 5db134b7da7cf89bd269349101258943519a78bc
libs/taskmanager/startup.cpp 5524ea23845726b87f1238d9e324bed185399d2a
libs/taskmanager/taskactions.cpp b87b3c02e61e9b91966fb2a909bdbd88c9f94a5d
libs/taskmanager/taskgroup.cpp 7c8f1f16e322175e8ff0cd117b48311eb5d865f8

Diff: <a href="http://git.reviewboard.kde.org/r/113194/diff/" title="http://git.reviewboard.kde.org/r/113194/diff/">http://git.reviewboard.kde.org/r/113194/diff/</a>

Testing
compiles

Thanks,

Alexander Richardson

Comments

Re: Review Request 113194: port away from KIcon in libs/taskmana

By Alex Richardson at 10/14/2013 - 08:11

(Updated Oct. 14, 2013, 1:11 p.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace.

Repository: kde-workspace

Description
port away from KIcon in libs/taskmanager

Diffs
libs/taskmanager/abstractgroupingstrategy.cpp 601fcd1d2b186f22d58c9def55fe9ae5b208d7c4
libs/taskmanager/launcherconfig.cpp 8656dad5713eda3d472084d20bc42e372c066389
libs/taskmanager/launcheritem.h 604f046bc4f3a72da9b1f60553ab1802bd251196
libs/taskmanager/launcheritem.cpp 7d8e7af8ad90fc2289d8f897b2177d6f1fb4d5a0
libs/taskmanager/launcherproperties.cpp 5db134b7da7cf89bd269349101258943519a78bc
libs/taskmanager/startup.cpp 5524ea23845726b87f1238d9e324bed185399d2a
libs/taskmanager/taskactions.cpp b87b3c02e61e9b91966fb2a909bdbd88c9f94a5d
libs/taskmanager/taskgroup.cpp 7c8f1f16e322175e8ff0cd117b48311eb5d865f8

Diff: <a href="http://git.reviewboard.kde.org/r/113194/diff/" title="http://git.reviewboard.kde.org/r/113194/diff/">http://git.reviewboard.kde.org/r/113194/diff/</a>

Testing
compiles

Thanks,

Alexander Richardson

Re: Review Request 113194: port away from KIcon in libs/taskmana

By Commit Hook at 10/14/2013 - 08:11

This review has been submitted with commit ec331326e4a8d6cb96d4d51cb29d67bc10968e22 by Alex Richardson to branch master.

- Commit Hook

On Oct. 10, 2013, 9:42 p.m., Alexander Richardson wrote:

Re: Review Request 113194: port away from KIcon in libs/taskmana

By Aleix Pol at 10/13/2013 - 19:03

Ship it!

Looks good to me, it's what you should be doing according to KDE5Porting.html

- Aleix Pol Gonzalez

On Oct. 10, 2013, 9:42 p.m., Alexander Richardson wrote: