DevHeads.net

Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

Review request for kde-workspace and Plasma.

Repository: kde-workspace

Description
Removes the white-black gradient spreading through the upper-half of the screen. IMHO it looks more elegant when it's just plain black.

Diffs
ksplash/ksplashqml/themes/Minimalistic/main.qml e4fb8b8

Diff: <a href="http://git.reviewboard.kde.org/r/113419/diff/" title="http://git.reviewboard.kde.org/r/113419/diff/">http://git.reviewboard.kde.org/r/113419/diff/</a>

Testing

File Attachments
Before
<a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png" title="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png">http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-...</a>
After
<a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png" title="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png">http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-...</a>

Thanks,

Martin Klapetek

Comments

Re: Review Request 113419: Remove the upper-half white gradient

By Martin Klapetek at 10/24/2013 - 10:15

(Updated Oct. 24, 2013, 3:15 p.m.)

Review request for kde-workspace and Plasma.

Repository: kde-workspace

Description (updated)
NOTE: This is intended for the PW2, not current 4.x series.

Removes the white-black gradient spreading through the upper-half of the screen. IMHO it looks more elegant when it's just plain black.

Diffs
ksplash/ksplashqml/themes/Minimalistic/main.qml e4fb8b8

Diff: <a href="http://git.reviewboard.kde.org/r/113419/diff/" title="http://git.reviewboard.kde.org/r/113419/diff/">http://git.reviewboard.kde.org/r/113419/diff/</a>

Testing

File Attachments
Before
<a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png" title="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png">http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-...</a>
After
<a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png" title="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png">http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-...</a>

Thanks,

Martin Klapetek

Re: Review Request 113419: Remove the upper-half white gradient

By Martin Klapetek at 05/09/2014 - 09:29

(Updated May 9, 2014, 4:29 p.m.)

Status
This change has been discarded.

Review request for kde-workspace and Plasma.

Repository: kde-workspace

Description
NOTE: This is intended for the PW2, not current 4.x series.

Removes the white-black gradient spreading through the upper-half of the screen. IMHO it looks more elegant when it's just plain black.

Diffs
ksplash/ksplashqml/themes/Minimalistic/main.qml e4fb8b8

Diff: <a href="https://git.reviewboard.kde.org/r/113419/diff/" title="https://git.reviewboard.kde.org/r/113419/diff/">https://git.reviewboard.kde.org/r/113419/diff/</a>

Testing

File Attachments
Before
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png">https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408...</a>
After
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png">https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4...</a>

Thanks,

Martin Klapetek

Re: Review Request 113419: Remove the upper-half white gradient

By Ivan Cukic at 10/24/2013 - 10:35

Actually, this is something that I wanted to do ever since I saw it on a different screen to the one I had when I made it.

If you want to try it with a radial gradient, mind that around the logo, the background needs to be pitch-black. Because the masking for the gear is a simple black overlay.

- Ivan Čukić

On Oct. 24, 2013, 3:15 p.m., Martin Klapetek wrote:

Re: Review Request 113419: Remove the upper-half white gradient

By =?utf-8?Q?Thoma... at 10/24/2013 - 12:06

That's not really gonna work.
You need to apply an actual distorsion filter on the gradient (ie. randomly move around quite some pixels) to avoid banding if you've a gradient across a thousand pixels that spans from #000000 to #111111

So you'd rather bring a prefabbed image and at best don't scale it, but preferably scale it UP (more pixels), not down (more banding)
Then plug the KDE logo in front of it.

- Thomas

On Oct. 24, 2013, 3:15 p.m., Martin Klapetek wrote:

Re: Review Request 113419: Remove the upper-half white gradient

By Ivan Cukic at 10/24/2013 - 10:56

p.s. And it *needs* some background noise so that the gradients look less artificial.

- Ivan

On Oct. 24, 2013, 3:15 p.m., Martin Klapetek wrote:

Re: Review Request 113419: Remove the upper-half white gradient

By Mark at 10/24/2013 - 10:08

-1

I have to add some explanation to that.

I'm all OK with plain and simplistic, but not TOO plain and simplistic (aka, the Windows 8 and apple route). We don't live in a monochrome age anymore so i think the theme should retain "some" subtle color variations. Having said that, the current plain horizontal top gradient might be a bit too simple (as in not very stylish) as well. Take a look at this for example: <a href="http://paswall.com/black-wallpaper-6462-hd.html" title="http://paswall.com/black-wallpaper-6462-hd.html">http://paswall.com/black-wallpaper-6462-hd.html</a> Ignore the texture, but you can see the subtle lighting in there. That's probably what the plain theme needs.

This is just my opinion (and i happen to hate iOS7 + windows 8 for their fugly themes). I disagree with the change, but understand it if you would push it regardless. The general design theme these days seems to be heading back to 16 color monitors anyway.

- Mark Gaiser

On Oct. 24, 2013, 2:32 p.m., Martin Klapetek wrote:

Re: Review Request 113419: Remove the upper-half white gradient

By Albert Astals Cid at 10/24/2013 - 10:28

<a href="http://qt-project.org/doc/qt-5.1/qtgraphicaleffects/qml-qtgraphicaleffects1-radialgradient.html" title="http://qt-project.org/doc/qt-5.1/qtgraphicaleffects/qml-qtgraphicaleffects1-radialgradient.html">http://qt-project.org/doc/qt-5.1/qtgraphicaleffects/qml-qtgraphicaleffec...</a>

- Albert

On Oct. 24, 2013, 3:15 p.m., Martin Klapetek wrote:

Re: Review Request 113419: Remove the upper-half white gradient

By Martin Klapetek at 10/24/2013 - 10:14

Yeah, the radial gradient could be nice. Can QML do radial gradients?

- Martin

On Oct. 24, 2013, 2:32 p.m., Martin Klapetek wrote:

Re: Review Request 113419: Remove the upper-half white gradient

By Bhushan Shah at 10/24/2013 - 09:38

IMHO ship it! but I will wait for others to give you "Ship It!"

- Bhushan Shah

On Oct. 24, 2013, 8:02 p.m., Martin Klapetek wrote: