DevHeads.net

Review Request 113479: fix kshareddatacache on windows

Review request for kdelibs and Michael Pyne.

Repository: kdelibs

Description
fix kshareddatacache on windows to at least not be a way to have a bytearray roundtrip.

Also, the windows implementation is currently only a in-memory one, so don't test on windows if there is a file written.

Diffs
tier1/kcoreaddons/autotests/kshareddatacachetest.cpp a4484560735f9096ecdac26b3c539394602e0f31
tier1/kcoreaddons/src/lib/caching/kshareddatacache_win.cpp cdc6536b56888a615e74960bf1b55fb12cc3e70d

Diff: <a href="http://git.reviewboard.kde.org/r/113479/diff/" title="http://git.reviewboard.kde.org/r/113479/diff/">http://git.reviewboard.kde.org/r/113479/diff/</a>

Testing
Test suite passes

Thanks,

Sune Vuorela

Comments

Re: Review Request 113479: fix kshareddatacache on windows

By Sune Vuorela at 10/28/2013 - 06:07

(Updated Oct. 28, 2013, 10:07 a.m.)

Review request for KDE Frameworks, kdelibs and Michael Pyne.

Repository: kdelibs

Description
fix kshareddatacache on windows to at least not be a way to have a bytearray roundtrip.

Also, the windows implementation is currently only a in-memory one, so don't test on windows if there is a file written.

Diffs
tier1/kcoreaddons/autotests/kshareddatacachetest.cpp a4484560735f9096ecdac26b3c539394602e0f31
tier1/kcoreaddons/src/lib/caching/kshareddatacache_win.cpp cdc6536b56888a615e74960bf1b55fb12cc3e70d

Diff: <a href="http://git.reviewboard.kde.org/r/113479/diff/" title="http://git.reviewboard.kde.org/r/113479/diff/">http://git.reviewboard.kde.org/r/113479/diff/</a>

Testing
Test suite passes

Thanks,

Sune Vuorela

Re: Review Request 113479: fix kshareddatacache on windows

By Sune Vuorela at 10/28/2013 - 16:08

(Updated Oct. 28, 2013, 8:08 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Frameworks, kdelibs and Michael Pyne.

Repository: kdelibs

Description
fix kshareddatacache on windows to at least not be a way to have a bytearray roundtrip.

Also, the windows implementation is currently only a in-memory one, so don't test on windows if there is a file written.

Diffs
tier1/kcoreaddons/autotests/kshareddatacachetest.cpp a4484560735f9096ecdac26b3c539394602e0f31
tier1/kcoreaddons/src/lib/caching/kshareddatacache_win.cpp cdc6536b56888a615e74960bf1b55fb12cc3e70d

Diff: <a href="http://git.reviewboard.kde.org/r/113479/diff/" title="http://git.reviewboard.kde.org/r/113479/diff/">http://git.reviewboard.kde.org/r/113479/diff/</a>

Testing
Test suite passes

Thanks,

Sune Vuorela

Re: Review Request 113479: fix kshareddatacache on windows

By Commit Hook at 10/28/2013 - 16:08

This review has been submitted with commit 23e1b357115cc3b5eb699f93b22340529e5dd5eb by Sune Vuorela to branch frameworks.

- Commit Hook

On Oct. 28, 2013, 10:07 a.m., Sune Vuorela wrote:

Re: Review Request 113479: fix kshareddatacache on windows

By Michael Pyne at 10/28/2013 - 10:29

Ship it!

Looks good from here, the test you added even has a matching counterpart in the Linux version, so I hope I didn't write the Windows code. ;)

- Michael Pyne

On Oct. 28, 2013, 10:07 a.m., Sune Vuorela wrote: