DevHeads.net

Review Request 114437: Add right click contextmenu for Plasma Components TextField

Review request for KDE Runtime.

Repository: kde-runtime

Description
This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text.

Diffs
plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f

Diff: <a href="http://git.reviewboard.kde.org/r/114437/diff/" title="http://git.reviewboard.kde.org/r/114437/diff/">http://git.reviewboard.kde.org/r/114437/diff/</a>

Testing

Thanks,

Leszek Lesner

Comments

Re: Review Request 114437: Add right click contextmenu for Plasm

By Leszek Lesner at 12/13/2013 - 11:35

(Updated Dec. 13, 2013, 3:35 p.m.)

Review request for KDE Runtime.

Changes
Updated the diff to select text in textinput right after calling open upon the contextmenu.

Repository: kde-runtime

Description
This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text.

Diffs (updated)
plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f

Diff: <a href="http://git.reviewboard.kde.org/r/114437/diff/" title="http://git.reviewboard.kde.org/r/114437/diff/">http://git.reviewboard.kde.org/r/114437/diff/</a>

Testing

Thanks,

Leszek Lesner

Re: Review Request 114437: Add right click contextmenu for Plasm

By Leszek Lesner at 12/13/2013 - 11:37

(Updated Dec. 13, 2013, 3:37 p.m.)

Review request for KDE Runtime.

Changes
Use i18n() instead of qsTr()

Repository: kde-runtime

Description
This adds a right click context menu for PlasmaComponents.TextField which allows to cut, copy and paste text.

Diffs (updated)
plasma/declarativeimports/plasmacomponents/qml/TextField.qml 10a3d1f

Diff: <a href="http://git.reviewboard.kde.org/r/114437/diff/" title="http://git.reviewboard.kde.org/r/114437/diff/">http://git.reviewboard.kde.org/r/114437/diff/</a>

Testing

Thanks,

Leszek Lesner

Re: Review Request 114437: Add right click contextmenu for Plasm

By Albert Astals Cid at 01/23/2017 - 19:14

Mr Leszek, I'm very sorry we failed to commit this 3 years ago when you proposed this patch.

On the other hand you never answered Burkhard about his very valid concern of the new strings you're adding being basically untraslatable because they are not extracted to any .po file (and probably no catalog to translate them is loaded either).

I'll give you some time to address that issue, but I can understand that you may very well not be interested anymore. If nothing has happened to this review request in 3 months I'll discard it.

- Albert Astals Cid

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By Albert Astals Cid at 01/22/2017 - 18:20

Sebas should I commited this? After 3 years i'm not sure kde-runtime is the best thing to update in it's almost frozen state.

- Albert Astals Cid

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By Sebastian =?utf... at 01/23/2017 - 08:04

Ah, okay. Up to you then. I think this patch is rather safe, but I wouldn't want to get support calls for a regression...

- Sebastian

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By Albert Astals Cid at 01/23/2017 - 08:00

I do release kde-runtime

<a href="http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.12.1.tar.xz.mirrorlist" title="http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.12.1.tar.xz.mirrorlist">http://download.kde.org/stable/applications/16.12.1/src/kde-runtime-16.1...</a>

- Albert

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By Sebastian =?utf... at 01/23/2017 - 07:51

I'd just discard it. I don't think anybody is releasing kde-runtime anyway, and the proper way to fix this is to do it in QtQuick component's Label. Thanks for cleaning up, though!

- Sebastian

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By Sebastian =?utf... at 12/14/2013 - 15:39

Ship it!

Looks good.

- Sebastian Kügler

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By =?utf-8?q?Burkh... at 12/13/2013 - 11:39

Where is the message extraction for these i18n() ?

- Burkhard Lück

On Dec. 13, 2013, 3:37 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By =?utf-8?b?THVrw... at 12/13/2013 - 11:32

plasma/declarativeimports/plasmacomponents/qml/TextField.qml
<http://git.reviewboard.kde.org/r/114437/#comment32615>

...and here as well :)

- Lukáš Tinkl

On Dec. 13, 2013, 4:01 p.m., Leszek Lesner wrote:

Re: Review Request 114437: Add right click contextmenu for Plasm

By Sebastian =?utf... at 12/13/2013 - 11:24

Two comments inline.

plasma/declarativeimports/plasmacomponents/qml/TextField.qml
<http://git.reviewboard.kde.org/r/114437/#comment32612>

Use i18n() here

plasma/declarativeimports/plasmacomponents/qml/TextField.qml
<http://git.reviewboard.kde.org/r/114437/#comment32613>

i18n() here as well

- Sebastian Kügler

On Dec. 13, 2013, 3:01 p.m., Leszek Lesner wrote: