DevHeads.net

Review Request 114464: kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

Review request for kdelibs.

Repository: kdelibs

Description
kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

Diffs
kjs/number_object.h 634c642
kjs/number_object.cpp c284746

Diff: <a href="http://git.reviewboard.kde.org/r/114464/diff/" title="http://git.reviewboard.kde.org/r/114464/diff/">http://git.reviewboard.kde.org/r/114464/diff/</a>

Testing

Thanks,

Bernd Buschinski

Comments

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, i

By Bernd Buschinski at 12/15/2013 - 05:07

(Updated Dec. 15, 2013, 10:07 a.m.)

Review request for kdelibs.

Changes
- minor comment fix

Repository: kdelibs

Description
kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

Diffs (updated)
kjs/number_object.h 634c642
kjs/number_object.cpp c284746

Diff: <a href="http://git.reviewboard.kde.org/r/114464/diff/" title="http://git.reviewboard.kde.org/r/114464/diff/">http://git.reviewboard.kde.org/r/114464/diff/</a>

Testing

Thanks,

Bernd Buschinski

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, i

By Bernd Buschinski at 01/16/2014 - 12:56

(Updated Jan. 16, 2014, 5:56 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs.

Repository: kdelibs

Description
kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

Diffs
kjs/number_object.h 634c642
kjs/number_object.cpp c284746

Diff: <a href="https://git.reviewboard.kde.org/r/114464/diff/" title="https://git.reviewboard.kde.org/r/114464/diff/">https://git.reviewboard.kde.org/r/114464/diff/</a>

Testing

Thanks,

Bernd Buschinski

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, i

By Commit Hook at 01/19/2014 - 11:44

This review has been submitted with commit d252df5f664025ef115c9a11cd294e4951d7c49f by Bernd Buschinski to branch master.

- Commit Hook

On Jan. 16, 2014, 5:56 p.m., Bernd Buschinski wrote:

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, i

By Commit Hook at 01/16/2014 - 12:56

This review has been submitted with commit 9f9639652a7670e7096792ec5d74ccea4bcbc097 by Bernd Buschinski to branch KDE/4.12.

- Commit Hook

On Dec. 15, 2013, 10:07 a.m., Bernd Buschinski wrote:

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, i

By Martin Sandsmark at 12/14/2013 - 18:00

Ship it!

Ship It!

- Martin Tobias Holmedahl Sandsmark

On Dec. 14, 2013, 8:01 p.m., Bernd Buschinski wrote: