DevHeads.net

Review Request 114473: Change modality of dialog in KRun::displayOpenWithDialog to Qt::WindowModal

Review request for kdelibs and David Faure.

Bugs: 153421
<a href="http://bugs.kde.org/show_bug.cgi?id=153421" title="http://bugs.kde.org/show_bug.cgi?id=153421">http://bugs.kde.org/show_bug.cgi?id=153421</a>

Repository: kdelibs

Description
The attached patch changes the KOpenWith dialog in KRun::displayOpenWithDialog from blocking Konqueror windows when a user clicks on OpenWith in the context menu or unknown file in the Dolphin part.

Diffs
kio/kio/krun.cpp ad5656e

Diff: <a href="http://git.reviewboard.kde.org/r/114473/diff/" title="http://git.reviewboard.kde.org/r/114473/diff/">http://git.reviewboard.kde.org/r/114473/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request 114473: Change modality of dialog in KRun::di

By Dawit A at 12/22/2013 - 09:29

(Updated Dec. 22, 2013, 1:29 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs and David Faure.

Bugs: 153421
<a href="http://bugs.kde.org/show_bug.cgi?id=153421" title="http://bugs.kde.org/show_bug.cgi?id=153421">http://bugs.kde.org/show_bug.cgi?id=153421</a>

Repository: kdelibs

Description
The attached patch changes the KOpenWith dialog in KRun::displayOpenWithDialog from blocking Konqueror windows when a user clicks on OpenWith in the context menu or unknown file in the Dolphin part.

Diffs
kio/kio/krun.cpp ad5656e

Diff: <a href="https://git.reviewboard.kde.org/r/114473/diff/" title="https://git.reviewboard.kde.org/r/114473/diff/">https://git.reviewboard.kde.org/r/114473/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Re: Review Request 114473: Change modality of dialog in KRun::di

By Commit Hook at 02/12/2014 - 05:43

This review has been submitted with commit 6d99b077800b62c68370a1e916a64ffcbc2bb73d by Dawit Alemayehu to branch master.

- Commit Hook

On Dec. 22, 2013, 1:29 p.m., Dawit Alemayehu wrote:

Re: Review Request 114473: Change modality of dialog in KRun::di

By Commit Hook at 12/22/2013 - 09:29

This review has been submitted with commit f44119a6271aeb142de83753a02ec5cef0bf4ac8 by Dawit Alemayehu to branch KDE/4.12.

- Commit Hook

On Dec. 15, 2013, 1:31 p.m., Dawit Alemayehu wrote: