DevHeads.net

Review Request 114984: Fix build on MinGW with newer Windows SDK's strsafe.h

Review request for KDE Runtime and kdewin.

Repository: kde-runtime

Description
When building with MinGW new conflicts appeared when including strsafe before Qt headers (specially QString included from QBuffer). Also a new weird compiling error telling "'lstrcpy_instead_use_stringcbcopy_or_stringcchcopy' undeclared identifier" appeared, so I replaced lstrcpy with the equivalent use of StringCchCopy (http://msdn.microsoft.com/en-us/library/windows/desktop/ms647527(v=vs.85).aspx).

Diffs
kioslave/thumbnail/icoutils_win.cpp e223aa1

Diff: <a href="https://git.reviewboard.kde.org/r/114984/diff/" title="https://git.reviewboard.kde.org/r/114984/diff/">https://git.reviewboard.kde.org/r/114984/diff/</a>

Testing
Tested using MinGW, thumbnails still work fine. No errors when building with MSVC either.

Thanks,

Andrius da Costa Ribas

Comments

Re: Review Request 114984: Fix build on MinGW with newer Windows

By Andrius da Cost... at 04/04/2015 - 13:14

(Updated Abril 4, 2015, 6:14 p.m.)

Status
This change has been discarded.

Review request for KDE Runtime and kdewin.

Repository: kde-runtime

Description
When building with MinGW new conflicts appeared when including strsafe before Qt headers (specially QString included from QBuffer). Also a new weird compiling error telling "'lstrcpy_instead_use_stringcbcopy_or_stringcchcopy' undeclared identifier" appeared, so I replaced lstrcpy with the equivalent use of StringCchCopy (http://msdn.microsoft.com/en-us/library/windows/desktop/ms647527(v=vs.85).aspx).

Diffs
kioslave/thumbnail/icoutils_win.cpp e223aa1

Diff: <a href="https://git.reviewboard.kde.org/r/114984/diff/" title="https://git.reviewboard.kde.org/r/114984/diff/">https://git.reviewboard.kde.org/r/114984/diff/</a>

Testing
Tested using MinGW, thumbnails still work fine. No errors when building with MSVC either.

Thanks,

Andrius da Costa Ribas