DevHeads.net

Review Request 115408: Right align mime icon in kpropertiesdialog

Review request for kdelibs.

Repository: kdelibs

Description
The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.
Especially with bigger font sizes, the visual issue becomes obvious.

Idea: see kproperties-dolphin-1.png
Before: see before-1.png and before-2.png
After: see after-1.png and after-2.png

Diff for kio (frameworks) can be found here: <a href="http://pastebin.kde.org/p4ojv6a1w" title="http://pastebin.kde.org/p4ojv6a1w">http://pastebin.kde.org/p4ojv6a1w</a>

Diffs
kio/kfile/kpropertiesdialog.cpp 6611ee7

Diff: <a href="https://git.reviewboard.kde.org/r/115408/diff/" title="https://git.reviewboard.kde.org/r/115408/diff/">https://git.reviewboard.kde.org/r/115408/diff/</a>

Testing
Compiled and installed. Works as expected.

File Attachments
idea
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead...</a>
before1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2...</a>
before2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec...</a>
after1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f...</a>
after2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef...</a>

Thanks,

kdeuser56 kdeuser56

Comments

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 01/31/2014 - 16:47

(Updated Jan. 31, 2014, 8:47 p.m.)

Review request for kdelibs.

Repository: kdelibs

Description
The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.
Especially with bigger font sizes, the visual issue becomes obvious.

Idea: see kproperties-dolphin-1.png
Before: see before-1.png and before-2.png
After: see after-1.png and after-2.png

Diff for kio (frameworks) can be found here: <a href="http://pastebin.kde.org/p4ojv6a1w" title="http://pastebin.kde.org/p4ojv6a1w">http://pastebin.kde.org/p4ojv6a1w</a>

Diffs
kio/kfile/kpropertiesdialog.cpp 6611ee7

Diff: <a href="https://git.reviewboard.kde.org/r/115408/diff/" title="https://git.reviewboard.kde.org/r/115408/diff/">https://git.reviewboard.kde.org/r/115408/diff/</a>

Testing
Compiled and installed. Works as expected.

File Attachments (updated)
idea
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead...</a>
before1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2...</a>
before2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec...</a>
after1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f...</a>
after2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef...</a>
center-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637...</a>
left-left
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb...</a>
right-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290...</a>
right-right
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429...</a>

Thanks,

kdeuser56 kdeuser56

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 02/07/2014 - 15:07

(Updated Feb. 7, 2014, 7:07 p.m.)

Review request for kdelibs and Frank Reininghaus.

Repository: kdelibs

Description
The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.
Especially with bigger font sizes, the visual issue becomes obvious.

Idea: see kproperties-dolphin-1.png
Before: see before-1.png and before-2.png
After: see after-1.png and after-2.png

Diff for kio (frameworks) can be found here: <a href="http://pastebin.kde.org/p4ojv6a1w" title="http://pastebin.kde.org/p4ojv6a1w">http://pastebin.kde.org/p4ojv6a1w</a>

Diffs
kio/kfile/kpropertiesdialog.cpp 6611ee7

Diff: <a href="https://git.reviewboard.kde.org/r/115408/diff/" title="https://git.reviewboard.kde.org/r/115408/diff/">https://git.reviewboard.kde.org/r/115408/diff/</a>

Testing
Compiled and installed. Works as expected.

File Attachments
idea
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead...</a>
before1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2...</a>
before2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec...</a>
after1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f...</a>
after2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef...</a>
center-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637...</a>
left-left
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb...</a>
right-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290...</a>
right-right
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429...</a>

Thanks,

kdeuser56 kdeuser56

Re: Review Request 115408: Fix alignment for mime icon in kprope

By KDEUSER56 at 02/08/2014 - 06:02

(Updated Feb. 8, 2014, 10:02 a.m.)

Review request for kdelibs and Frank Reininghaus.

Changes
Corrected title and updated the Diff to center align the icon, as discussed with Thomas Lübking.

Summary (updated)
Fix alignment for mime icon in kpropertiesdialog

Repository: kdelibs

Description
The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.
Especially with bigger font sizes, the visual issue becomes obvious.

Idea: see kproperties-dolphin-1.png
Before: see before-1.png and before-2.png
After: see after-1.png and after-2.png

Diff for kio (frameworks) can be found here: <a href="http://pastebin.kde.org/p4ojv6a1w" title="http://pastebin.kde.org/p4ojv6a1w">http://pastebin.kde.org/p4ojv6a1w</a>

Diffs (updated)
kio/kfile/kpropertiesdialog.cpp 6611ee7

Diff: <a href="https://git.reviewboard.kde.org/r/115408/diff/" title="https://git.reviewboard.kde.org/r/115408/diff/">https://git.reviewboard.kde.org/r/115408/diff/</a>

Testing
Compiled and installed. Works as expected.

File Attachments
idea
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead...</a>
before1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2...</a>
before2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec...</a>
after1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f...</a>
after2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef...</a>
center-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637...</a>
left-left
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb...</a>
right-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290...</a>
right-right
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429...</a>

Thanks,

kdeuser56 kdeuser56

Re: Review Request 115408: Fix alignment for mime icon in kprope

By KDEUSER56 at 03/22/2014 - 07:28

(Updated March 22, 2014, 11:28 a.m.)

Status
This change has been marked as submitted.

Review request for kdelibs and Frank Reininghaus.

Repository: kdelibs

Description
The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.
Especially with bigger font sizes, the visual issue becomes obvious.

Idea: see kproperties-dolphin-1.png
Before: see before-1.png and before-2.png
After: see after-1.png and after-2.png

Diff for kio (frameworks) can be found here: <a href="http://pastebin.kde.org/p4ojv6a1w" title="http://pastebin.kde.org/p4ojv6a1w">http://pastebin.kde.org/p4ojv6a1w</a>

Diffs
kio/kfile/kpropertiesdialog.cpp 6611ee7

Diff: <a href="https://git.reviewboard.kde.org/r/115408/diff/" title="https://git.reviewboard.kde.org/r/115408/diff/">https://git.reviewboard.kde.org/r/115408/diff/</a>

Testing
Compiled and installed. Works as expected.

File Attachments
idea
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead...</a>
before1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2...</a>
before2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec...</a>
after1
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f...</a>
after2
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef...</a>
center-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637-e914-4521-a9c5-025515c97790__widget-center-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/ab93b637...</a>
left-left
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb-c411-4876-bebe-bc9923855751__widget-left-icon-leftunpatched.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/38cd56fb...</a>
right-center
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290-b6fb-4fe3-b2ab-5ea5f0c6ed53__widget-right-icon-center.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/80672290...</a>
right-right
<a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png" title="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429-021a-49a0-a34f-1a2e77d7aeef__widget-right-icon-right.png">https://git.reviewboard.kde.org/media/uploaded/files/2014/01/31/8dec5429...</a>

Thanks,

kdeuser56 kdeuser56

Re: Review Request 115408: Fix alignment for mime icon in kprope

By Commit Hook at 03/22/2014 - 07:28

This review has been submitted with commit b3ce5d67c15f022b949330eed75485d24a9f1c55 by David Faure on behalf of Helmut Horvath to branch master.

- Commit Hook

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By =?utf-8?Q?Thoma... at 02/08/2014 - 10:34

Ship it!

Here's my vote then.
Unless there's concern, push it "in some days™" (ie. tuesday or so, should leave enough time to cry out)

- Thomas Lübking

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By KDEUSER56 at 02/27/2014 - 10:30

@Thomas: Thank you I guess I will wait for that. I will check if the code in kio framework has changed since the creation of the diff that evening hopefully.

- kdeuser56

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By Frank Reininghaus at 02/18/2014 - 03:41

"Frank might want to push it before": To be honest, I'd prefer if you could ask someone else to do it. I do update and build a subset of Qt5+frameworks occasionally, but I only worked on a few low-level things so far, and I never built or used anything that could show a properties dialog. I don't feel comfortable pushing commits in code that I never worked with without testing first, and I will be unable to do it in the near future. Sorry about that.

- Frank

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By =?utf-8?Q?Thoma... at 02/17/2014 - 16:50

I'd have to setup a frameworks build first.
I'll push it then if that didn't happen otherwise, but Frank might want to push it before.

- Thomas

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By KDEUSER56 at 02/16/2014 - 06:36

Thomas: Would you mind shipping it for me?

- kdeuser56

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By KDEUSER56 at 02/08/2014 - 10:41

"push it" sounds like I should push it, however I can't do it, as I do not have a dev account. Could you push it for me?
Pushing in frameworks/kio would also be nice (diff can be found here: <a href="http://pastebin.kde.org/p7eahjnoq" title="http://pastebin.kde.org/p7eahjnoq">http://pastebin.kde.org/p7eahjnoq</a>)!

- kdeuser56

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By Kai Uwe Broulik at 02/01/2014 - 06:41

kio/kfile/kpropertiesdialog.cpp
<https://git.reviewboard.kde.org/r/115408/#comment34408>

It also helped a lot if the icon size adjusted to pixel density of the screen / font dpi

- Kai Uwe Broulik

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 02/01/2014 - 07:32

I would suggest you to try to commit your initial request here: <a href="https://git.reviewboard.kde.org/r/108442/" title="https://git.reviewboard.kde.org/r/108442/">https://git.reviewboard.kde.org/r/108442/</a>

- kdeuser56

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 02/01/2014 - 07:29

I am new to Qt programming, so please consider I cannot fix this. As I have not added this bit of code, I do not accept it being a issue of my modifications. If I find out how to adjust it to the screen dpi, I will fix that in another review request.

- kdeuser56

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By =?utf-8?Q?Thoma... at 01/30/2014 - 17:20

tried to center align it?

- Thomas Lübking

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Fix alignment for mime icon in kprope

By Frank Reininghaus at 02/08/2014 - 10:30

Dolphin may be one of the major users of the Properties dialog, but still, design and placement of stuff on the screen are not really my areas of expertise.

I agree that the current state is not optimal, and I appreciate that work is being done to improve it. However, I don't feel qualified to judge what's the best alternative. Sorry about that.

- Frank

On Feb. 8, 2014, 10:02 a.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By =?utf-8?Q?Thoma... at 02/07/2014 - 15:05

Ah, no - sorry (just git blame'd and didn't think =)

Please attach Frank Reininghaus instead (since dolphin is still likely the most important client code)

- Thomas

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 02/07/2014 - 14:55

Is he still active? (<a href="http://ppenz.blogspot.co.at/2012/06/dolphin-21.html" title="http://ppenz.blogspot.co.at/2012/06/dolphin-21.html">http://ppenz.blogspot.co.at/2012/06/dolphin-21.html</a>)

- kdeuser56

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By =?utf-8?Q?Thoma... at 02/07/2014 - 14:54

Yes, of course - but you're seeking approval of Peter Penz.

- Thomas

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 02/07/2014 - 14:43

Thomas: Will you ship it, if we agree to center align it? I think we can agree, that center is better than the current situation.

- kdeuser56

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 01/31/2014 - 16:47

Okay I have added screenshots (widget-<position>-icon<position>.png). Please provide feedback and I will change the review request according to that feedback.

- kdeuser56

On Jan. 31, 2014, 8:47 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By =?utf-8?Q?Thoma... at 01/30/2014 - 18:18

I'd suggest to have screenshots and wait for some more opinions then.

- Thomas

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By =?utf-8?Q?Thoma... at 01/30/2014 - 18:17

"Ugly" is subjective.
Fact is, that the vertical border creates a distinct border that the left aligned version is closer to than to the implicit right border, thus it's unbalanced (left overweight)
If you remove that border, the label visually moves more to the center between window frame and implicit right border (the lineedit), what implies local symmetry, thus stability. (Actually, you might even get a golden mean positioning)
Granted: for long texts and huge fonts the part left of the tab certainly becomes neglectable and that effect is lost.
-> I'd simply center align the icon.

- Thomas

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 01/30/2014 - 18:14

I would be okay with centering the iconlabel. Centering the widget too would be still better than left aligning, but I would prefer to keep it right.
Should I change the diff to center the iconlabel, or should I provide screenshots first?

- kdeuser56

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 01/30/2014 - 18:02

I am not sure I understand your point. Could explain me the "arbitrary" shape problem?
I do not think the visual problem is caused by the vertical tab border. Even if I remove that, it still looks bad and the bigger the font gets, the uglier it looks. (Some words are longer in other languages, so this could also be triggered by different language settings).
So in my opinion it looks bad, regardless of the theme.
Do you have another idea?

- kdeuser56

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By =?utf-8?Q?Thoma... at 01/30/2014 - 17:49

Either. Reason is that due to the "arbitrary" shape (shadow, padding), rightaligning the icon/button does not really line up with the text - thus looks buggy (failed approach)

Otoh, left alingning looks unbalanced mostly due to the vertical tab border (ie. it's less an issue in eg. bespin, which has no vertical tabborder)

- Thomas

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:

Re: Review Request 115408: Right align mime icon in kpropertiesd

By KDEUSER56 at 01/30/2014 - 17:23

Center what? The widget or the iconlabel? I think in case of the widget it makes no sense.
In case of the iconlabel the icon itself would be on the exact same position as the icon of the icon button.
I tried both, but I find right aligned prettier and more logical considering the text under it.

- kdeuser56

On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: