DevHeads.net

Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open

Review request for KDE Runtime, kde-workspace and Plasma.

Repository: kde-runtime

Description
Given that in 4.13 we want people to use pam to open the wallet it
makes little sense to execute the wallet automatically.

Other commits changing the default have been pushed to kwallet and
kwalletmanager

Diffs
kwalletd/CMakeLists.txt 9c5ca92
kwalletd/kwallet-4.13.upd PRE-CREATION

Diff: <a href="https://git.reviewboard.kde.org/r/115726/diff/" title="https://git.reviewboard.kde.org/r/115726/diff/">https://git.reviewboard.kde.org/r/115726/diff/</a>

Testing

Thanks,

Àlex Fiestas

Comments

Re: Review Request 115726: Deafult for not executing kwalletmana

By Alex Fiestas at 02/13/2014 - 13:13

(Updated Feb. 13, 2014, 5:13 p.m.)

Review request for KDE Runtime, kde-workspace and Plasma.

Repository: kde-runtime

Description (updated)
Given that in 4.13 we want people to use pam to open the wallet it
makes little sense to execute the wallet automatically.

Other commits changing the default have been pushed to kwallet and
kwalletmanager

This review goes together with:
<a href="https://git.reviewboard.kde.org/r/115727/" title="https://git.reviewboard.kde.org/r/115727/">https://git.reviewboard.kde.org/r/115727/</a>
<a href="https://git.reviewboard.kde.org/r/115728/" title="https://git.reviewboard.kde.org/r/115728/">https://git.reviewboard.kde.org/r/115728/</a>

Diffs
kwalletd/CMakeLists.txt 9c5ca92
kwalletd/kwallet-4.13.upd PRE-CREATION

Diff: <a href="https://git.reviewboard.kde.org/r/115726/diff/" title="https://git.reviewboard.kde.org/r/115726/diff/">https://git.reviewboard.kde.org/r/115726/diff/</a>

Testing

Thanks,

Àlex Fiestas

Re: Review Request 115726: Deafult for not executing kwalletmana

By Alex Fiestas at 02/17/2014 - 12:12

(Updated Feb. 17, 2014, 4:12 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Runtime, kde-workspace and Plasma.

Repository: kde-runtime

Description
Given that in 4.13 we want people to use pam to open the wallet it
makes little sense to execute the wallet automatically.

Other commits changing the default have been pushed to kwallet and
kwalletmanager

This review goes together with:
<a href="https://git.reviewboard.kde.org/r/115727/" title="https://git.reviewboard.kde.org/r/115727/">https://git.reviewboard.kde.org/r/115727/</a>
<a href="https://git.reviewboard.kde.org/r/115728/" title="https://git.reviewboard.kde.org/r/115728/">https://git.reviewboard.kde.org/r/115728/</a>

Diffs
kwalletd/CMakeLists.txt 9c5ca92
kwalletd/kwallet-4.13.upd PRE-CREATION

Diff: <a href="https://git.reviewboard.kde.org/r/115726/diff/" title="https://git.reviewboard.kde.org/r/115726/diff/">https://git.reviewboard.kde.org/r/115726/diff/</a>

Testing

Thanks,

Àlex Fiestas

Re: Review Request 115726: Deafult for not executing kwalletmana

By Commit Hook at 02/17/2014 - 12:12

This review has been submitted with commit aa0a7429df3a8ebbae289e3fe203363f3020cbc6 by Àlex Fiestas to branch master.

- Commit Hook

On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:

Re: Review Request 115726: Deafult for not executing kwalletmana

By david at 02/17/2014 - 12:09

Ship it!

- David Edmundson

On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote: