DevHeads.net

Review Request 115964: Oxygen: avoid calls to reparseConfiguration() on startup.

Review request for kde-workspace and Hugo Pereira Da Costa.

Repository: kde-workspace

Description
Oxygen: avoid calls to reparseConfiguration() on startup.

strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l
went from 8 to 4
(and when looking for kdeglobals, from 13 to 11)

There's still a lot of work to be done in that area...
(within KConfigSkeleton, and probably kdeplatformtheme)

Diffs
kstyles/oxygen/oxygenshadowhelper.h 066edd3292f390401691a9d6e5182e9dc6d24133
kstyles/oxygen/oxygenshadowhelper.cpp b3f3d0c876067292a72647e9fcda07cbbf4ba4b0
kstyles/oxygen/oxygenstyle.h 35323b4578eb9aa0d1efcc5901bab80fadea64f3
kstyles/oxygen/oxygenstyle.cpp f6ff24ad515003ad031c80665935e6d113b5a1e5
kstyles/oxygen/oxygenstylehelper.h 57b86c7ed540364040e87a8464299db17c460647
kstyles/oxygen/oxygenstylehelper.cpp f2af4172c5beb8b8c3bb0d75b5eb351dc710289e
kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp 9e1481cab4cca2961b48c791e72d925ae4a83d05
kwin/clients/oxygen/oxygendecohelper.h 4c9a44ab54edec7bdc428f33e580efc60efdf235
kwin/clients/oxygen/oxygendecohelper.cpp e6bbcbf9df7eee3188c84cd74f0e32b7cfd162d3
kwin/clients/oxygen/oxygenfactory.h 9ed90ec1567ed537a3524b2d4a507a3471341a64
kwin/clients/oxygen/oxygenfactory.cpp 6d5b08b9160a7794f668feb2914450b602360ce6
libs/oxygen/oxygenhelper.h ee381a74320da172e834550f61ef214377870bfc
libs/oxygen/oxygenhelper.cpp cd6562b411fdb1bce6d0c740a4b38dae33218324

Diff: <a href="https://git.reviewboard.kde.org/r/115964/diff/" title="https://git.reviewboard.kde.org/r/115964/diff/">https://git.reviewboard.kde.org/r/115964/diff/</a>

Testing

Thanks,

David Faure

Comments

Re: Review Request 115964: Oxygen: avoid calls to reparseConfigu

By David Faure at 02/25/2014 - 07:02

(Updated Feb. 25, 2014, 12:02 p.m.)

Review request for kde-workspace and Hugo Pereira Da Costa.

Changes
add dep

Repository: kde-workspace

Description
Oxygen: avoid calls to reparseConfiguration() on startup.

strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l
went from 8 to 4
(and when looking for kdeglobals, from 13 to 11)

There's still a lot of work to be done in that area...
(within KConfigSkeleton, and probably kdeplatformtheme)

Diffs
kstyles/oxygen/oxygenshadowhelper.h 066edd3292f390401691a9d6e5182e9dc6d24133
kstyles/oxygen/oxygenshadowhelper.cpp b3f3d0c876067292a72647e9fcda07cbbf4ba4b0
kstyles/oxygen/oxygenstyle.h 35323b4578eb9aa0d1efcc5901bab80fadea64f3
kstyles/oxygen/oxygenstyle.cpp f6ff24ad515003ad031c80665935e6d113b5a1e5
kstyles/oxygen/oxygenstylehelper.h 57b86c7ed540364040e87a8464299db17c460647
kstyles/oxygen/oxygenstylehelper.cpp f2af4172c5beb8b8c3bb0d75b5eb351dc710289e
kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp 9e1481cab4cca2961b48c791e72d925ae4a83d05
kwin/clients/oxygen/oxygendecohelper.h 4c9a44ab54edec7bdc428f33e580efc60efdf235
kwin/clients/oxygen/oxygendecohelper.cpp e6bbcbf9df7eee3188c84cd74f0e32b7cfd162d3
kwin/clients/oxygen/oxygenfactory.h 9ed90ec1567ed537a3524b2d4a507a3471341a64
kwin/clients/oxygen/oxygenfactory.cpp 6d5b08b9160a7794f668feb2914450b602360ce6
libs/oxygen/oxygenhelper.h ee381a74320da172e834550f61ef214377870bfc
libs/oxygen/oxygenhelper.cpp cd6562b411fdb1bce6d0c740a4b38dae33218324

Diff: <a href="https://git.reviewboard.kde.org/r/115964/diff/" title="https://git.reviewboard.kde.org/r/115964/diff/">https://git.reviewboard.kde.org/r/115964/diff/</a>

Testing

Thanks,

David Faure

Re: Review Request 115964: Oxygen: avoid calls to reparseConfigu

By David Faure at 02/27/2014 - 15:12

(Updated Feb. 27, 2014, 8:12 p.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace and Hugo Pereira Da Costa.

Repository: kde-workspace

Description
Oxygen: avoid calls to reparseConfiguration() on startup.

strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l
went from 8 to 4
(and when looking for kdeglobals, from 13 to 11)

There's still a lot of work to be done in that area...
(within KConfigSkeleton, and probably kdeplatformtheme)

Diffs
kstyles/oxygen/oxygenshadowhelper.h 066edd3292f390401691a9d6e5182e9dc6d24133
kstyles/oxygen/oxygenshadowhelper.cpp b3f3d0c876067292a72647e9fcda07cbbf4ba4b0
kstyles/oxygen/oxygenstyle.h 35323b4578eb9aa0d1efcc5901bab80fadea64f3
kstyles/oxygen/oxygenstyle.cpp f6ff24ad515003ad031c80665935e6d113b5a1e5
kstyles/oxygen/oxygenstylehelper.h 57b86c7ed540364040e87a8464299db17c460647
kstyles/oxygen/oxygenstylehelper.cpp f2af4172c5beb8b8c3bb0d75b5eb351dc710289e
kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp 9e1481cab4cca2961b48c791e72d925ae4a83d05
kwin/clients/oxygen/oxygendecohelper.h 4c9a44ab54edec7bdc428f33e580efc60efdf235
kwin/clients/oxygen/oxygendecohelper.cpp e6bbcbf9df7eee3188c84cd74f0e32b7cfd162d3
kwin/clients/oxygen/oxygenfactory.h 9ed90ec1567ed537a3524b2d4a507a3471341a64
kwin/clients/oxygen/oxygenfactory.cpp 6d5b08b9160a7794f668feb2914450b602360ce6
libs/oxygen/oxygenhelper.h ee381a74320da172e834550f61ef214377870bfc
libs/oxygen/oxygenhelper.cpp cd6562b411fdb1bce6d0c740a4b38dae33218324

Diff: <a href="https://git.reviewboard.kde.org/r/115964/diff/" title="https://git.reviewboard.kde.org/r/115964/diff/">https://git.reviewboard.kde.org/r/115964/diff/</a>

Testing

Thanks,

David Faure

Re: Review Request 115964: Oxygen: avoid calls to reparseConfigu

By Commit Hook at 02/27/2014 - 15:12

This review has been submitted with commit 2a9b5a2f4fb3bcdfae6cad53f93bfe5c8db48d95 by David Faure to branch master.

- Commit Hook

On Feb. 25, 2014, 12:02 p.m., David Faure wrote:

Re: Review Request 115964: Oxygen: avoid calls to reparseConfigu

By Hugo Pereira Da... at 02/25/2014 - 08:00

Ship it!

code is good and works well. Thanks !

- Hugo Pereira Da Costa

On Feb. 25, 2014, 12:02 p.m., David Faure wrote:

Re: Review Request 115964: Oxygen: avoid calls to reparseConfigu

By Hugo Pereira Da... at 02/25/2014 - 06:03

Right now, I'm not able to compile, due to:

home/hpereira/kf5/src/kde-workspace/kstyles/oxygen/oxygenstyle.cpp: In constructor ‘Oxygen::Style::Style()’:
/home/hpereira/kf5/src/kde-workspace/kstyles/oxygen/oxygenstyle.cpp:193:60: error: ‘class Oxygen::StyleConfigData’ has no member named ‘sharedConfig’
_helper( new StyleHelper( StyleConfigData::self()->sharedConfig() ) ),

Does this review depend on some pending changes in kconfig ?

- Hugo Pereira Da Costa

On Feb. 23, 2014, 12:08 p.m., David Faure wrote:

Re: Review Request 115964: Oxygen: avoid calls to reparseConfigu

By David Faure at 02/25/2014 - 07:02

right, should have mentionned it, sorry: it depends on <a href="https://git.reviewboard.kde.org/r/115960/" title="https://git.reviewboard.kde.org/r/115960/">https://git.reviewboard.kde.org/r/115960/</a>

- David

On Feb. 23, 2014, 12:08 p.m., David Faure wrote: