DevHeads.net

Review Request 118180: slideshow BUG patch fix

Review request for kde-workspace.

Bugs: <a href="https://bugs.kde.org/show_bug.cgi?id=327580" title="https://bugs.kde.org/show_bug.cgi?id=327580">https://bugs.kde.org/show_bug.cgi?id=327580</a>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id...</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Comments

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 06/03/2014 - 01:58

(Updated June 3, 2014, 5:58 a.m.)

Review request for kde-workspace.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 06/05/2014 - 06:32

(Updated June 5, 2014, 10:32 a.m.)

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/21/2014 - 09:12

(Updated 七月 21, 2014, 1:12 p.m.)

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs (updated)
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 05:43

(Updated July 29, 2014, 9:43 a.m.)

Status
This change has been discarded.

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 06:04

(Updated 七月 29, 2014, 10:04 a.m.)

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs (updated)
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 06:05

(Updated 七月 29, 2014, 10:05 a.m.)

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing (updated)
I will fix it soon.
something wrong with the patch.

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 10:15

(Updated 七月 29, 2014, 2:15 p.m.)

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing (updated)

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 11:19

(Updated 七月 29, 2014, 3:19 p.m.)

Status
This change has been discarded.

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 11:24

(Updated July 29, 2014, 3:24 p.m.)

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs (updated)
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 08/20/2014 - 15:13

(Updated Aug. 20, 2014, 7:13 p.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace and Plasma.

Bugs: 327580
<a href="http://bugs.kde.org/show_bug.cgi?id=327580" title="http://bugs.kde.org/show_bug.cgi?id=327580">http://bugs.kde.org/show_bug.cgi?id=327580</a>

Repository: kde-workspace

Description
bug patch for slideshow dir list missing

Diffs
libs/plasmagenericshell/backgrounddialog.cpp 645de3f

Diff: <a href="https://git.reviewboard.kde.org/r/118180/diff/" title="https://git.reviewboard.kde.org/r/118180/diff/">https://git.reviewboard.kde.org/r/118180/diff/</a>

Testing

Thanks,

TOM Harrison

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/29/2014 - 11:27

weird issue when using reviewboard with the chrome. that why the diff are always error.....
I have upload successfully with the newest fixed patch

- TOM Harrison

On July 29, 2014, 3:24 p.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By david at 07/29/2014 - 05:44

Reviewboard wasn't showing the patch, not sure why. We can't do much without it. Sorry.

- David Edmundson

On July 29, 2014, 9:43 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By Marco Martin at 07/21/2014 - 12:43

seems the patch doesn't apply anymore, at least reviewboard complains about it

- Marco Martin

On Lug. 21, 2014, 1:12 p.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By Marco Martin at 07/21/2014 - 09:08

modulo the indentation, it should be ok

- Marco Martin

On Giu. 5, 2014, 10:32 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By Martin =?ISO-88... at 07/21/2014 - 08:39

libs/plasmagenericshell/backgrounddialog.cpp
<https://git.reviewboard.kde.org/r/118180/#comment43523>

here the coding style looks wrong

- Martin Gräßlin

On June 5, 2014, 12:32 p.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/21/2014 - 09:07

OK, I have fix in the patch. I will upload later, if it could detect as a patch......

- TOM

On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By Sebastian =?utf... at 07/21/2014 - 09:02

Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that.

- Sebastian

On June 5, 2014, 10:32 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/21/2014 - 08:59

what kind of issue? tab and space different ?

- TOM

On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By Christoph Feck at 06/05/2014 - 06:12

Please add Plasma developers to the group of reviewers.

Btw, you cannot give "Ship It" to yourself, others have to approve it.

- Christoph Feck

On June 3, 2014, 5:58 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 07/21/2014 - 08:30

I am still waiting the plasma reviewer to approve :(, though I am using this path already.

- TOM

On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By Christoph Feck at 07/21/2014 - 08:14

I guess nobody looked at it yet because in the list it appears as "already approved". I will ping plasma developers.

- Christoph

On June 5, 2014, 10:32 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 06/05/2014 - 06:31

thanks for reminding for the missing reviewers.

- TOM

On June 3, 2014, 5:58 a.m., TOM Harrison wrote:

Re: Review Request 118180: slideshow BUG patch fix

By TOM Harrison at 06/05/2014 - 06:30

that just a wrong click :)

- TOM

On June 3, 2014, 5:58 a.m., TOM Harrison wrote: