DevHeads.net

Review Request 118313: [Konqlib] KUrl -> QUrl

Review request for KDE Base Apps, KDE Frameworks and David Faure.

Repository: kde-baseapps

Description
Ported Konqlib from KUrl to QUrl (convert-kurl.pl)

Still some ToDos left in the code (I'll mark it inline)

Diffs
lib/konq/favicons/favicons.h 30f0272
lib/konq/favicons/favicons.cpp 4646fa5
lib/konq/konq_copytomenu.h 0958e20
lib/konq/konq_copytomenu.cpp 7ee5131
lib/konq/konq_copytomenu_p.h eb6649a
lib/konq/konq_dndpopupmenuplugin.h 2417080
lib/konq/konq_historyentry.h 6b33b98
lib/konq/konq_historyentry.cpp bfc4a5d
lib/konq/konq_historyprovider.h 91b5b87
lib/konq/konq_historyprovider.cpp 10a5e74
lib/konq/konq_nameandurlinputdialog.h 3a943f7
lib/konq/konq_nameandurlinputdialog.cpp 2fb06f9
lib/konq/konq_operations.h b51fa3f
lib/konq/konq_operations.cpp 0cbff08
lib/konq/konq_popupmenu.h b5f5e39
lib/konq/konq_popupmenu.cpp caa37e7
lib/konq/konq_popupmenuinformation.h 1454073
lib/konq/konq_popupmenuinformation.cpp 6e1033b
lib/konq/konq_sound.h 8063073
lib/konq/konq_sound.cc f8a80a9
lib/konq/konqmimedata.h a2640a2
lib/konq/konqmimedata.cpp 8f9ecf1
lib/konq/tests/favicontest.cpp d48b03d
lib/konq/tests/konqmimedatatest.cpp 6a2be4f
lib/konq/tests/konqpopupmenutest.cpp 46851c5

Diff: <a href="https://git.reviewboard.kde.org/r/118313/diff/" title="https://git.reviewboard.kde.org/r/118313/diff/">https://git.reviewboard.kde.org/r/118313/diff/</a>

Testing
Tests fail

konqmimedatatest: (todos)
FAIL! : KonqMimeDataTest::testPopulate() 'mimeData->hasUrls()' returned FALSE.
FAIL! : KonqMimeDataTest::testCut() 'mimeData->hasUrls()' returned FALSE.

konqpopupmenutest: (local setup problem maybe?!)
QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()

favicontest: (local setup problem maybe?!)
QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()

Thanks,

Emmanuel Pescosta

Comments

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

By Emmanuel Pescosta at 06/17/2014 - 12:00

(Updated June 17, 2014, 4 p.m.)

Review request for KDE Base Apps and David Faure.

Repository: kde-baseapps

Description
Ported Konqlib from KUrl to QUrl (convert-kurl.pl)

Still some ToDos left in the code (I'll mark it inline)

Diffs
lib/konq/favicons/favicons.h 30f0272
lib/konq/favicons/favicons.cpp 4646fa5
lib/konq/konq_copytomenu.h 0958e20
lib/konq/konq_copytomenu.cpp 7ee5131
lib/konq/konq_copytomenu_p.h eb6649a
lib/konq/konq_dndpopupmenuplugin.h 2417080
lib/konq/konq_historyentry.h 6b33b98
lib/konq/konq_historyentry.cpp bfc4a5d
lib/konq/konq_historyprovider.h 91b5b87
lib/konq/konq_historyprovider.cpp 10a5e74
lib/konq/konq_nameandurlinputdialog.h 3a943f7
lib/konq/konq_nameandurlinputdialog.cpp 2fb06f9
lib/konq/konq_operations.h b51fa3f
lib/konq/konq_operations.cpp 0cbff08
lib/konq/konq_popupmenu.h b5f5e39
lib/konq/konq_popupmenu.cpp caa37e7
lib/konq/konq_popupmenuinformation.h 1454073
lib/konq/konq_popupmenuinformation.cpp 6e1033b
lib/konq/konq_sound.h 8063073
lib/konq/konq_sound.cc f8a80a9
lib/konq/konqmimedata.h a2640a2
lib/konq/konqmimedata.cpp 8f9ecf1
lib/konq/tests/favicontest.cpp d48b03d
lib/konq/tests/konqmimedatatest.cpp 6a2be4f
lib/konq/tests/konqpopupmenutest.cpp 46851c5

Diff: <a href="https://git.reviewboard.kde.org/r/118313/diff/" title="https://git.reviewboard.kde.org/r/118313/diff/">https://git.reviewboard.kde.org/r/118313/diff/</a>

Testing
Tests fail

konqmimedatatest: (todos)
FAIL! : KonqMimeDataTest::testPopulate() 'mimeData->hasUrls()' returned FALSE.
FAIL! : KonqMimeDataTest::testCut() 'mimeData->hasUrls()' returned FALSE.

konqpopupmenutest: (local setup problem maybe?!)
QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()

favicontest: (local setup problem maybe?!)
QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()

Thanks,

Emmanuel Pescosta

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

By Emmanuel Pescosta at 10/19/2014 - 06:57

(Updated Oct. 19, 2014, 12:57 p.m.)

Status
This change has been discarded.

Review request for KDE Base Apps and David Faure.

Repository: kde-baseapps

Description
Ported Konqlib from KUrl to QUrl (convert-kurl.pl)

Still some ToDos left in the code (I'll mark it inline)

Diffs
lib/konq/favicons/favicons.h 30f0272
lib/konq/favicons/favicons.cpp 4646fa5
lib/konq/konq_copytomenu.h 0958e20
lib/konq/konq_copytomenu.cpp 7ee5131
lib/konq/konq_copytomenu_p.h eb6649a
lib/konq/konq_dndpopupmenuplugin.h 2417080
lib/konq/konq_historyentry.h 6b33b98
lib/konq/konq_historyentry.cpp bfc4a5d
lib/konq/konq_historyprovider.h 91b5b87
lib/konq/konq_historyprovider.cpp 10a5e74
lib/konq/konq_nameandurlinputdialog.h 3a943f7
lib/konq/konq_nameandurlinputdialog.cpp 2fb06f9
lib/konq/konq_operations.h b51fa3f
lib/konq/konq_operations.cpp 0cbff08
lib/konq/konq_popupmenu.h b5f5e39
lib/konq/konq_popupmenu.cpp caa37e7
lib/konq/konq_popupmenuinformation.h 1454073
lib/konq/konq_popupmenuinformation.cpp 6e1033b
lib/konq/konq_sound.h 8063073
lib/konq/konq_sound.cc f8a80a9
lib/konq/konqmimedata.h a2640a2
lib/konq/konqmimedata.cpp 8f9ecf1
lib/konq/tests/favicontest.cpp d48b03d
lib/konq/tests/konqmimedatatest.cpp 6a2be4f
lib/konq/tests/konqpopupmenutest.cpp 46851c5

Diff: <a href="https://git.reviewboard.kde.org/r/118313/diff/" title="https://git.reviewboard.kde.org/r/118313/diff/">https://git.reviewboard.kde.org/r/118313/diff/</a>

Testing
Tests fail

konqmimedatatest: (todos)
FAIL! : KonqMimeDataTest::testPopulate() 'mimeData->hasUrls()' returned FALSE.
FAIL! : KonqMimeDataTest::testCut() 'mimeData->hasUrls()' returned FALSE.

konqpopupmenutest: (local setup problem maybe?!)
QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()

favicontest: (local setup problem maybe?!)
QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()

Thanks,

Emmanuel Pescosta

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

By David Faure at 10/19/2014 - 05:09

Obsoleted by <a href="https://git.reviewboard.kde.org/r/120650/" title="https://git.reviewboard.kde.org/r/120650/">https://git.reviewboard.kde.org/r/120650/</a> (and by changes made meanwhile in libkonq).

Sorry about this - between the todos, the unittest failures, and the evolving underlying code base, this fell through.

- David Faure

On June 17, 2014, 4 p.m., Emmanuel Pescosta wrote:

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

By Emmanuel Pescosta at 05/25/2014 - 09:31

lib/konq/konq_popupmenu.cpp
<https://git.reviewboard.kde.org/r/118313/#comment40624>

KUrl::cleanPath() -> QUrl::???

lib/konq/konq_popupmenu.cpp
<https://git.reviewboard.kde.org/r/118313/#comment40625>

KUrl::cleanPath() -> QUrl::???

lib/konq/konqmimedata.cpp
<https://git.reviewboard.kde.org/r/118313/#comment40626>

Is "mimeData->setUrls(kdeUrls);" correct?

lib/konq/konqmimedata.cpp
<https://git.reviewboard.kde.org/r/118313/#comment40627>

Is "mimeData->setUrls(mostLocalURLs);" correct?

- Emmanuel Pescosta

On May 25, 2014, 3:27 p.m., Emmanuel Pescosta wrote:

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

By David Faure at 05/27/2014 - 03:42

This is documented in kurl.h :

url.setPath(QDir::cleanPath(url.path()))

(with some caveats, but that's the best we can do I think)

Documented in kurl.h too (in the documentation for populateMimeData)

* @deprecated since 5.0, use QMimeData::setUrls, followed by KUrlMimeData::setMetaData if you have metadata.

- David

On May 25, 2014, 1:27 p.m., Emmanuel Pescosta wrote: