DevHeads.net

Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

Review request for KDE Base Apps and David Faure.

Bugs: 320500
<a href="http://bugs.kde.org/show_bug.cgi?id=320500" title="http://bugs.kde.org/show_bug.cgi?id=320500">http://bugs.kde.org/show_bug.cgi?id=320500</a>

Repository: kde-baseapps

Description
The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox.

Diffs
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e

Diff: <a href="https://git.reviewboard.kde.org/r/118749/diff/" title="https://git.reviewboard.kde.org/r/118749/diff/">https://git.reviewboard.kde.org/r/118749/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Comments

Re: Review Request 118749: Prevent crashes caused by invalid acc

By Dawit A at 06/15/2014 - 22:48

(Updated June 16, 2014, 3:48 a.m.)

Review request for KDE Base Apps and David Faure.

Changes
Updated patch based on review.

Bugs: 320500
<a href="http://bugs.kde.org/show_bug.cgi?id=320500" title="http://bugs.kde.org/show_bug.cgi?id=320500">http://bugs.kde.org/show_bug.cgi?id=320500</a>

Repository: kde-baseapps

Description
The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox.

Diffs (updated)
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e

Diff: <a href="https://git.reviewboard.kde.org/r/118749/diff/" title="https://git.reviewboard.kde.org/r/118749/diff/">https://git.reviewboard.kde.org/r/118749/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Re: Review Request 118749: Prevent crashes caused by invalid acc

By Dawit A at 06/15/2014 - 22:50

(Updated June 16, 2014, 3:50 a.m.)

Status
This change has been marked as submitted.

Review request for KDE Base Apps and David Faure.

Bugs: 320500
<a href="http://bugs.kde.org/show_bug.cgi?id=320500" title="http://bugs.kde.org/show_bug.cgi?id=320500">http://bugs.kde.org/show_bug.cgi?id=320500</a>

Repository: kde-baseapps

Description
The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox.

Diffs
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e

Diff: <a href="https://git.reviewboard.kde.org/r/118749/diff/" title="https://git.reviewboard.kde.org/r/118749/diff/">https://git.reviewboard.kde.org/r/118749/diff/</a>

Testing

Thanks,

Dawit Alemayehu

Re: Review Request 118749: Prevent crashes caused by invalid acc

By Commit Hook at 06/15/2014 - 22:50

This review has been submitted with commit 1e171b4230886c7c3287d8de7df7f75444b1356c by Dawit Alemayehu to branch KDE/4.13.

- Commit Hook

On June 16, 2014, 3:48 a.m., Dawit Alemayehu wrote:

Re: Review Request 118749: Prevent crashes caused by invalid acc

By David Faure at 06/15/2014 - 17:08

Ship it!

Looks good, except for one error....

konqueror/src/konqmainwindow.cpp
<https://git.reviewboard.kde.org/r/118749/#comment41903>

no, this should be mainWindow->comboEdit()

- David Faure

On June 14, 2014, 11:01 p.m., Dawit Alemayehu wrote: