DevHeads.net

Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.

Repository: kde-baseapps

Description
I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
If there is a better way, please let me know.

Diffs
CMakeLists.txt a5588ea
dolphin/src/CMakeLists.txt ce629fb
lib/konq/CMakeLists.txt 6857e19

Diff: <a href="https://git.reviewboard.kde.org/r/118851/diff/" title="https://git.reviewboard.kde.org/r/118851/diff/">https://git.reviewboard.kde.org/r/118851/diff/</a>

Testing
Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
libdolphinprivate.so
libdolphinprivate.so.4.97.0
libdolphinprivate.so.5
libkdeinit5_dolphin.so
libkonq.so
libkonq.so.4.97.0
libkonq.so.5

Thanks,

Scarlett Clark

Comments

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Scarlett Clark at 06/20/2014 - 13:44

(Updated June 20, 2014, 11:44 a.m.)

Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.

Changes
Implemented suggested changes, still builds with expected results.

Repository: kde-baseapps

Description
I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
If there is a better way, please let me know.

Diffs (updated)
CMakeLists.txt a5588ea
dolphin/src/CMakeLists.txt ce629fb
lib/konq/CMakeLists.txt 6857e19

Diff: <a href="https://git.reviewboard.kde.org/r/118851/diff/" title="https://git.reviewboard.kde.org/r/118851/diff/">https://git.reviewboard.kde.org/r/118851/diff/</a>

Testing
Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
libdolphinprivate.so
libdolphinprivate.so.4.97.0
libdolphinprivate.so.5
libkdeinit5_dolphin.so
libkonq.so
libkonq.so.4.97.0
libkonq.so.5

Thanks,

Scarlett Clark

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Scarlett Clark at 06/20/2014 - 15:14

(Updated June 20, 2014, 1:14 p.m.)

Status
This change has been marked as submitted.

Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.

Repository: kde-baseapps

Description
I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
If there is a better way, please let me know.

Diffs
CMakeLists.txt a5588ea
dolphin/src/CMakeLists.txt ce629fb
lib/konq/CMakeLists.txt 6857e19

Diff: <a href="https://git.reviewboard.kde.org/r/118851/diff/" title="https://git.reviewboard.kde.org/r/118851/diff/">https://git.reviewboard.kde.org/r/118851/diff/</a>

Testing
Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
libdolphinprivate.so
libdolphinprivate.so.4.97.0
libdolphinprivate.so.5
libkdeinit5_dolphin.so
libkonq.so
libkonq.so.4.97.0
libkonq.so.5

Thanks,

Scarlett Clark

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Raymond Wooninck at 06/23/2014 - 04:16

Hmm, now we seem to have a strange situation between KDE4 and KF5/PN.

The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with libkonq.so.5 pointing to it.

With this change libkonq has a lower version (4.97.0; libkonq.so.4.97.0) with libkonq.so.5 pointing to it.

This would mean that libkonq is no longer co-installable with its KDE4 version due to both using libkonq.so.5. Given that there must have been a reason in the past to use libkonq.so.5.14.0, I would suggest to move libkonq version to 5.97.0 and use libkonq.so.6. This would ensure co-instability and consistency in version numbering.

- Raymond Wooninck

On June 20, 2014, 8:14 p.m., Scarlett Clark wrote:

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Jonathan Riddell at 06/23/2014 - 05:40

pushed a change to set it to 6.0.0

- Jonathan

On June 20, 2014, 8:14 p.m., Scarlett Clark wrote:

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Christoph Feck at 06/23/2014 - 05:09

Another idea is to rename the library to KF5 naming conventions. Maybe even drop the "konq" name, and use something which better describes it.

- Christoph

On June 20, 2014, 8:14 p.m., Scarlett Clark wrote:

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Alex Merry at 06/20/2014 - 14:30

Ship it!

Ship It!

- Alex Merry

On June 20, 2014, 6:44 p.m., Scarlett Clark wrote:

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Alex Merry at 06/20/2014 - 14:02

CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42292>

But now you'll want to put an actual version number in here (or remove the variable use altogether).

- Alex Merry

On June 20, 2014, 6:44 p.m., Scarlett Clark wrote:

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Scarlett Clark at 06/20/2014 - 14:06

I removed it all together, builds fine without it. thanks!

- Scarlett

On June 20, 2014, 11:44 a.m., Scarlett Clark wrote:

Re: Review Request 118851: Kde-baseapps- KF5 replace generic sov

By Alex Merry at 06/20/2014 - 13:17

CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42289>

This is not part of kf5, so shouldn't use KF5_VERSION. Instead, you may want a KDE_BASEAPPS_VERSION or something. This does not have to be at all related to the version of KF5 required.

CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42291>

This should probably move to the lib/konq/CMakeLists.txt file.

CMakeLists.txt
<https://git.reviewboard.kde.org/r/118851/#comment42290>

This should probably move the the dolphin/src/CMakeLists.txt file

- Alex Merry

On June 20, 2014, 5:53 p.m., Scarlett Clark wrote: