DevHeads.net

Review Request 119446: Add a simple test for meinproc

Review request for Documentation, KDE Frameworks and kdelibs.

Repository: kdelibs

Description
The summary says it all. Simple meinproc call with the example template.

I propose this change for KDE/4.14 too, and it will be forward-ported to KDocTools/KF5.

Diffs
kdoctools/CMakeLists.txt 4dc6d8a
kdoctools/tests/CMakeLists.txt PRE-CREATION

Diff: <a href="https://git.reviewboard.kde.org/r/119446/diff/" title="https://git.reviewboard.kde.org/r/119446/diff/">https://git.reviewboard.kde.org/r/119446/diff/</a>

Testing
Compilation of kdelibs and few modules with documentation.

Thanks,

Luigi Toscano

Comments

Re: Review Request 119446: Add a simple test for meinproc

By Albert Astals Cid at 07/24/2014 - 17:42

Ship it!

Please ship after removing the two unneeded lines?

kdoctools/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119446/#comment43850>

These two lines don't seem needed

- Albert Astals Cid

On jul. 24, 2014, 12:06 a.m., Luigi Toscano wrote:

Re: Review Request 119446: Add a simple test for meinproc

By Luigi Toscano at 07/24/2014 - 19:20

(Updated Lug. 25, 2014, 1:20 a.m.)

Review request for Documentation, KDE Frameworks and kdelibs.

Changes
Extra lines (needed for future tests but not now) removed.

Repository: kdelibs

Description
The summary says it all. Simple meinproc call with the example template.

I propose this change for KDE/4.14 too, and it will be forward-ported to KDocTools/KF5.

Diffs (updated)
kdoctools/CMakeLists.txt 4dc6d8a
kdoctools/tests/CMakeLists.txt PRE-CREATION

Diff: <a href="https://git.reviewboard.kde.org/r/119446/diff/" title="https://git.reviewboard.kde.org/r/119446/diff/">https://git.reviewboard.kde.org/r/119446/diff/</a>

Testing
Compilation of kdelibs and few modules with documentation.

Thanks,

Luigi Toscano

Re: Review Request 119446: Add a simple test for meinproc

By Luigi Toscano at 07/24/2014 - 19:42

(Updated July 24, 2014, 11:42 p.m.)

Status
This change has been marked as submitted.

Review request for Documentation, KDE Frameworks and kdelibs.

Repository: kdelibs

Description
The summary says it all. Simple meinproc call with the example template.

I propose this change for KDE/4.14 too, and it will be forward-ported to KDocTools/KF5.

Diffs
kdoctools/CMakeLists.txt 4dc6d8a
kdoctools/tests/CMakeLists.txt PRE-CREATION

Diff: <a href="https://git.reviewboard.kde.org/r/119446/diff/" title="https://git.reviewboard.kde.org/r/119446/diff/">https://git.reviewboard.kde.org/r/119446/diff/</a>

Testing
Compilation of kdelibs and few modules with documentation.

Thanks,

Luigi Toscano

Re: Review Request 119446: Add a simple test for meinproc

By Aleix Pol at 07/24/2014 - 19:36

Ship it!

Ship It!

- Aleix Pol Gonzalez

On July 24, 2014, 11:20 p.m., Luigi Toscano wrote: