DevHeads.net

Review Request 120154: Equal entries implies existing directory

Review request for kdelibs and David Faure.

Repository: kdelibs

Description
Equal entries implies existing directory

Diffs
kioslave/file/file_unix.cpp 4734399c3cde8e4a025539d8350ff1b3fabe83ae

Diff: <a href="https://git.reviewboard.kde.org/r/120154/diff/" title="https://git.reviewboard.kde.org/r/120154/diff/">https://git.reviewboard.kde.org/r/120154/diff/</a>

Testing
Equal entries implies existing directory

The equal file error should take precedence over the existing
directory error, as this implies exist.

This actually prevents a data loss on case-insensitive file systems
like CIFS, where renaming a directory from 'Test' to 'test' actually
removes the single directory (both have the same inode).

Thanks,

Jan-Marek Glogowski

Comments

Re: Review Request 120154: Equal entries implies existing direct

By Jan-Marek Glogowski at 11/23/2014 - 12:36

(Updated Nov. 23, 2014, 4:36 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs and David Faure.

Repository: kdelibs

Description
Equal entries implies existing directory

Diffs
kioslave/file/file_unix.cpp 4734399c3cde8e4a025539d8350ff1b3fabe83ae

Diff: <a href="https://git.reviewboard.kde.org/r/120154/diff/" title="https://git.reviewboard.kde.org/r/120154/diff/">https://git.reviewboard.kde.org/r/120154/diff/</a>

Testing
Equal entries implies existing directory

The equal file error should take precedence over the existing
directory error, as this implies exist.

This actually prevents a data loss on case-insensitive file systems
like CIFS, where renaming a directory from 'Test' to 'test' actually
removes the single directory (both have the same inode).

Thanks,

Jan-Marek Glogowski

Re: Review Request 120154: Equal entries implies existing direct

By Luigi Toscano at 11/23/2014 - 12:46

Which branch has the patch been submitted to?

- Luigi Toscano

On Nov. 23, 2014, 5:36 p.m., Jan-Marek Glogowski wrote:

Re: Review Request 120154: Equal entries implies existing direct

By David Faure at 11/23/2014 - 12:57

I was just cleaning up something that had already been committed.

dd160dee7c3f68aa49ad1868d87db61d69d10334 in kio master
bf0a8b445afe6caed0e89f7fcf5cda7d63d2ccf8 in kdelibs KDE/4.14

- David

On Nov. 23, 2014, 4:36 p.m., Jan-Marek Glogowski wrote:

Re: Review Request 120154: Equal entries implies existing direct

By David Faure at 11/23/2014 - 12:35

Ship it!

Ship It!

- David Faure

On Sept. 12, 2014, 7:25 a.m., Jan-Marek Glogowski wrote: