DevHeads.net

Review Request 120281: Use the correct locale

Review request for KDE Runtime.

Bugs: 329983
<a href="http://bugs.kde.org/show_bug.cgi?id=329983" title="http://bugs.kde.org/show_bug.cgi?id=329983">http://bugs.kde.org/show_bug.cgi?id=329983</a>

Repository: kde-runtime

Description
The test was expecting a specific locale. Everything seems to indicate
that any UTF-8 enabled locale would work for this testcases, so use
C.UTF-8 and avoid to have to depend on all locales.

Diffs
kioslave/trash/tests/testtrash.cpp f8d85de4ea4351bf91cba5ff374ae0ee5b567d5d

Diff: <a href="https://git.reviewboard.kde.org/r/120281/diff/" title="https://git.reviewboard.kde.org/r/120281/diff/">https://git.reviewboard.kde.org/r/120281/diff/</a>

Testing
Patch applied in Debian since 2014-01-14

Thanks,

Maximiliano Curia

Comments

Re: Review Request 120281: Use the correct locale

By Maximiliano Curia at 10/21/2015 - 05:31

(Updated Oct. 21, 2015, 10:31 a.m.)

Status
This change has been discarded.

Review request for KDE Runtime.

Bugs: 329983
<a href="http://bugs.kde.org/show_bug.cgi?id=329983" title="http://bugs.kde.org/show_bug.cgi?id=329983">http://bugs.kde.org/show_bug.cgi?id=329983</a>

Repository: kde-runtime

Description
The test was expecting a specific locale. Everything seems to indicate
that any UTF-8 enabled locale would work for this testcases, so use
C.UTF-8 and avoid to have to depend on all locales.

Diffs
kioslave/trash/tests/testtrash.cpp f8d85de4ea4351bf91cba5ff374ae0ee5b567d5d

Diff: <a href="https://git.reviewboard.kde.org/r/120281/diff/" title="https://git.reviewboard.kde.org/r/120281/diff/">https://git.reviewboard.kde.org/r/120281/diff/</a>

Testing
Patch applied in Debian since 2014-01-14

Thanks,

Maximiliano Curia

Re: Review Request 120281: Use the correct locale

By Luigi Toscano at 09/19/2014 - 13:19

C.UTF-8 is not a standard locale, even if quite a number of distributions support it, but not all:
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=902094" title="https://bugzilla.redhat.com/show_bug.cgi?id=902094">https://bugzilla.redhat.com/show_bug.cgi?id=902094</a>
<a href="https://sourceware.org/bugzilla/show_bug.cgi?id=17318" title="https://sourceware.org/bugzilla/show_bug.cgi?id=17318">https://sourceware.org/bugzilla/show_bug.cgi?id=17318</a>

- Luigi Toscano

On Set. 19, 2014, 1:18 p.m., Maximiliano Curia wrote: