DevHeads.net

Review Request 120543: Update FindPostgreSQL.cmake

Review request for kdelibs and Alexander Neundorf.

Repository: kdelibs

Description
Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from libpredicate (master).

With this improvement, copying FindPostgreSQL.cmake to projects such as Calligra/Kexi is no longer needed.

Diffs
cmake/modules/FindPostgreSQL.cmake 7955612

Diff: <a href="https://git.reviewboard.kde.org/r/120543/diff/" title="https://git.reviewboard.kde.org/r/120543/diff/">https://git.reviewboard.kde.org/r/120543/diff/</a>

Testing
Configuration works for as different include dir setups as openSUSE and Ubuntu. Behaviour on Windows/Mac not modified compared to what cmake originally provides.

Thanks,

Jarosław Staniek

Comments

Re: Review Request 120543: Update FindPostgreSQL.cmake

By Jaroslaw Staniek at 04/02/2015 - 09:02

(Updated April 2, 2015, 3:02 p.m.)

Status
This change has been discarded.

Review request for kdelibs and Alexander Neundorf.

Repository: kdelibs

Description
Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from libpredicate (master).

With this improvement, copying FindPostgreSQL.cmake to projects such as Calligra/Kexi is no longer needed.

Diffs
cmake/modules/FindPostgreSQL.cmake 7955612

Diff: <a href="https://git.reviewboard.kde.org/r/120543/diff/" title="https://git.reviewboard.kde.org/r/120543/diff/">https://git.reviewboard.kde.org/r/120543/diff/</a>

Testing
Configuration works for as different include dir setups as openSUSE and Ubuntu. Behaviour on Windows/Mac not modified compared to what cmake originally provides.

Thanks,

Jarosław Staniek

Re: Review Request 120543: Update FindPostgreSQL.cmake

By Rolf Eike Beer at 10/10/2014 - 02:05

I see no upstream bug report for this.

Eike

Re: Review Request 120543: Update FindPostgreSQL.cmake

By Jaroslaw Staniek at 10/10/2014 - 02:46

On 10 October 2014 08:05, Rolf Eike Beer < ... at opensource dot sf-tec.de> wrote:
Would a bug report for Calligra master be OK for you?
This is the only user of the PostgreSQL_TYPE_INCLUDE_DIR in entire KDE
I the know about:

<a href="http://lxr.kde.org/search?_filestring=&amp;_string=PostgreSQL_INCLUDE_DIR" title="http://lxr.kde.org/search?_filestring=&amp;_string=PostgreSQL_INCLUDE_DIR">http://lxr.kde.org/search?_filestring=&amp;_string=PostgreSQL_INCLUDE_DIR</a>

I am sorry if I misunderstood.

Good thing that the file disappears in KF5, since cmake has pretty
good own copy (not sufficient but I'll try to patch in the upstream).

Re: Review Request 120543: Update FindPostgreSQL.cmake

By Rolf Eike Beer at 10/10/2014 - 03:08

Am 10.10.2014 08:46, schrieb Jaroslaw Staniek:
You are not looking for PostgreSQL_TYPE_INCLUDE_DIR here, but for
PostgreSQL_INCLUDE_DIR. And there seems to be no user of that at all
inside KDE.

CMake is the relevant upstream, Calligra is downstream (i.e. it uses our
stuff).

Eike

Re: Review Request 120543: Update FindPostgreSQL.cmake

By Jaroslaw Staniek at 10/10/2014 - 04:02

On 10 October 2014 09:08, Rolf Eike Beer < ... at opensource dot sf-tec.de> wrote:
Right, the use of PostgreSQL_TYPE_INCLUDE_DIR is under review today,
the target is calligra master:

<a href="https://git.reviewboard.kde.org/r/120545/" title="https://git.reviewboard.kde.org/r/120545/">https://git.reviewboard.kde.org/r/120545/</a>

As you can see in that patch, I have a copy of the .cmake file
(FindCalligraPostgreSQL.cmake ) but this is to make it work with what
kdelibs that are currently distributed.

That's ok for my plans. Thanks.