DevHeads.net

Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

Review request for kdelibs and Kevin Kofler.

Repository: kompare

Description
Remove kdemacros.h and use generate_export_header for interfaces folder.

Diffs
interfaces/CMakeLists.txt 032ae985ac7221a498afff186211fbcad68cba78
interfaces/kompareinterface.h 07a271d0844767a2fee5af3e985c1b05d3640f05
interfaces/kompareinterfaceexport.h eed5c85eb4e4c091df2f32e58d3183600ca3a8c0

Diff: <a href="https://git.reviewboard.kde.org/r/120652/diff/" title="https://git.reviewboard.kde.org/r/120652/diff/">https://git.reviewboard.kde.org/r/120652/diff/</a>

Testing
Still builds and runs as expected.

Thanks,

Jeremy Whiting

Comments

Re: Review Request 120652: Remove kdemacros.h and use generate_e

By Jeremy Paul Whiting at 10/19/2014 - 16:44

(Updated Oct. 19, 2014, 8:44 p.m.)

Status
This change has been marked as submitted.

Review request for kdelibs and Kevin Kofler.

Repository: kompare

Description
Remove kdemacros.h and use generate_export_header for interfaces folder.

Diffs
interfaces/CMakeLists.txt 032ae985ac7221a498afff186211fbcad68cba78
interfaces/kompareinterface.h 07a271d0844767a2fee5af3e985c1b05d3640f05
interfaces/kompareinterfaceexport.h eed5c85eb4e4c091df2f32e58d3183600ca3a8c0

Diff: <a href="https://git.reviewboard.kde.org/r/120652/diff/" title="https://git.reviewboard.kde.org/r/120652/diff/">https://git.reviewboard.kde.org/r/120652/diff/</a>

Testing
Still builds and runs as expected.

Thanks,

Jeremy Whiting

Re: Review Request 120652: Remove kdemacros.h and use generate_e

By Aleix Pol at 10/19/2014 - 13:53

Ship it!

Ship It!

- Aleix Pol Gonzalez

On Oct. 19, 2014, 2:05 a.m., Jeremy Whiting wrote: