DevHeads.net

Review Request 120781: Allow stand-alone build of keditbookmarks

Review request for KDE Base Apps.

Repository: kde-baseapps

Description
This patch modifies keditbookmarks/CMakeLists.txt so that keditbookmarks can be built standalone.

Diffs
keditbookmarks/CMakeLists.txt 5b3d9c5

Diff: <a href="https://git.reviewboard.kde.org/r/120781/diff/" title="https://git.reviewboard.kde.org/r/120781/diff/">https://git.reviewboard.kde.org/r/120781/diff/</a>

Testing

Thanks,

Dan Vrátil

Comments

Re: Review Request 120781: Allow stand-alone build of keditbookm

By Dan Vratil at 10/28/2014 - 10:24

(Updated Oct. 28, 2014, 4:24 p.m.)

Review request for KDE Base Apps.

Changes
- fixed all issues

Repository: kde-baseapps

Description
This patch modifies keditbookmarks/CMakeLists.txt so that keditbookmarks can be built standalone.

Diffs (updated)
keditbookmarks/CMakeLists.txt 5b3d9c5

Diff: <a href="https://git.reviewboard.kde.org/r/120781/diff/" title="https://git.reviewboard.kde.org/r/120781/diff/">https://git.reviewboard.kde.org/r/120781/diff/</a>

Testing

Thanks,

Dan Vrátil

Re: Review Request 120781: Allow stand-alone build of keditbookm

By Dan Vratil at 10/29/2014 - 08:28

(Updated Oct. 29, 2014, 1:28 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Base Apps.

Repository: kde-baseapps

Description
This patch modifies keditbookmarks/CMakeLists.txt so that keditbookmarks can be built standalone.

Diffs
keditbookmarks/CMakeLists.txt 5b3d9c5

Diff: <a href="https://git.reviewboard.kde.org/r/120781/diff/" title="https://git.reviewboard.kde.org/r/120781/diff/">https://git.reviewboard.kde.org/r/120781/diff/</a>

Testing

Thanks,

Dan Vrátil

Re: Review Request 120781: Allow stand-alone build of keditbookm

By Christophe Gibo... at 10/29/2014 - 04:09

Ship it!

Ship It!

keditbookmarks/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120781/#comment48485>

kbookmarkmodel/tests/CMakeLists.txt already looks for Qt5Test

- Christophe Giboudeaux

On oct. 28, 2014, 3:24 après-midi, Dan Vrátil wrote:

Re: Review Request 120781: Allow stand-alone build of keditbookm

By Christophe Gibo... at 10/24/2014 - 14:56

keditbookmarks/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120781/#comment48317>

not needed

keditbookmarks/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120781/#comment48316>

KDEFrameworkCompilerSettings.cmake already enables QT_USE_FAST_OPERATOR_PLUS

- Christophe Giboudeaux

On oct. 24, 2014, 2:50 après-midi, Dan Vrátil wrote: