DevHeads.net

Review Request 121169: Use QFile::decodeName for command in KDEsuDialog to fix encoding

Review request for KDE Runtime.

Repository: kde-runtime

Description
KDEsu command may contain non-latin characters so we need to use QFile::decodeName to display them properly.

Diffs
kdesu/kdesu/kdesu.cpp cfd37ec

Diff: <a href="https://git.reviewboard.kde.org/r/121169/diff/" title="https://git.reviewboard.kde.org/r/121169/diff/">https://git.reviewboard.kde.org/r/121169/diff/</a>

Testing
This patch is used in ROSA and ALT Linux for a long time. <a href="http://bugs.rosalinux.ru/show_bug.cgi?id=1902" title="http://bugs.rosalinux.ru/show_bug.cgi?id=1902">http://bugs.rosalinux.ru/show_bug.cgi?id=1902</a>

Thanks,

Andrey Bondrov

Comments

Re: Review Request 121169: Use QFile::decodeName for command in

By Andrey Bondrov at 11/18/2014 - 21:52

(Updated Ноя. 19, 2014, 1:52 д.п.)

Status
This change has been marked as submitted.

Review request for KDE Runtime.

Repository: kde-runtime

Description
KDEsu command may contain non-latin characters so we need to use QFile::decodeName to display them properly.

Diffs
kdesu/kdesu/kdesu.cpp cfd37ec

Diff: <a href="https://git.reviewboard.kde.org/r/121169/diff/" title="https://git.reviewboard.kde.org/r/121169/diff/">https://git.reviewboard.kde.org/r/121169/diff/</a>

Testing
This patch is used in ROSA and ALT Linux for a long time. <a href="http://bugs.rosalinux.ru/show_bug.cgi?id=1902" title="http://bugs.rosalinux.ru/show_bug.cgi?id=1902">http://bugs.rosalinux.ru/show_bug.cgi?id=1902</a>

Thanks,

Andrey Bondrov

Re: Review Request 121169: Use QFile::decodeName for command in

By =?utf-8?b?THVrw... at 11/18/2014 - 15:46

Ship it!

Please commit to kdesu framework as well

- Lukáš Tinkl

On Lis. 18, 2014, 5:47 odp., Andrey Bondrov wrote:

Re: Review Request 121169: Use QFile::decodeName for command in

By Andrey Bondrov at 11/18/2014 - 21:52

Done.

- Andrey

On Ноя. 19, 2014, 1:52 д.п., Andrey Bondrov wrote: