DevHeads.net

Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros

Review request for kdelibs.

Repository: kactivities

Description
I've been unable to compile frameworks since I added the folowing options to kdesrc-buildrc

-Wall -Wformat -Werror=format-security -Werror=return-type -Wno-variadic-macros -Wlogical-op

Diffs
src/imports/resourcemodel.cpp ffdf571
src/service/plugins/sqlite/ResourceLinking.cpp be55ff5
src/workspace/settings/MainConfigurationWidget.cpp e130d1d

Diff: <a href="https://git.reviewboard.kde.org/r/121935/diff/" title="https://git.reviewboard.kde.org/r/121935/diff/">https://git.reviewboard.kde.org/r/121935/diff/</a>

Testing
It compiles with gcc 4.9 and clang++ (without those flags)

Thanks,

Jaime Torres Amate