DevHeads.net

Review Request 122394: Fix OSX library names in kdeinit5.app

Review request for kdelibs, David Faure and Ian Wadham.

Bugs: 343707
<a href="https://bugs.kde.org/show_bug.cgi?id=343707" title="https://bugs.kde.org/show_bug.cgi?id=343707">https://bugs.kde.org/show_bug.cgi?id=343707</a>

Repository: kinit

Description
OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed.

Diffs
src/kdeinit/kinit.cpp 3c3c913

Diff: <a href="https://git.reviewboard.kde.org/r/122394/diff/" title="https://git.reviewboard.kde.org/r/122394/diff/">https://git.reviewboard.kde.org/r/122394/diff/</a>

Testing
kdeinit5.app no longer complains about the missing .so libraries.

Thanks,

Jeremy Whiting

Comments

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

By Jeremy Paul Whiting at 02/02/2015 - 15:51

(Updated Feb. 2, 2015, 1:51 p.m.)

Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.

Changes
added kde-mac group.

Bugs: 343707
<a href="https://bugs.kde.org/show_bug.cgi?id=343707" title="https://bugs.kde.org/show_bug.cgi?id=343707">https://bugs.kde.org/show_bug.cgi?id=343707</a>

Repository: kinit

Description
OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed.

Diffs
src/kdeinit/kinit.cpp 3c3c913

Diff: <a href="https://git.reviewboard.kde.org/r/122394/diff/" title="https://git.reviewboard.kde.org/r/122394/diff/">https://git.reviewboard.kde.org/r/122394/diff/</a>

Testing
kdeinit5.app no longer complains about the missing .so libraries.

Thanks,

Jeremy Whiting

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

By =?utf-8?Q?Ren=C... at 02/02/2015 - 16:56

src/kdeinit/kinit.cpp
<https://git.reviewboard.kde.org/r/122394/#comment52052>

These are true shared libraries that are also used for "-l" style linking with ld?

- René J.V. Bertin

On Feb. 2, 2015, 9:51 p.m., Jeremy Whiting wrote:

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

By =?utf-8?Q?Ren=C... at 02/02/2015 - 18:44

What I mean is if there are applications (or other libraries) that link in those libraries using `-lKF5KIOCore`, `-lKF5Parts` or `-lKF5Plasma`. In that case, the .dylib extension is obligatory. In all other cases, the extension can in fact be anything. Thus, plugins and modules usually have the .so extension on OS X, just like on Linux.

Your modification is correct in itself (evidently, if you not longer get complaints about libraries not being found). But if those libraries are only ever loaded dynamically you could also modify the CMake file so that they are created with a .so extension (and leave the C++ code alone).

- René J.V.

On Feb. 2, 2015, 9:51 p.m., Jeremy Whiting wrote:

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

By Jeremy Paul Whiting at 02/02/2015 - 17:17

I'm not sure I understand the question, is there some other type of library on OSX besides "true shared libraries that are also used for -l style linking with ld"? file says they are Mach-O 64-bit dynamically linked shared library x86_64 if that helps answer your question.

- Jeremy

On Feb. 2, 2015, 1:51 p.m., Jeremy Whiting wrote:

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

By David Faure at 02/03/2015 - 01:46

Ship it!

René, these are shared libs, not plugins, so their name is correct.

- David Faure

On fév. 2, 2015, 8:51 après-midi, Jeremy Whiting wrote:

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

By Jeremy Paul Whiting at 02/03/2015 - 07:21

(Updated Feb. 3, 2015, 12:21 p.m.)

Status
This change has been marked as submitted.

Review request for KDE Software on Mac OS X, kdelibs, David Faure, and Ian Wadham.

Bugs: 343707
<a href="https://bugs.kde.org/show_bug.cgi?id=343707" title="https://bugs.kde.org/show_bug.cgi?id=343707">https://bugs.kde.org/show_bug.cgi?id=343707</a>

Repository: kinit

Description
OSX Doesn't have .so libraries, so use OSX names in kdeinit5.app to load the correct libraries needed.

Diffs
src/kdeinit/kinit.cpp 3c3c913

Diff: <a href="https://git.reviewboard.kde.org/r/122394/diff/" title="https://git.reviewboard.kde.org/r/122394/diff/">https://git.reviewboard.kde.org/r/122394/diff/</a>

Testing
kdeinit5.app no longer complains about the missing .so libraries.

Thanks,

Jeremy Whiting