DevHeads.net

Review Request 122471: Enable Compilation of about Protocol

Review request for kde-workspace and David Faure.

Repository: kio-extras

Description
Basically porting away from QUrl and KDE_EXPORT

Diffs
CMakeLists.txt 3379ce7
about/kio_about.h 620d6aa
about/kio_about.cpp d7396d8

Diff: <a href="https://git.reviewboard.kde.org/r/122471/diff/" title="https://git.reviewboard.kde.org/r/122471/diff/">https://git.reviewboard.kde.org/r/122471/diff/</a>

Testing
Tested compilation and installation:

$ find /home/david/kio-install/ -name "*about*"
/home/david/kio-install/lib64/plugins/kio_about.so
/home/david/kio-install/share/kservices5/about.protocol

Thanks,

David Narváez

Comments

Re: Review Request 122471: Enable Compilation of about Protocol

By David Narvaez at 02/09/2015 - 02:03

(Updated Feb. 9, 2015, 6:03 a.m.)

Review request for kde-workspace and David Faure.

Changes
Porting away from KUrl,KDE_EXPORT and KComponentData.

Repository: kio-extras

Description
Basically porting away from QUrl and KDE_EXPORT

Diffs (updated)
CMakeLists.txt 3379ce7
about/kio_about.h 620d6aa
about/kio_about.cpp d7396d8

Diff: <a href="https://git.reviewboard.kde.org/r/122471/diff/" title="https://git.reviewboard.kde.org/r/122471/diff/">https://git.reviewboard.kde.org/r/122471/diff/</a>

Testing
Tested compilation and installation:

$ find /home/david/kio-install/ -name "*about*"
/home/david/kio-install/lib64/plugins/kio_about.so
/home/david/kio-install/share/kservices5/about.protocol

Thanks,

David Narváez

Re: Review Request 122471: Enable Compilation of about Protocol

By David Narvaez at 02/09/2015 - 03:11

(Updated Feb. 9, 2015, 7:11 a.m.)

Status
This change has been marked as submitted.

Review request for kde-workspace and David Faure.

Repository: kio-extras

Description
Basically porting away from QUrl and KDE_EXPORT

Diffs
CMakeLists.txt 3379ce7
about/kio_about.h 620d6aa
about/kio_about.cpp d7396d8

Diff: <a href="https://git.reviewboard.kde.org/r/122471/diff/" title="https://git.reviewboard.kde.org/r/122471/diff/">https://git.reviewboard.kde.org/r/122471/diff/</a>

Testing
Tested compilation and installation:

$ find /home/david/kio-install/ -name "*about*"
/home/david/kio-install/lib64/plugins/kio_about.so
/home/david/kio-install/share/kservices5/about.protocol

Thanks,

David Narváez

Re: Review Request 122471: Enable Compilation of about Protocol

By laurent Montel at 02/09/2015 - 02:09

Seems good. Did you changed commit message as David told you ?
Otherwise ship it.

- Laurent Montel

On fév. 9, 2015, 6:03 matin, David Narváez wrote:

Re: Review Request 122471: Enable Compilation of about Protocol

By David Faure at 02/08/2015 - 05:29

What Laurent said, plus a bug in the commit log: you ported away from KUrl, not QUrl :-)

- David Faure

On Feb. 7, 2015, 10:23 p.m., David Narváez wrote:

Re: Review Request 122471: Enable Compilation of about Protocol

By laurent Montel at 02/08/2015 - 05:19

about/kio_about.cpp
<https://git.reviewboard.kde.org/r/122471/#comment52281>

QApplication app(argc, argv); app.setApplicationName(QLatin1String("kio_about"));

=> you remove KComponentData which is in kdelibs4support

- Laurent Montel

On fév. 7, 2015, 10:23 après-midi, David Narváez wrote:

Re: Review Request 122471: Enable Compilation of about Protocol

By David Faure at 02/08/2015 - 05:30

Well, QCoreApplication is enough.

- David

On Feb. 7, 2015, 10:23 p.m., David Narváez wrote:

Re: Review Request 122471: Enable Compilation of about Protocol

By Aleix Pol at 02/08/2015 - 13:27

Ship it!

Ship It!

- Aleix Pol Gonzalez

On Feb. 7, 2015, 11:23 p.m., David Narváez wrote: